[GitHub] flink pull request #5573: [FLINK-8756][Client] Support ClusterClient.getAccu...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5573#discussion_r170448311 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java --- @@ -363,6 +367,27 @@ public String

[jira] [Commented] (FLINK-8756) Support ClusterClient.getAccumulators() in RestClusterClient

[ https://issues.apache.org/jira/browse/FLINK-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376021#comment-16376021 ] ASF GitHub Bot commented on FLINK-8756: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8687) MaterializedCollectStreamResult#retrievePage should take resultLock

[ https://issues.apache.org/jira/browse/FLINK-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376346#comment-16376346 ] mingleizhang commented on FLINK-8687: - Does \{{retrievePage}} method will access by multi-threads ? >

[jira] [Assigned] (FLINK-8742) Move ConfigDocsGenerator annotation to flink-annotations

[ https://issues.apache.org/jira/browse/FLINK-8742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tuo Wang reassigned FLINK-8742: --- Assignee: Tuo Wang > Move ConfigDocsGenerator annotation to flink-annotations >

[GitHub] flink issue #5573: [FLINK-8756][Client] Support ClusterClient.getAccumulator...

Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5573 @GJL thanks for your guidance! @aljoscha and @tillrohrmann I have refactored this issue, remained the `getAccumulators` method created a `getSerializedAccumulators` method to return the

[jira] [Commented] (FLINK-8756) Support ClusterClient.getAccumulators() in RestClusterClient

[ https://issues.apache.org/jira/browse/FLINK-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376391#comment-16376391 ] ASF GitHub Bot commented on FLINK-8756: --- Github user yanghua commented on the issue:

[jira] [Updated] (FLINK-8602) Improve recovery performance for rocksdb backend

[ https://issues.apache.org/jira/browse/FLINK-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sihua Zhou updated FLINK-8602: -- Summary: Improve recovery performance for rocksdb backend (was: Accelerate recover from failover when

[jira] [Updated] (FLINK-8602) Improve recovery performance for rocksdb backend

[ https://issues.apache.org/jira/browse/FLINK-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sihua Zhou updated FLINK-8602: -- Description: Right now, RocksDB backend supports {{fully checkpoint}} & {{incremental checkpoint}}.

[jira] [Updated] (FLINK-8602) Improve recovery performance for rocksdb backend

[ https://issues.apache.org/jira/browse/FLINK-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sihua Zhou updated FLINK-8602: -- Description: Right now, RocksDB backend supports {{fully checkpoint}} & {{incremental checkpoint}}.

[jira] [Commented] (FLINK-8741) KafkaFetcher09/010/011 uses wrong user code classloader

[ https://issues.apache.org/jira/browse/FLINK-8741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376460#comment-16376460 ] ASF GitHub Bot commented on FLINK-8741: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #5568: [FLINK-8741] [kafka] Fix incorrect user code classloader ...

Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5568 @aljoscha yes, I ran a cluster job execution with and without the classloader fix. It fails before the fix. Merging this now to `master` and `release-1.4`. ---

[jira] [Commented] (FLINK-8500) Get the timestamp of the Kafka message from kafka consumer(Kafka010Fetcher)

[ https://issues.apache.org/jira/browse/FLINK-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376428#comment-16376428 ] yanxiaobin commented on FLINK-8500: --- hi, [~aljoscha] ! I can solve that problem like that，but I still

[GitHub] flink issue #5574: [FLINK-8772][kafka] fix missing log parameter

Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5574 Good catch @Matrix42, merging this ... ---

[jira] [Commented] (FLINK-8772) FlinkKafkaConsumerBase partitions discover missing a log parameter

[ https://issues.apache.org/jira/browse/FLINK-8772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376469#comment-16376469 ] ASF GitHub Bot commented on FLINK-8772: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #5568: [FLINK-8741] [kafka] Fix incorrect user code classloader ...

Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5568 Use ```ClassLoaderTestProgram.java``` do that test ? ---

[GitHub] flink issue #5568: [FLINK-8741] [kafka] Fix incorrect user code classloader ...

Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5568 Yes. Solved my end-to-end test doubt. But I would like to ask another question about child-first classloading in this issue. My understand is , If I submitted a flink application jar to flink

[jira] [Commented] (FLINK-8741) KafkaFetcher09/010/011 uses wrong user code classloader

[ https://issues.apache.org/jira/browse/FLINK-8741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376491#comment-16376491 ] ASF GitHub Bot commented on FLINK-8741: --- Github user zhangminglei commented on the issue:

[jira] [Commented] (FLINK-8756) Support ClusterClient.getAccumulators() in RestClusterClient

[ https://issues.apache.org/jira/browse/FLINK-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376470#comment-16376470 ] ASF GitHub Bot commented on FLINK-8756: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #5568: [FLINK-8741] [kafka] Fix incorrect user code classloader ...

Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5568 @zhangminglei the `ClassLoaderTestProgram`, AFAIK, tests parent/child first classloading. If what you are concerned about is that there is no end-to-end test for this fix, it is actually

[jira] [Commented] (FLINK-8741) KafkaFetcher09/010/011 uses wrong user code classloader

[ https://issues.apache.org/jira/browse/FLINK-8741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376472#comment-16376472 ] ASF GitHub Bot commented on FLINK-8741: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #5573: [FLINK-8756][Client] Support ClusterClient.getAccumulator...

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5573 I think it would be good to be able to query both representations. The stringified version can be good if you want to do a quick query using a rest client. And we don't have to change the Web UI if

[GitHub] flink pull request #5577: [FLINK-8776][flip6] Use correct port for job submi...

GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5577 [FLINK-8776][flip6] Use correct port for job submission from Web UI ## What is the purpose of the change *Use correct port for job submission from Web UI when Flink is deployed in YARN session

[jira] [Commented] (FLINK-8776) Cannot submit jobs from Web UI in FLIP-6 YARN Session

[ https://issues.apache.org/jira/browse/FLINK-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376067#comment-16376067 ] ASF GitHub Bot commented on FLINK-8776: --- GitHub user GJL opened a pull request:

[GitHub] flink issue #5573: [FLINK-8756][Client] Support ClusterClient.getAccumulator...

Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5573 I agree with @aljoscha. We could change the `JobAccumulatorsHandler` to return the serialized representation of the accumulator map instead of the stringified representation. We would then also

[jira] [Commented] (FLINK-8756) Support ClusterClient.getAccumulators() in RestClusterClient

[ https://issues.apache.org/jira/browse/FLINK-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376022#comment-16376022 ] ASF GitHub Bot commented on FLINK-8756: --- Github user tillrohrmann commented on the issue:

[jira] [Assigned] (FLINK-8772) FlinkKafkaConsumerBase partitions discover missing a log parameter

[ https://issues.apache.org/jira/browse/FLINK-8772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-8772: --- Assignee: Matrix42 > FlinkKafkaConsumerBase partitions discover missing a log

[GitHub] flink pull request #5576: [FLINK-8775] [flip6] Non blocking MiniCluster shut...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5576 ---

[GitHub] flink pull request #5575: [FLINK-8773] [flip6] Make JobManagerRunner shut do...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5575 ---

[jira] [Commented] (FLINK-8775) Make shut down of MiniCluster non blocking

[ https://issues.apache.org/jira/browse/FLINK-8775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376003#comment-16376003 ] ASF GitHub Bot commented on FLINK-8775: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-8774) Make shut down of ResourceManagerRunner non blocking

[ https://issues.apache.org/jira/browse/FLINK-8774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8774. Resolution: Fixed Fixed via c9787b6992f05b429edb0678050a1273900d1a63 > Make shut down of

[jira] [Closed] (FLINK-8775) Make shut down of MiniCluster non blocking

[ https://issues.apache.org/jira/browse/FLINK-8775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8775. Resolution: Fixed Fixed via 4e7f03e418ced740a731c9323dabef7a594db43c > Make shut down of

[GitHub] flink issue #5573: [FLINK-8756][Client] Support ClusterClient.getAccumulator...

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5573 @yanghua I'll have a look next week. From a first look it seems like we might have to extend the rest handler and the client to also return the accumulators as a `SerializedValue<>` as the old code

[jira] [Commented] (FLINK-8756) Support ClusterClient.getAccumulators() in RestClusterClient

[ https://issues.apache.org/jira/browse/FLINK-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376006#comment-16376006 ] ASF GitHub Bot commented on FLINK-8756: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-8756) Support ClusterClient.getAccumulators() in RestClusterClient

[ https://issues.apache.org/jira/browse/FLINK-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376069#comment-16376069 ] ASF GitHub Bot commented on FLINK-8756: --- Github user yanghua commented on the issue:

[GitHub] flink issue #5573: [FLINK-8756][Client] Support ClusterClient.getAccumulator...

Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5573 Hi @aljoscha and @tillrohrmann I have tried to put `Map` into `JobAccumulatorsInfo` with two ways : * a `@JsonProperty` * marked with `@JsonIgnore` and provide

[GitHub] flink pull request #5545: [FLINK-8718][DataStream] Set maxParallelism on non...

Github user GJL closed the pull request at: https://github.com/apache/flink/pull/5545 ---

[jira] [Updated] (FLINK-8772) FlinkKafkaConsumerBase partitions discover missing a log parameter

[ https://issues.apache.org/jira/browse/FLINK-8772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8772: Fix Version/s: 1.5.0 > FlinkKafkaConsumerBase partitions discover missing a log parameter >

[jira] [Commented] (FLINK-8718) Non-parallel DataStreamSource does not set max parallelism

[ https://issues.apache.org/jira/browse/FLINK-8718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375998#comment-16375998 ] ASF GitHub Bot commented on FLINK-8718: --- Github user GJL closed the pull request at:

[jira] [Updated] (FLINK-8772) FlinkKafkaConsumerBase partitions discover missing a log parameter

[ https://issues.apache.org/jira/browse/FLINK-8772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8772: Affects Version/s: 1.5.0 > FlinkKafkaConsumerBase partitions discover missing a log

[jira] [Commented] (FLINK-8773) Make shut down of JobManagerRunner non blocking

[ https://issues.apache.org/jira/browse/FLINK-8773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376002#comment-16376002 ] ASF GitHub Bot commented on FLINK-8773: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-8773) Make shut down of JobManagerRunner non blocking

[ https://issues.apache.org/jira/browse/FLINK-8773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8773. Resolution: Fixed Fixed via 2c40697e46c0e4e9b7c5b86a3ef94b31c3330cb6 > Make shut down of

[jira] [Commented] (FLINK-8756) Support ClusterClient.getAccumulators() in RestClusterClient

[ https://issues.apache.org/jira/browse/FLINK-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376027#comment-16376027 ] ASF GitHub Bot commented on FLINK-8756: --- Github user yanghua commented on the issue:

[GitHub] flink issue #5573: [FLINK-8756][Client] Support ClusterClient.getAccumulator...

Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5573 @aljoscha and @tillrohrmann , Thanks for your suggestion. I will rework for this. Moreover, @tillrohrmann would please review my another PR

[jira] [Created] (FLINK-8776) Cannot submit jobs from Web UI in FLIP-6 YARN Session

Gary Yao created FLINK-8776: --- Summary: Cannot submit jobs from Web UI in FLIP-6 YARN Session Key: FLINK-8776 URL: https://issues.apache.org/jira/browse/FLINK-8776 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-8756) Support ClusterClient.getAccumulators() in RestClusterClient

[ https://issues.apache.org/jira/browse/FLINK-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376075#comment-16376075 ] ASF GitHub Bot commented on FLINK-8756: --- Github user GJL commented on the issue:

[GitHub] flink issue #5573: [FLINK-8756][Client] Support ClusterClient.getAccumulator...

Github user GJL commented on the issue: https://github.com/apache/flink/pull/5573 @yanghua Take a look at `SerializedValueDeserializer` and `SerializedValueSerializer`. You can use `@JsonSerialize(using= ... )`, `@JsonSerialize(keyUsing= ... )`, and `@JsonDeserialize` to specify the

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376135#comment-16376135 ] ASF GitHub Bot commented on FLINK-8360: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5239 ---