[GitHub] flink issue #5982: [FLINK-9325][checkpoint]generate the meta file for checkp...

2018-05-15 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5982 Hi @StephanEwen, I added more tests for the `FileSystem#createAtomically()`, concerning the `TwoPhaseFsDataoutputStream`, can we introduce a `commit_on_close` option for it to make it easier to

[jira] [Commented] (FLINK-8933) Avoid calling Class#newInstance

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475315#comment-16475315 ] ASF GitHub Bot commented on FLINK-8933: --- Github user yanghua commented on the issue:

[GitHub] flink issue #6014: [FLINK-8933] Avoid calling Class#newInstance

2018-05-15 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6014 cc @StephanEwen & @zentol just one commit~ ---

[jira] [Created] (FLINK-9364) Add doc for the memory usage in flink

2018-05-15 Thread Sihua Zhou (JIRA)
Sihua Zhou created FLINK-9364: - Summary: Add doc for the memory usage in flink Key: FLINK-9364 URL: https://issues.apache.org/jira/browse/FLINK-9364 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-9325) generate the _meta file for checkpoint only when the writing is truly successful

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475318#comment-16475318 ] ASF GitHub Bot commented on FLINK-9325: --- Github user sihuazhou commented on the issue:

[jira] [Commented] (FLINK-8933) Avoid calling Class#newInstance

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475386#comment-16475386 ] ASF GitHub Bot commented on FLINK-8933: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-8933) Avoid calling Class#newInstance

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475405#comment-16475405 ] ASF GitHub Bot commented on FLINK-8933: --- Github user yanghua commented on the issue:

[jira] [Commented] (FLINK-8933) Avoid calling Class#newInstance

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475406#comment-16475406 ] ASF GitHub Bot commented on FLINK-8933: --- Github user yanghua closed the pull request at:

[jira] [Commented] (FLINK-8255) Key expressions on named row types do not work

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475411#comment-16475411 ] ASF GitHub Bot commented on FLINK-8255: --- Github user snuyanzin commented on the issue:

[GitHub] flink issue #5961: [FLINK-8255][DataSet API, DataStream API] key expressions...

2018-05-15 Thread snuyanzin
Github user snuyanzin commented on the issue: https://github.com/apache/flink/pull/5961 Hello @fhueske Thank you for your review As you proposed I tried to use org.apache.flink.api.java.typeutils.RowTypeInfo#isTupleType ```java public boolean isTupleType() {

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

2018-05-15 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475416#comment-16475416 ] Timo Walther commented on FLINK-8866: - I agree with (1), we could definitely reduce the number of

[jira] [Commented] (FLINK-5544) Implement Internal Timer Service in RocksDB

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475413#comment-16475413 ] ASF GitHub Bot commented on FLINK-5544: --- Github user StefanRRichter commented on the issue:

[jira] [Commented] (FLINK-8933) Avoid calling Class#newInstance

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475421#comment-16475421 ] ASF GitHub Bot commented on FLINK-8933: --- GitHub user yanghua opened a pull request:

[GitHub] flink pull request #6016: [FLINK-8933] Avoid calling Class#newInstance(part ...

2018-05-15 Thread yanghua
GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/6016 [FLINK-8933] Avoid calling Class#newInstance(part 2) ## What is the purpose of the change *This pull request avoid calling Class#newInstance* ## Brief change log -

[jira] [Commented] (FLINK-9008) End-to-end test: Quickstarts

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475463#comment-16475463 ] ASF GitHub Bot commented on FLINK-9008: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-9008) End-to-end test: Quickstarts

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475464#comment-16475464 ] ASF GitHub Bot commented on FLINK-9008: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5823: [FLINK-9008] [e2e] Implements quickstarts end to e...

2018-05-15 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5823#discussion_r188195999 --- Diff: flink-end-to-end-tests/test-scripts/test_quickstarts.sh --- @@ -0,0 +1,123 @@ +#!/usr/bin/env bash

[jira] [Commented] (FLINK-9008) End-to-end test: Quickstarts

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475465#comment-16475465 ] ASF GitHub Bot commented on FLINK-9008: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5823: [FLINK-9008] [e2e] Implements quickstarts end to e...

2018-05-15 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5823#discussion_r188196115 --- Diff: flink-end-to-end-tests/test-scripts/test_quickstarts.sh --- @@ -0,0 +1,123 @@ +#!/usr/bin/env bash

[jira] [Commented] (FLINK-9008) End-to-end test: Quickstarts

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475467#comment-16475467 ] ASF GitHub Bot commented on FLINK-9008: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-9008) End-to-end test: Quickstarts

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475462#comment-16475462 ] ASF GitHub Bot commented on FLINK-9008: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-9008) End-to-end test: Quickstarts

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475460#comment-16475460 ] ASF GitHub Bot commented on FLINK-9008: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5823: [FLINK-9008] [e2e] Implements quickstarts end to e...

2018-05-15 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5823#discussion_r188195971 --- Diff: flink-end-to-end-tests/test-scripts/test_quickstarts.sh --- @@ -0,0 +1,123 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #5823: [FLINK-9008] [e2e] Implements quickstarts end to e...

2018-05-15 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5823#discussion_r188195534 --- Diff: flink-end-to-end-tests/test-scripts/test_quickstarts.sh --- @@ -0,0 +1,123 @@ +#!/usr/bin/env bash

[jira] [Resolved] (FLINK-9304) Timer service shutdown should not be interrupted

2018-05-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-9304. -- Resolution: Fixed Fix Version/s: 1.4.3 1.5.0 Fixed via 1.6.0:

[GitHub] flink issue #5970: [FLINK-9292] [core] Remove TypeInfoParser (part 2)

2018-05-15 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5970 cc @tillrohrmann this can be merged thanks! ---

[jira] [Commented] (FLINK-8135) Add description to MessageParameter

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475473#comment-16475473 ] ASF GitHub Bot commented on FLINK-8135: --- Github user andrew-half commented on the issue:

[jira] [Created] (FLINK-9365) Add version information to remote rpc messages

2018-05-15 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-9365: Summary: Add version information to remote rpc messages Key: FLINK-9365 URL: https://issues.apache.org/jira/browse/FLINK-9365 Project: Flink Issue Type:

[jira] [Reopened] (FLINK-9348) scalastyle documentation for IntelliJ IDE setup

2018-05-15 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reopened FLINK-9348: - > scalastyle documentation for IntelliJ IDE setup >

[jira] [Updated] (FLINK-9348) scalastyle documentation for IntelliJ IDE setup

2018-05-15 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-9348: Fix Version/s: 1.5.0 > scalastyle documentation for IntelliJ IDE setup >

[jira] [Updated] (FLINK-9348) scalastyle documentation for IntelliJ IDE setup

2018-05-15 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-9348: Issue Type: Improvement (was: Bug) > scalastyle documentation for IntelliJ IDE setup >

[jira] [Closed] (FLINK-9348) scalastyle documentation for IntelliJ IDE setup

2018-05-15 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-9348. --- Resolution: Fixed > scalastyle documentation for IntelliJ IDE setup >

[GitHub] flink issue #6014: [FLINK-8933] Avoid calling Class#newInstance

2018-05-15 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6014 The discussion on the JIRA clearly came tot he conclusion to do this change in 2 commits. Please separate the PR. ---

[GitHub] flink issue #6014: [FLINK-8933] Avoid calling Class#newInstance

2018-05-15 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6014 OK now closing this and create two new PRs... ---

[GitHub] flink pull request #6014: [FLINK-8933] Avoid calling Class#newInstance

2018-05-15 Thread yanghua
Github user yanghua closed the pull request at: https://github.com/apache/flink/pull/6014 ---

[jira] [Commented] (FLINK-8933) Avoid calling Class#newInstance

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475412#comment-16475412 ] ASF GitHub Bot commented on FLINK-8933: --- GitHub user yanghua opened a pull request:

[GitHub] flink pull request #6015: [FLINK-8933] Avoid calling Class#newInstance(part ...

2018-05-15 Thread yanghua
GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/6015 [FLINK-8933] Avoid calling Class#newInstance(part 1) ## What is the purpose of the change *This pull request avoid calling Class#newInstance* ## Brief change log -

[GitHub] flink issue #3359: [FLINK-5544][streaming] Add InternalTimerService implemen...

2018-05-15 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3359 @shixiaogang thanks a lot! I will try to take a look at this as soon as possible. ---

[GitHub] flink issue #5823: [FLINK-9008] [e2e] Implements quickstarts end to end test

2018-05-15 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5823 @medcv That sounds like something we should do as part of the release process (if we are going to do it), orthogonal to this PR here. ---

[jira] [Commented] (FLINK-9008) End-to-end test: Quickstarts

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475431#comment-16475431 ] ASF GitHub Bot commented on FLINK-9008: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #5982: [FLINK-9325][checkpoint]generate the meta file for checkp...

2018-05-15 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5982 Hi, I met a problem here, for the Hadoop FileSystem when the `schema='hdfs'`, we can't rename a file to a existing file. This means that it hard(I'm not sure whether it's possible) to support the

[jira] [Commented] (FLINK-9325) generate the _meta file for checkpoint only when the writing is truly successful

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475438#comment-16475438 ] ASF GitHub Bot commented on FLINK-9325: --- Github user sihuazhou commented on the issue:

[GitHub] flink pull request #6011: [FLINK-9358] Avoid NPE when closing an unestablish...

2018-05-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6011 ---

[jira] [Commented] (FLINK-9194) Finished jobs are not archived to HistoryServer

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475441#comment-16475441 ] ASF GitHub Bot commented on FLINK-9194: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-9358) Closing of unestablished RM connections can cause NPE

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475439#comment-16475439 ] ASF GitHub Bot commented on FLINK-9358: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5902: [FLINK-9194][history] Add HistoryServer support to...

2018-05-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5902 ---

[jira] [Commented] (FLINK-9304) Timer service shutdown should not be interrupted

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475440#comment-16475440 ] ASF GitHub Bot commented on FLINK-9304: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5962: [FLINK-9304] Timer service shutdown should not sto...

2018-05-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5962 ---

[jira] [Resolved] (FLINK-9194) Finished jobs are not archived to HistoryServer

2018-05-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-9194. -- Resolution: Fixed Fix Version/s: (was: 1.6.0) 1.5.0 Fixed via

[jira] [Closed] (FLINK-9358) Closing of unestablished RM connections can cause NPE

2018-05-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-9358. Resolution: Fixed Fixed via master: a95ec5acf2 1.5.0: ee41e95b20 > Closing of unestablished RM

[jira] [Resolved] (FLINK-9246) HistoryServer job overview broken

2018-05-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-9246. -- Resolution: Fixed Fixed via master: 2cef5fded6 1.5.0: ca51c41063 > HistoryServer job overview

[GitHub] flink pull request #5823: [FLINK-9008] [e2e] Implements quickstarts end to e...

2018-05-15 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5823#discussion_r188195349 --- Diff: flink-end-to-end-tests/test-scripts/test_quickstarts.sh --- @@ -0,0 +1,123 @@ +#!/usr/bin/env bash

[GitHub] flink pull request #5823: [FLINK-9008] [e2e] Implements quickstarts end to e...

2018-05-15 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5823#discussion_r188194545 --- Diff: flink-end-to-end-tests/test-scripts/test_quickstarts.sh --- @@ -0,0 +1,123 @@ +#!/usr/bin/env bash

[jira] [Commented] (FLINK-9008) End-to-end test: Quickstarts

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475461#comment-16475461 ] ASF GitHub Bot commented on FLINK-9008: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5823: [FLINK-9008] [e2e] Implements quickstarts end to e...

2018-05-15 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5823#discussion_r188196219 --- Diff: flink-yarn/src/main/scala/org/apache/flink/yarn/YarnJobManager.scala --- @@ -34,7 +34,6 @@ import

[jira] [Commented] (FLINK-9008) End-to-end test: Quickstarts

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475466#comment-16475466 ] ASF GitHub Bot commented on FLINK-9008: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5823: [FLINK-9008] [e2e] Implements quickstarts end to e...

2018-05-15 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5823#discussion_r188194072 --- Diff: flink-end-to-end-tests/test-scripts/test_quickstarts.sh --- @@ -0,0 +1,123 @@ +#!/usr/bin/env bash

[GitHub] flink issue #6008: [FLINK-9354][travis] Print execution times for nightly E2...

2018-05-15 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6008 +1 LGTM ---

[jira] [Commented] (FLINK-9354) print execution times for end-to-end tests

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475469#comment-16475469 ] ASF GitHub Bot commented on FLINK-9354: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #5985: [FLINK-8135][docs] Add description to MessageParameter

2018-05-15 Thread andrew-half
Github user andrew-half commented on the issue: https://github.com/apache/flink/pull/5985 @walterddr @zentol Thank you guys for a substantial code-review. Please check the updates then you have time. ---

[jira] [Commented] (FLINK-9292) Remove TypeInfoParser

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475474#comment-16475474 ] ASF GitHub Bot commented on FLINK-9292: --- Github user yanghua commented on the issue:

[jira] [Commented] (FLINK-9350) Parameter baseInterval has wrong check message in CheckpointCoordinator constructor

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475478#comment-16475478 ] ASF GitHub Bot commented on FLINK-9350: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #6002: [FLINK-9350] Parameter baseInterval has wrong check messa...

2018-05-15 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6002 LGTM, merging .. ---

[GitHub] flink issue #5984: [FLINK-9328][state] Fix RocksDBStateBackend restore probl...

2018-05-15 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5984 Hi @Myasuka, it seems like your local branch is not properly rebased on the latest master. Could you try rebasing again and reopening the PR? ---

[jira] [Reopened] (FLINK-8922) Revert FLINK-8859 because it causes segfaults in testing

2018-05-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reopened FLINK-8922: -- > Revert FLINK-8859 because it causes segfaults in testing >

[jira] [Reopened] (FLINK-8859) RocksDB backend should pass WriteOption to Rocks.put() when restoring

2018-05-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reopened FLINK-8859: -- > RocksDB backend should pass WriteOption to Rocks.put() when restoring >

[jira] [Closed] (FLINK-8859) RocksDB backend should pass WriteOption to Rocks.put() when restoring

2018-05-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8859. Resolution: Fixed Fixed via 131daa28bf > RocksDB backend should pass WriteOption to Rocks.put()

[jira] [Closed] (FLINK-8922) Revert FLINK-8859 because it causes segfaults in testing

2018-05-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8922. Resolution: Feedback Received Fixed via a389b43581 > Revert FLINK-8859 because it causes segfaults

[jira] [Commented] (FLINK-8918) Introduce Runtime Filter Join

2018-05-15 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475900#comment-16475900 ] Sihua Zhou commented on FLINK-8918: --- Hi [~twalthr] I will appreciate it very much, If you'd like to have

[GitHub] flink issue #5982: [FLINK-9325][checkpoint]generate the meta file for checkp...

2018-05-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5982 Good point about the renaming on `close()` in case close is called for cleanup, rather than success. We could follow the same semantics as in

[jira] [Commented] (FLINK-9361) Changing refresh interval in changelog mode leads to exception

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475918#comment-16475918 ] ASF GitHub Bot commented on FLINK-9361: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-9091) Failure while enforcing releasability in building flink-json module

2018-05-15 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475809#comment-16475809 ] Timo Walther commented on FLINK-9091: - Does this issue also happen with Maven 3.5.3 on your machine?

[GitHub] flink pull request #5977: [FLINK-9295][kafka] Fix transactional.id collision...

2018-05-15 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5977#discussion_r188221002 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/functions/RuntimeContext.java --- @@ -71,6 +71,17 @@ @PublicEvolving

[jira] [Commented] (FLINK-9295) FlinkKafkaProducer011 sometimes throws ProducerFencedExceptions when in EXACTLY_ONCE mode

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475542#comment-16475542 ] ASF GitHub Bot commented on FLINK-9295: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink issue #5977: [FLINK-9295][kafka] Fix transactional.id collisions for F...

2018-05-15 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5977 Overall LGTM 👍 ---

[GitHub] flink issue #5847: [FLINK-9174][datastream]Fix the type of state created in ...

2018-05-15 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5847 cc @StefanRRichter could you please have a look at this... ---

[jira] [Commented] (FLINK-9174) The type of state created in ProccessWindowFunction.proccess() is inconsistency

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475552#comment-16475552 ] ASF GitHub Bot commented on FLINK-9174: --- Github user sihuazhou commented on the issue:

[jira] [Commented] (FLINK-8918) Introduce Runtime Filter Join

2018-05-15 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475549#comment-16475549 ] Sihua Zhou commented on FLINK-8918: --- Hi [~fhueske], I updated the description to describe the motivation

[jira] [Commented] (FLINK-9365) Add version information to remote rpc messages

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475651#comment-16475651 ] ASF GitHub Bot commented on FLINK-9365: --- GitHub user tillrohrmann opened a pull request:

[jira] [Commented] (FLINK-9341) Oracle: "Type is not supported: Date"

2018-05-15 Thread Sergey Nuyanzin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475693#comment-16475693 ] Sergey Nuyanzin commented on FLINK-9341: Hello please sorry if I'm wrong however working on

[jira] [Commented] (FLINK-6926) Add support for MD5, SHA1 and SHA2

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475692#comment-16475692 ] ASF GitHub Bot commented on FLINK-6926: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-9369) DistributedCache returns parent directory for directories

2018-05-15 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-9369. --- Resolution: Invalid > DistributedCache returns parent directory for directories >

[jira] [Reopened] (FLINK-9369) DistributedCache returns parent directory for directories

2018-05-15 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reopened FLINK-9369: - > DistributedCache returns parent directory for directories >

[jira] [Closed] (FLINK-6926) Add support for MD5, SHA1 and SHA2

2018-05-15 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-6926. --- Resolution: Fixed Fix Version/s: (was: 1.5.0) 1.6.0 Fixed in 1.6.0:

[GitHub] flink issue #6007: [FLINK-8518][Table API & SQL] Support DOW, EPOCH, DECADE ...

2018-05-15 Thread snuyanzin
Github user snuyanzin commented on the issue: https://github.com/apache/flink/pull/6007 @walterddr thank you for your comment it is just DOW implementation because to implement EPOCH we have to wait for CALCITE-2303 resolution about DECADE - there are 2 ways: one is also to

[jira] [Commented] (FLINK-8518) Support DOW, EPOCH, DECADE for EXTRACT

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475704#comment-16475704 ] ASF GitHub Bot commented on FLINK-8518: --- Github user snuyanzin commented on the issue:

[jira] [Closed] (FLINK-8816) Remove the oldWorker only after starting newWorker successfully in registerTaskExecutorInternal()

2018-05-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8816. Resolution: Fixed > Remove the oldWorker only after starting newWorker successfully in >

[jira] [Reopened] (FLINK-8816) Remove the oldWorker only after starting newWorker successfully in registerTaskExecutorInternal()

2018-05-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reopened FLINK-8816: -- Reopened to remove release notes. > Remove the oldWorker only after starting newWorker

[jira] [Updated] (FLINK-8816) Remove the oldWorker only after starting newWorker successfully in registerTaskExecutorInternal()

2018-05-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-8816: - Release Note: (was: The bug case cannot happen in flink.) > Remove the oldWorker only after

[jira] [Closed] (FLINK-8859) RocksDB backend should pass WriteOption to Rocks.put() when restoring

2018-05-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8859. Resolution: Fixed > RocksDB backend should pass WriteOption to Rocks.put() when restoring >

[jira] [Updated] (FLINK-8859) RocksDB backend should pass WriteOption to Rocks.put() when restoring

2018-05-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-8859: - Release Note: (was: Merged in 131daa28bf.) > RocksDB backend should pass WriteOption to

[jira] [Reopened] (FLINK-8859) RocksDB backend should pass WriteOption to Rocks.put() when restoring

2018-05-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reopened FLINK-8859: -- Reopened to remove release notes > RocksDB backend should pass WriteOption to Rocks.put() when

[jira] [Commented] (FLINK-8918) Introduce Runtime Filter Join

2018-05-15 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475893#comment-16475893 ] Sihua Zhou commented on FLINK-8918: --- Hi [~hequn8128], you hit the point definitely! The core and also

[jira] [Resolved] (FLINK-9361) Changing refresh interval in changelog mode leads to exception

2018-05-15 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-9361. - Resolution: Fixed Fix Version/s: 1.5.0 Fixed in 1.6.0:

[jira] [Commented] (FLINK-9325) generate the _meta file for checkpoint only when the writing is truly successful

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475919#comment-16475919 ] ASF GitHub Bot commented on FLINK-9325: --- Github user StephanEwen commented on the issue:

[GitHub] flink pull request #5995: [FLINK-9337] Implemented AvroDeserializationSchema

2018-05-15 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5995#discussion_r188316052 --- Diff: flink-formats/flink-avro-confluent-registry/pom.xml --- @@ -0,0 +1,94 @@ + + +http://maven.apache.org/POM/4.0.0; +

[jira] [Commented] (FLINK-9008) End-to-end test: Quickstarts

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475939#comment-16475939 ] ASF GitHub Bot commented on FLINK-9008: --- Github user medcv commented on the issue:

[jira] [Commented] (FLINK-9361) Changing refresh interval in changelog mode leads to exception

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475896#comment-16475896 ] ASF GitHub Bot commented on FLINK-9361: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-9361) Changing refresh interval in changelog mode leads to exception

2018-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475909#comment-16475909 ] ASF GitHub Bot commented on FLINK-9361: --- Github user twalthr commented on the issue:

[GitHub] flink issue #5823: [FLINK-9008] [e2e] Implements quickstarts end to end test

2018-05-15 Thread medcv
Github user medcv commented on the issue: https://github.com/apache/flink/pull/5823 @tzulitai I agree it should be separate of this PR. Main challenge is to upload a compiled Quickstart zip file contain all dependencies for each changes (minor) we do automatically. I was thinking

  1   2   3   >