[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544494#comment-16544494 ] ASF GitHub Bot commented on FLINK-8558: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #6323: [FLINK-8558] [FLINK-8866] [table] Finalize unified...

2018-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6323 ---

[GitHub] flink pull request #6201: [FLINK-8866][Table API & SQL] Add support for unif...

2018-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6201 ---

[jira] [Commented] (FLINK-8858) Add support for INSERT INTO in SQL Client

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544478#comment-16544478 ] ASF GitHub Bot commented on FLINK-8858: --- Github user twalthr commented on a diff in the pull

[jira] [Resolved] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

2018-07-15 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-8866. - Resolution: Fixed Fix Version/s: 1.6.0 Fixed in 1.6.0:

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544495#comment-16544495 ] ASF GitHub Bot commented on FLINK-8866: --- Github user asfgit closed the pull request at:

[jira] [Created] (FLINK-9850) Add a string to the print method to identify output for DataStream

2018-07-15 Thread Hequn Cheng (JIRA)
Hequn Cheng created FLINK-9850: -- Summary: Add a string to the print method to identify output for DataStream Key: FLINK-9850 URL: https://issues.apache.org/jira/browse/FLINK-9850 Project: Flink

[jira] [Commented] (FLINK-9675) Avoid FileInputStream/FileOutputStream

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544452#comment-16544452 ] ASF GitHub Bot commented on FLINK-9675: --- Github user zhangminglei commented on the issue:

[GitHub] flink issue #6335: [FLINK-9675] [fs] Avoid FileInputStream/FileOutputStream

2018-07-15 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/6335 Thanks @yanghua I will push the rest of the code then and fix the travis error. ---

[jira] [Created] (FLINK-9852) Expose descriptor-based sink creation in table environments

2018-07-15 Thread Timo Walther (JIRA)
Timo Walther created FLINK-9852: --- Summary: Expose descriptor-based sink creation in table environments Key: FLINK-9852 URL: https://issues.apache.org/jira/browse/FLINK-9852 Project: Flink

[GitHub] flink pull request #6336: [FLINK-9630] [connector] Kafka09PartitionDiscovere...

2018-07-15 Thread ubyyj
GitHub user ubyyj opened a pull request: https://github.com/apache/flink/pull/6336 [FLINK-9630] [connector] Kafka09PartitionDiscoverer cause connection … …leak on TopicAuthorizationException **(The sections below can be removed for hotfixes of typos)** ##

[jira] [Updated] (FLINK-9630) Kafka09PartitionDiscoverer cause connection leak on TopicAuthorizationException

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9630: -- Labels: pull-request-available (was: ) > Kafka09PartitionDiscoverer cause connection leak on

[jira] [Commented] (FLINK-9061) add entropy to s3 path for better scalability

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544603#comment-16544603 ] ASF GitHub Bot commented on FLINK-9061: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #6302: [FLINK-9061][checkpointing] add entropy to s3 path for be...

2018-07-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/6302 Thanks for this contribution, that's a valuable fix. I have a few thoughts and suggestions on how we might improve the feature a bit still: - Can we get id of the `commons-text`

[GitHub] flink pull request #5516: [FLINK-8544] [Kafka Connector] Handle null message...

2018-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5516 ---

[GitHub] flink pull request #6109: [FLINK-9483] 'Building Flink' doc doesn't highligh...

2018-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6109 ---

[jira] [Commented] (FLINK-9483) "Building Flink" doc doesn't highlight quick build command

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544630#comment-16544630 ] ASF GitHub Bot commented on FLINK-9483: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #6260: [FLINK-9758] Fix ContinuousFileProcessingTest fail...

2018-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6260 ---

[GitHub] flink issue #6329: [FLINK-9841] Web UI only show partial taskmanager log

2018-07-15 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6329 @dawidwys can you review this PR? ---

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544663#comment-16544663 ] ASF GitHub Bot commented on FLINK-7251: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544671#comment-16544671 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202553358 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/TieBreakingPriorityComparator.java --- @@ -85,10 +85,10 @@ public int compare(T

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544673#comment-16544673 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544675#comment-16544675 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544669#comment-16544669 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202552563 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyGroupPartitioner.java --- @@ -264,6 +265,42 @@ public void

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202553887 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java --- @@ -446,8 +485,10 @@ public String toString()

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202552705 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredBroadcastStateBackendMetaInfo.java --- @@ -24,37 +24,46 @@ import

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544672#comment-16544672 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202552876 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredBroadcastStateBackendMetaInfo.java --- @@ -63,54 +72,46 @@ public

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202553524 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CachingInternalPriorityQueueSet.java --- @@ -80,13 +82,57 @@ public E peek()

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544667#comment-16544667 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202553958 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueueStateSnapshot.java --- @@ -60,36 +61,35 @@

[jira] [Commented] (FLINK-9853) add hex support in table api and sql

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544542#comment-16544542 ] ASF GitHub Bot commented on FLINK-9853: --- GitHub user xueyumusic opened a pull request:

[GitHub] flink pull request #6337: [FLINK-9853][Tabel API & SQL] add HEX support

2018-07-15 Thread xueyumusic
GitHub user xueyumusic opened a pull request: https://github.com/apache/flink/pull/6337 [FLINK-9853][Tabel API & SQL] add HEX support ## What is the purpose of the change This PR propose to add HEX in table api and sql, the syntax like mysql, which could take int or string

[jira] [Updated] (FLINK-9853) add hex support in table api and sql

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9853: -- Labels: pull-request-available (was: ) > add hex support in table api and sql >

[jira] [Commented] (FLINK-9630) Kafka09PartitionDiscoverer cause connection leak on TopicAuthorizationException

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544541#comment-16544541 ] ASF GitHub Bot commented on FLINK-9630: --- GitHub user ubyyj opened a pull request:

[jira] [Commented] (FLINK-9841) Web UI only show partial taskmanager log

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544549#comment-16544549 ] ASF GitHub Bot commented on FLINK-9841: --- Github user yanghua commented on the issue:

[jira] [Resolved] (FLINK-8544) JSONKeyValueDeserializationSchema throws NPE when message key is null

2018-07-15 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz resolved FLINK-8544. - Resolution: Fixed Fix Version/s: 1.6.0 > JSONKeyValueDeserializationSchema throws

[jira] [Resolved] (FLINK-9483) "Building Flink" doc doesn't highlight quick build command

2018-07-15 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz resolved FLINK-9483. - Resolution: Fixed > "Building Flink" doc doesn't highlight quick build command >

[jira] [Commented] (FLINK-8858) Add support for INSERT INTO in SQL Client

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544654#comment-16544654 ] ASF GitHub Bot commented on FLINK-8858: --- Github user asfgit closed the pull request at:

[jira] [Created] (FLINK-9854) Allow passing multi-line input to SQL Client CLI

2018-07-15 Thread Timo Walther (JIRA)
Timo Walther created FLINK-9854: --- Summary: Allow passing multi-line input to SQL Client CLI Key: FLINK-9854 URL: https://issues.apache.org/jira/browse/FLINK-9854 Project: Flink Issue Type:

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202553765 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java --- @@ -342,16 +379,20 @@ private void

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544668#comment-16544668 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202552616 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/PriorityComparable.java --- @@ -0,0 +1,35 @@ +/* + * Licensed to the

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202552483 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyExtractorFunction.java --- @@ -28,9 +28,22 @@ @FunctionalInterface

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544676#comment-16544676 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544670#comment-16544670 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544674#comment-16544674 ] ASF GitHub Bot commented on FLINK-9489: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Assigned] (FLINK-9850) Add a string to the print method to identify output for DataStream

2018-07-15 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-9850: --- Assignee: vinoyang > Add a string to the print method to identify output for DataStream >

[GitHub] flink issue #6260: [FLINK-9758] Fix ContinuousFileProcessingTest failure due...

2018-07-15 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/6260 +1, merging ---

[jira] [Commented] (FLINK-9758) ContinuousFileProcessingTest failed due to not setting runtimeContext

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544537#comment-16544537 ] ASF GitHub Bot commented on FLINK-9758: --- Github user dawidwys commented on the issue:

[jira] [Commented] (FLINK-8731) TwoInputStreamTaskTest flaky on travis

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544632#comment-16544632 ] ASF GitHub Bot commented on FLINK-8731: --- GitHub user dawidwys opened a pull request:

[jira] [Resolved] (FLINK-9758) ContinuousFileProcessingTest failed due to not setting runtimeContext

2018-07-15 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz resolved FLINK-9758. - Resolution: Fixed Fix Version/s: (was: 1.5.2) 1.6.0 >

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-15 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r202553410 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java --- @@ -584,21 +581,6 @@ private static void registerFactory(Type

[jira] [Created] (FLINK-9853) add hex support in table api and sql

2018-07-15 Thread xueyu (JIRA)
xueyu created FLINK-9853: Summary: add hex support in table api and sql Key: FLINK-9853 URL: https://issues.apache.org/jira/browse/FLINK-9853 Project: Flink Issue Type: Improvement

[GitHub] flink issue #6335: [FLINK-9675] [fs] Avoid FileInputStream/FileOutputStream

2018-07-15 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/6335 @tedyu Could you please take a look on this ? Thank you very much. ---

[jira] [Commented] (FLINK-9675) Avoid FileInputStream/FileOutputStream

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544544#comment-16544544 ] ASF GitHub Bot commented on FLINK-9675: --- Github user zhangminglei commented on the issue:

[jira] [Commented] (FLINK-9794) JDBCOutputFormat does not consider idle connection and multithreads synchronization

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544554#comment-16544554 ] ASF GitHub Bot commented on FLINK-9794: --- Github user jrthe42 commented on the issue:

[GitHub] flink issue #6301: [FLINK-9794] [jdbc] JDBCOutputFormat does not consider id...

2018-07-15 Thread jrthe42
Github user jrthe42 commented on the issue: https://github.com/apache/flink/pull/6301 Hi @hequn8128, I agree with you that a connection pool is more effective using connection resource. I didn't choose connection pool because that will introduce new dependencies, and I'm not sure if

[jira] [Commented] (FLINK-9829) The wrapper classes be compared by symbol of '==' directly in BigDecSerializer.java

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544599#comment-16544599 ] ASF GitHub Bot commented on FLINK-9829: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #6321: [FLINK-9829] fix the wrapper classes be compared by symbo...

2018-07-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/6321 Is the issue addressed here a bug? If not, and if it seems that the original authors of the code had an intention of writing the code as it is now, I would suggest to leave it as it is.

[jira] [Commented] (FLINK-9121) Remove Flip-6 prefixes from code base

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544602#comment-16544602 ] ASF GitHub Bot commented on FLINK-9121: --- Github user Matrix42 commented on a diff in the pull

[GitHub] flink pull request #5801: [FLINK-9121] [flip6] Remove Flip6 prefixes and oth...

2018-07-15 Thread Matrix42
Github user Matrix42 commented on a diff in the pull request: https://github.com/apache/flink/pull/5801#discussion_r202548776 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java --- @@ -49,30 +54,45 @@ public YarnClusterDescriptor(

[jira] [Commented] (FLINK-9404) Adapter viewfs in BucketingSink when verify that truncate actually works

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544611#comment-16544611 ] ASF GitHub Bot commented on FLINK-9404: --- Github user asfgit closed the pull request at:

[GitHub] flink issue #6326: Mutual authentication for internal communication

2018-07-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/6326 Pushed another commit that rebuilds the generated config docs ---

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-15 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r202552984 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java --- @@ -584,21 +581,6 @@ private static void registerFactory(Type

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544657#comment-16544657 ] ASF GitHub Bot commented on FLINK-7251: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-9829) The wrapper classes be compared by symbol of '==' directly in BigDecSerializer.java

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544598#comment-16544598 ] ASF GitHub Bot commented on FLINK-9829: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #6321: [FLINK-9829] fix the wrapper classes be compared by symbo...

2018-07-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/6321 This would be clearly not a hotfix. As per the pull request template, contributors should use hotfixes mainly for typos and JavaDoc updates. ---

[GitHub] flink pull request #6050: [FLINK-9404][flink-connector-filesystem] Adapter v...

2018-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6050 ---

[jira] [Commented] (FLINK-8544) JSONKeyValueDeserializationSchema throws NPE when message key is null

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544629#comment-16544629 ] ASF GitHub Bot commented on FLINK-8544: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-9758) ContinuousFileProcessingTest failed due to not setting runtimeContext

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544631#comment-16544631 ] ASF GitHub Bot commented on FLINK-9758: --- Github user asfgit closed the pull request at:

[jira] [Updated] (FLINK-8731) TwoInputStreamTaskTest flaky on travis

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-8731: -- Labels: pull-request-available test-stability (was: test-stability) > TwoInputStreamTaskTest

[GitHub] flink pull request #6338: [FLINK-8731] Replaced mockito with custom mock in ...

2018-07-15 Thread dawidwys
GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/6338 [FLINK-8731] Replaced mockito with custom mock in TestInputChannel Replaced questionable usage if Mockito with custom written mock. You can merge this pull request into a Git repository by

[jira] [Commented] (FLINK-9675) Avoid FileInputStream/FileOutputStream

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544617#comment-16544617 ] ASF GitHub Bot commented on FLINK-9675: --- Github user tedyu commented on the issue:

[GitHub] flink issue #6335: [FLINK-9675] [fs] Avoid FileInputStream/FileOutputStream

2018-07-15 Thread tedyu
Github user tedyu commented on the issue: https://github.com/apache/flink/pull/6335 From https://travis-ci.org/apache/flink/jobs/404127448 : ``` Failed tests: BlobServerPutTest.testPutBufferFailsIncomingForJob Expected: (an instance of java.io.IOException and

[jira] [Resolved] (FLINK-8858) Add support for INSERT INTO in SQL Client

2018-07-15 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-8858. - Resolution: Fixed Fix Version/s: 1.6.0 Fixed in 1.6.0:

[GitHub] flink pull request #6332: [FLINK-8858] [sql-client] Add support for INSERT I...

2018-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6332 ---

[GitHub] flink issue #6323: [FLINK-8558] [FLINK-8866] [table] Finalize unified table ...

2018-07-15 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/6323 Thank @pnowojski. Merging this... ---

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544464#comment-16544464 ] ASF GitHub Bot commented on FLINK-8558: --- Github user twalthr commented on a diff in the pull

[jira] [Created] (FLINK-9851) Add documentation for unified table sources/sinks

2018-07-15 Thread Timo Walther (JIRA)
Timo Walther created FLINK-9851: --- Summary: Add documentation for unified table sources/sinks Key: FLINK-9851 URL: https://issues.apache.org/jira/browse/FLINK-9851 Project: Flink Issue Type:

[GitHub] flink pull request #6323: [FLINK-8558] [FLINK-8866] [table] Finalize unified...

2018-07-15 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6323#discussion_r202535180 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactoryService.scala --- @@ -18,143 +18,358 @@

[jira] [Commented] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544465#comment-16544465 ] ASF GitHub Bot commented on FLINK-8558: --- Github user twalthr commented on the issue:

[GitHub] flink pull request #6332: [FLINK-8858] [sql-client] Add support for INSERT I...

2018-07-15 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6332#discussion_r202536081 --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java --- @@ -173,55 +180,92 @@ public void open() {

[jira] [Resolved] (FLINK-8558) Add unified format interfaces and format discovery

2018-07-15 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-8558. - Resolution: Fixed Fix Version/s: 1.6.0 Fixed in 1.6.0:

[GitHub] flink issue #6336: [FLINK-9630] [connector] Kafka09PartitionDiscoverer cause...

2018-07-15 Thread ubyyj
Github user ubyyj commented on the issue: https://github.com/apache/flink/pull/6336 unrelavent build failure, close and will reopen again, to trigger travis build again ---

[GitHub] flink pull request #6336: [FLINK-9630] [connector] Kafka09PartitionDiscovere...

2018-07-15 Thread ubyyj
Github user ubyyj closed the pull request at: https://github.com/apache/flink/pull/6336 ---

[GitHub] flink pull request #6336: [FLINK-9630] [connector] Kafka09PartitionDiscovere...

2018-07-15 Thread ubyyj
GitHub user ubyyj reopened a pull request: https://github.com/apache/flink/pull/6336 [FLINK-9630] [connector] Kafka09PartitionDiscoverer cause connection … …leak on TopicAuthorizationException **(The sections below can be removed for hotfixes of typos)**

[jira] [Commented] (FLINK-9630) Kafka09PartitionDiscoverer cause connection leak on TopicAuthorizationException

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544720#comment-16544720 ] ASF GitHub Bot commented on FLINK-9630: --- Github user ubyyj closed the pull request at:

[GitHub] flink issue #6336: [FLINK-9630] [connector] Kafka09PartitionDiscoverer cause...

2018-07-15 Thread ubyyj
Github user ubyyj commented on the issue: https://github.com/apache/flink/pull/6336 trigger travis build ---

[jira] [Commented] (FLINK-9630) Kafka09PartitionDiscoverer cause connection leak on TopicAuthorizationException

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544721#comment-16544721 ] ASF GitHub Bot commented on FLINK-9630: --- Github user ubyyj commented on the issue:

[jira] [Commented] (FLINK-9630) Kafka09PartitionDiscoverer cause connection leak on TopicAuthorizationException

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544722#comment-16544722 ] ASF GitHub Bot commented on FLINK-9630: --- GitHub user ubyyj reopened a pull request:

[jira] [Commented] (FLINK-9630) Kafka09PartitionDiscoverer cause connection leak on TopicAuthorizationException

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544723#comment-16544723 ] ASF GitHub Bot commented on FLINK-9630: --- Github user ubyyj commented on the issue:

[GitHub] flink pull request #6321: [FLINK-9829] fix the wrapper classes be compared b...

2018-07-15 Thread lamber-ken
Github user lamber-ken commented on a diff in the pull request: https://github.com/apache/flink/pull/6321#discussion_r202566500 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/BigDecSerializer.java --- @@ -69,17 +69,17 @@ public void

[jira] [Commented] (FLINK-9829) The wrapper classes be compared by symbol of '==' directly in BigDecSerializer.java

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544745#comment-16544745 ] ASF GitHub Bot commented on FLINK-9829: --- Github user lamber-ken commented on a diff in the pull

[GitHub] flink issue #6326: Mutual authentication for internal communication

2018-07-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/6326 Thanks for the review and for merging. @NicoK has an end-to-end test for SSL PR already (#6327) which would be great to rebase on top of this change. ---

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202556091 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java --- @@ -446,8 +485,10 @@ public String

[jira] [Commented] (FLINK-9489) Checkpoint timers as part of managed keyed state instead of raw keyed state

2018-07-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544693#comment-16544693 ] ASF GitHub Bot commented on FLINK-9489: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #6333: [FLINK-9489] Checkpoint timers as part of managed ...

2018-07-15 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6333#discussion_r202556109 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CachingInternalPriorityQueueSet.java --- @@ -80,13 +82,57 @@ public E

  1   2   >