[GitHub] [flink] flinkbot commented on pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem

2020-05-08 Thread GitBox
flinkbot commented on pull request #12035: URL: https://github.com/apache/flink/pull/12035#issuecomment-625745162 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Created] (FLINK-17575) KafkaException: Received exception when fetching the next record from XXX-14. If needed, please seek past the record to continue consumption.

2020-05-08 Thread Maxim Malykhin (Jira)
Maxim Malykhin created FLINK-17575: -- Summary: KafkaException: Received exception when fetching the next record from XXX-14. If needed, please seek past the record to continue consumption. Key: FLINK-17575 URL:

[jira] [Updated] (FLINK-17537) Refactor flink-jdbc connector structure

2020-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-17537: --- Labels: pull-request-available (was: ) > Refactor flink-jdbc connector structure >

[GitHub] [flink] leonardBang opened a new pull request #12036: [FLINK-17537][connectors / jdbc] Refactor flink-jdbc connector structure

2020-05-08 Thread GitBox
leonardBang opened a new pull request #12036: URL: https://github.com/apache/flink/pull/12036 ## What is the purpose of the change * This pull request refactor flink-jdbc connector structure and make it align with others in connector family. I split the PR to two commits

[jira] [Assigned] (FLINK-17357) add "DROP catalog" DDL to blink planner

2020-05-08 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-17357: Assignee: Nicholas Jiang > add "DROP catalog" DDL to blink planner >

[jira] [Commented] (FLINK-17357) add "DROP catalog" DDL to blink planner

2020-05-08 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102461#comment-17102461 ] Jingsong Lee commented on FLINK-17357: -- [~nicholasjiang] assigned to you. Thanks for contribution.

[GitHub] [flink] zhijiangW commented on pull request #11687: [FLINK-16536][network][checkpointing] Implement InputChannel state recovery for unaligned checkpoint

2020-05-08 Thread GitBox
zhijiangW commented on pull request #11687: URL: https://github.com/apache/flink/pull/11687#issuecomment-625758389 I have addressed the above comments in new separate commits and squash all the previous commits. @pnowojski

[GitHub] [flink] jinglining commented on pull request #11752: [FLINK-14713][rest]Show All Attempts For Vertex SubTask In Rest Api

2020-05-08 Thread GitBox
jinglining commented on pull request #11752: URL: https://github.com/apache/flink/pull/11752#issuecomment-625765695 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] dianfu commented on pull request #12013: [FLINK-17256] Suppport keyword arguments in the PyFlink Descriptor API.

2020-05-08 Thread GitBox
dianfu commented on pull request #12013: URL: https://github.com/apache/flink/pull/12013#issuecomment-625767914 The failed tests are not related to this PR. Have created ticket FLINK-17576 to tract that. This is an

[GitHub] [flink] flinkbot commented on pull request #12038: [FLINK-14101][jdbc] Added MS SQL-server dialect

2020-05-08 Thread GitBox
flinkbot commented on pull request #12038: URL: https://github.com/apache/flink/pull/12038#issuecomment-625769408 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Comment Edited] (FLINK-17571) A better way to show the files used in currently checkpoints

2020-05-08 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102482#comment-17102482 ] Piotr Nowojski edited comment on FLINK-17571 at 5/8/20, 11:22 AM: -- Do

[GitHub] [flink] danny0405 opened a new pull request #12039: [FLINK-17577] SinkFormat#createSinkFormat should use DynamicTableSink…

2020-05-08 Thread GitBox
danny0405 opened a new pull request #12039: URL: https://github.com/apache/flink/pull/12039 ….Context as the first parameter This interface was introduced in FLINK-16997, it uses the ScanTableSource.Context as the first param, which is not correct.

[jira] [Updated] (FLINK-17577) SinkFormat#createSinkFormat should use DynamicTableSink.Context as the first parameter

2020-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-17577: --- Labels: pull-request-available (was: ) > SinkFormat#createSinkFormat should use

[jira] [Created] (FLINK-17578) Union of 2 SideOutputs behaviour incorrect

2020-05-08 Thread Tom Wells (Jira)
Tom Wells created FLINK-17578: - Summary: Union of 2 SideOutputs behaviour incorrect Key: FLINK-17578 URL: https://issues.apache.org/jira/browse/FLINK-17578 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-17566) Fix potential K8s resources leak after JobManager finishes in Applicaion mode

2020-05-08 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102531#comment-17102531 ] Yang Wang commented on FLINK-17566: --- Sounds good. But i am not sure whether we need to bump the

[jira] [Updated] (FLINK-16548) Expose consistent environment variable to identify the component name and resource id of jm/tm

2020-05-08 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo updated FLINK-16548: --- Description: We proposed to expose environment variable to identify the component name and

[GitHub] [flink] wuchong commented on pull request #12039: [FLINK-17577] SinkFormat#createSinkFormat should use DynamicTableSink…

2020-05-08 Thread GitBox
wuchong commented on pull request #12039: URL: https://github.com/apache/flink/pull/12039#issuecomment-625800939 Looks good to me. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] Jiayi-Liao commented on a change in pull request #10068: [FLINK-13702][FLINK-13740] Fixed issues with generic types and materialization of lazy binary formats in blink planner

2020-05-08 Thread GitBox
Jiayi-Liao commented on a change in pull request #10068: URL: https://github.com/apache/flink/pull/10068#discussion_r422127101 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/typeutils/BinaryGenericSerializer.java ## @@ -127,63

[GitHub] [flink] Jiayi-Liao commented on a change in pull request #10068: [FLINK-13702][FLINK-13740] Fixed issues with generic types and materialization of lazy binary formats in blink planner

2020-05-08 Thread GitBox
Jiayi-Liao commented on a change in pull request #10068: URL: https://github.com/apache/flink/pull/10068#discussion_r422127101 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/typeutils/BinaryGenericSerializer.java ## @@ -127,63

[GitHub] [flink] Jiayi-Liao commented on a change in pull request #10068: [FLINK-13702][FLINK-13740] Fixed issues with generic types and materialization of lazy binary formats in blink planner

2020-05-08 Thread GitBox
Jiayi-Liao commented on a change in pull request #10068: URL: https://github.com/apache/flink/pull/10068#discussion_r422127101 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/typeutils/BinaryGenericSerializer.java ## @@ -127,63

[jira] [Updated] (FLINK-17506) SavepointEnvironment does not honour 'io.tmp.dirs' property

2020-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-17506: --- Labels: pull-request-available (was: ) > SavepointEnvironment does not honour

[GitHub] [flink] flinkbot commented on pull request #12041: [FLINK-17506][state-processor-api] SavepointEnvironment should honour 'io.tmp.dirs' property

2020-05-08 Thread GitBox
flinkbot commented on pull request #12041: URL: https://github.com/apache/flink/pull/12041#issuecomment-625810298 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-16367) Introduce createStatementSet method in TableEnvironment

2020-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-16367: --- Labels: pull-request-available (was: ) > Introduce createStatementSet method in

[GitHub] [flink] godfreyhe opened a new pull request #12042: [FLINK-16367] [table] Introduce TableEnvironment#createStatementSet api

2020-05-08 Thread GitBox
godfreyhe opened a new pull request #12042: URL: https://github.com/apache/flink/pull/12042 ## What is the purpose of the change *Introduce TableEnvironment#createStatementSet api to support accept DML statements and Tables. The planner can optimize all added statements and

[GitHub] [flink] openinx commented on a change in pull request #12004: [FLINK-17434][core][hive] Hive partitioned source support streaming read

2020-05-08 Thread GitBox
openinx commented on a change in pull request #12004: URL: https://github.com/apache/flink/pull/12004#discussion_r422124325 ## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java ## @@ -181,6 +214,47 @@ public

[jira] [Commented] (FLINK-17506) SavepointEnvironment does not honour 'io.tmp.dirs' property

2020-05-08 Thread David Artiga (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102588#comment-17102588 ] David Artiga commented on FLINK-17506: -- Yes, you are right. Had to override {{java.io.tmpdir}} and

[GitHub] [flink] leonardBang commented on pull request #12010: [FLINK-17286][connectors / filesystem]Integrate json to file system connector

2020-05-08 Thread GitBox
leonardBang commented on pull request #12010: URL: https://github.com/apache/flink/pull/12010#issuecomment-625823031 Hi, @JingsongLi , I addressed your comments. Could you kindly have a look more? This is an automated

[GitHub] [flink] KurtYoung commented on a change in pull request #12042: [FLINK-16367] [table] Introduce TableEnvironment#createStatementSet api

2020-05-08 Thread GitBox
KurtYoung commented on a change in pull request #12042: URL: https://github.com/apache/flink/pull/12042#discussion_r422157743 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java ## @@ -654,13 +655,39 @@

[GitHub] [flink] leonardBang commented on pull request #12036: [FLINK-17537][connectors / jdbc] Refactor flink-jdbc connector structure

2020-05-08 Thread GitBox
leonardBang commented on pull request #12036: URL: https://github.com/apache/flink/pull/12036#issuecomment-625830095 Thanks @faisalmoeen and @wuchong ‘s notes and comments. I'll update the PR soon. Hi, @fpompermaier For your first note about StreamITCase.clear() I‘ll skip too because

[jira] [Created] (FLINK-17579) Set the resource id of taskexecutor from environment variable if possible in standalone mode

2020-05-08 Thread Yangze Guo (Jira)
Yangze Guo created FLINK-17579: -- Summary: Set the resource id of taskexecutor from environment variable if possible in standalone mode Key: FLINK-17579 URL: https://issues.apache.org/jira/browse/FLINK-17579

[GitHub] [flink] fpompermaier commented on a change in pull request #12036: [FLINK-17537][connectors / jdbc] Refactor flink-jdbc connector structure

2020-05-08 Thread GitBox
fpompermaier commented on a change in pull request #12036: URL: https://github.com/apache/flink/pull/12036#discussion_r422124179 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialects.java ## @@ -39,27 +39,27 @@

[jira] [Updated] (FLINK-17579) Set the resource id of taskexecutor according to environment variable if exist in standalone mode

2020-05-08 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo updated FLINK-17579: --- Summary: Set the resource id of taskexecutor according to environment variable if exist in

[jira] [Updated] (FLINK-17579) Set the resource id of taskexecutor according to environment variable if possible in standalone mode

2020-05-08 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo updated FLINK-17579: --- Summary: Set the resource id of taskexecutor according to environment variable if possible in

[jira] [Commented] (FLINK-17527) kubernetes-session.sh uses log4j-console.properties

2020-05-08 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102558#comment-17102558 ] Yang Wang commented on FLINK-17527: --- Yes, we could start with renaming

[jira] [Closed] (FLINK-17267) supports EXPLAIN statement in TableEnvironment#executeSql and Table#explain api

2020-05-08 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-17267. -- Assignee: godfrey he Resolution: Fixed master: 59ca355f05b668f1cb41cae02ce182ccc7c4d707 ~ 

[GitHub] [flink] Jiayi-Liao commented on a change in pull request #10068: [FLINK-13702][FLINK-13740] Fixed issues with generic types and materialization of lazy binary formats in blink planner

2020-05-08 Thread GitBox
Jiayi-Liao commented on a change in pull request #10068: URL: https://github.com/apache/flink/pull/10068#discussion_r422127101 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/typeutils/BinaryGenericSerializer.java ## @@ -127,63

[jira] [Commented] (FLINK-17579) Set the resource id of taskexecutor according to environment variable if exist in standalone mode

2020-05-08 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102561#comment-17102561 ] Yang Wang commented on FLINK-17579: --- It will be a very useful feature when deploying Flink standalone

[jira] [Updated] (FLINK-17506) SavepointEnvironment does not honour 'io.tmp.dirs' property

2020-05-08 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman updated FLINK-17506: - Affects Version/s: 1.10.2 1.11.0 > SavepointEnvironment does not honour

[jira] [Commented] (FLINK-17506) SavepointEnvironment does not honour 'io.tmp.dirs' property

2020-05-08 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102575#comment-17102575 ] Seth Wiesman commented on FLINK-17506: -- Unfortunately, that isn't quite correct. The configuration

[GitHub] [flink] flinkbot commented on pull request #12042: [FLINK-16367] [table] Introduce TableEnvironment#createStatementSet api

2020-05-08 Thread GitBox
flinkbot commented on pull request #12042: URL: https://github.com/apache/flink/pull/12042#issuecomment-625811143 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] Myasuka commented on a change in pull request #12033: [FLINK-17015]Fix NPE from NullAwareMapIterator

2020-05-08 Thread GitBox
Myasuka commented on a change in pull request #12033: URL: https://github.com/apache/flink/pull/12033#discussion_r422154704 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapMapState.java ## @@ -158,7 +159,7 @@ public boolean contains(UK

[GitHub] [flink] wuchong commented on pull request #11985: [FLINK-16989][table] Support ScanTableSource in blink planner

2020-05-08 Thread GitBox
wuchong commented on pull request #11985: URL: https://github.com/apache/flink/pull/11985#issuecomment-625842475 Azure build is passed in my private pipeline: https://dev.azure.com/imjark/Flink/_build/results?buildId=58=results Merging...

[jira] [Updated] (FLINK-17579) Set the resource id of taskexecutor according to environment variable if exist in standalone mode

2020-05-08 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo updated FLINK-17579: --- Description: Allow user to specify the resource id of TaskExecutor through the environment variable

[GitHub] [flink] sjwiesman opened a new pull request #12041: Spe

2020-05-08 Thread GitBox
sjwiesman opened a new pull request #12041: URL: https://github.com/apache/flink/pull/12041 ## What is the purpose of the change Pass undelrying configuration option to SavepointEnvironment to configure IOManager. ## Verifying this change This change is a trivial

[GitHub] [flink] leonardBang commented on a change in pull request #12010: [FLINK-17286][connectors / filesystem]Integrate json to file system connector

2020-05-08 Thread GitBox
leonardBang commented on a change in pull request #12010: URL: https://github.com/apache/flink/pull/12010#discussion_r422133975 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/PartitionPathUtils.java ## @@ -201,6 +210,50 @@ public

[GitHub] [flink] godfreyhe commented on pull request #12042: [FLINK-16367] [table] Introduce TableEnvironment#createStatementSet api

2020-05-08 Thread GitBox
godfreyhe commented on pull request #12042: URL: https://github.com/apache/flink/pull/12042#issuecomment-625811701 @dianfu @hequn8128 could you take a look at python part ? This is an automated message from the Apache Git

[GitHub] [flink] Myasuka commented on a change in pull request #12033: [FLINK-17015]Fix NPE from NullAwareMapIterator

2020-05-08 Thread GitBox
Myasuka commented on a change in pull request #12033: URL: https://github.com/apache/flink/pull/12033#discussion_r422155461 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapMapState.java ## @@ -158,7 +159,7 @@ public boolean contains(UK

[GitHub] [flink] wangyang0918 commented on pull request #12003: [FLINK-10934] Support application mode for kubernetes

2020-05-08 Thread GitBox
wangyang0918 commented on pull request #12003: URL: https://github.com/apache/flink/pull/12003#issuecomment-625657285 @zhengcanbin Sounds great. Let's move the discussion there. This is an automated message from the Apache

[GitHub] [flink] flinkbot edited a comment on pull request #11752: [FLINK-14713][rest]Show All Attempts For Vertex SubTask In Rest Api

2020-05-08 Thread GitBox
flinkbot edited a comment on pull request #11752: URL: https://github.com/apache/flink/pull/11752#issuecomment-613965719 ## CI report: * abbd96a3ab0c75a09234ea792f5b9cf45df96e5e Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/164608033) Azure:

[GitHub] [flink] flinkbot commented on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…

2020-05-08 Thread GitBox
flinkbot commented on pull request #12029: URL: https://github.com/apache/flink/pull/12029#issuecomment-625668720 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot edited a comment on pull request #12029: [FLINK-17451][sql-parser][table-planner-blink][hive] Implement view D…

2020-05-08 Thread GitBox
flinkbot edited a comment on pull request #12029: URL: https://github.com/apache/flink/pull/12029#issuecomment-625673739 ## CI report: * f6933a873ba179bc9dba26843a44c2bc72f1d95f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11985: [FLINK-16989][table] Support ScanTableSource in blink planner

2020-05-08 Thread GitBox
flinkbot edited a comment on pull request #11985: URL: https://github.com/apache/flink/pull/11985#issuecomment-623545781 ## CI report: * be8f4d8caa346a125f6c75e241370e449040ffe9 Azure:

[GitHub] [flink] flinkbot commented on pull request #12030: [FLINK-17567][python][release] Create a dedicated Python directory in release directory to place Python-related source and binary packages

2020-05-08 Thread GitBox
flinkbot commented on pull request #12030: URL: https://github.com/apache/flink/pull/12030#issuecomment-625680852 ## CI report: * 0ff8103e8393a7e7056f0a289366a7e13b59a818 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] RocMarshal commented on a change in pull request #11979: [FLINK-17291][docs] Translate 'docs/training/event_driven.zh.md' to C…

2020-05-08 Thread GitBox
RocMarshal commented on a change in pull request #11979: URL: https://github.com/apache/flink/pull/11979#discussion_r422002930 ## File path: docs/training/event_driven.zh.md ## @@ -269,38 +259,35 @@ SingleOutputStreamOperator hourlyTips = fares

[GitHub] [flink] flinkbot edited a comment on pull request #11979: [FLINK-17291][docs] Translate 'docs/training/event_driven.zh.md' to C…

2020-05-08 Thread GitBox
flinkbot edited a comment on pull request #11979: URL: https://github.com/apache/flink/pull/11979#issuecomment-623137252 ## CI report: * 51f00c041b126b54616f191f669750e819c733db Azure:

[jira] [Created] (FLINK-17571) A better way to show the files used in currently checkpoints

2020-05-08 Thread Congxian Qiu(klion26) (Jira)
Congxian Qiu(klion26) created FLINK-17571: - Summary: A better way to show the files used in currently checkpoints Key: FLINK-17571 URL: https://issues.apache.org/jira/browse/FLINK-17571

[jira] [Assigned] (FLINK-17568) Task may consume data after checkpoint barrier before performing checkpoint for unaligned checkpoint

2020-05-08 Thread Zhijiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhijiang reassigned FLINK-17568: Assignee: Yingjie Cao > Task may consume data after checkpoint barrier before performing

[GitHub] [flink] RocMarshal commented on a change in pull request #11979: [FLINK-17291][docs] Translate 'docs/training/event_driven.zh.md' to C…

2020-05-08 Thread GitBox
RocMarshal commented on a change in pull request #11979: URL: https://github.com/apache/flink/pull/11979#discussion_r422005955 ## File path: docs/training/event_driven.zh.md ## @@ -202,52 +196,48 @@ public void onTimer( } {% endhighlight %} -Observations: +观察: -* The

[GitHub] [flink] danny0405 commented on a change in pull request #11985: [FLINK-16989][table] Support ScanTableSource in blink planner

2020-05-08 Thread GitBox
danny0405 commented on a change in pull request #11985: URL: https://github.com/apache/flink/pull/11985#discussion_r422006300 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/FlinkCalciteCatalogReader.java ## @@ -188,11

[jira] [Updated] (FLINK-17571) A better way to show the files used in currently checkpoints

2020-05-08 Thread Congxian Qiu(klion26) (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Congxian Qiu(klion26) updated FLINK-17571: -- Description: Inspired by the [[user

[GitHub] [flink] flinkbot edited a comment on pull request #11979: [FLINK-17291][docs] Translate 'docs/training/event_driven.zh.md' to C…

2020-05-08 Thread GitBox
flinkbot edited a comment on pull request #11979: URL: https://github.com/apache/flink/pull/11979#issuecomment-623137252 ## CI report: * 51f00c041b126b54616f191f669750e819c733db Azure:

[jira] [Updated] (FLINK-17570) BatchTableEnvironment#fromValues(Object... values) throws StackOverflowError

2020-05-08 Thread Wei Zhong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zhong updated FLINK-17570: -- Summary: BatchTableEnvironment#fromValues(Object... values) throws StackOverflowError (was:

[GitHub] [flink] flinkbot edited a comment on pull request #11687: [FLINK-16536][network][checkpointing] Implement InputChannel state recovery for unaligned checkpoint

2020-05-08 Thread GitBox
flinkbot edited a comment on pull request #11687: URL: https://github.com/apache/flink/pull/11687#issuecomment-611445542 ## CI report: * 5bad018f00f85a7359345187a12d7938aa510d25 UNKNOWN * d51ce7f47381d99b843278cd701dcff223761a0b UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #11950: [FLINK-17030] Add primary key syntax to DDL

2020-05-08 Thread GitBox
flinkbot edited a comment on pull request #11950: URL: https://github.com/apache/flink/pull/11950#issuecomment-621585318 ## CI report: * 3c28fb79878dfbbf4ed1c0aa21794793b76c3de5 Azure:

[jira] [Commented] (FLINK-17566) Fix potential K8s resources leak after JobManager finishes in Applicaion mode

2020-05-08 Thread Canbin Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102365#comment-17102365 ] Canbin Zheng commented on FLINK-17566: -- Not exactly. Version 4.5.2 doesn't send one API request

[GitHub] [flink] flinkbot edited a comment on pull request #11687: [FLINK-16536][network][checkpointing] Implement InputChannel state recovery for unaligned checkpoint

2020-05-08 Thread GitBox
flinkbot edited a comment on pull request #11687: URL: https://github.com/apache/flink/pull/11687#issuecomment-611445542 ## CI report: * 5bad018f00f85a7359345187a12d7938aa510d25 UNKNOWN * d51ce7f47381d99b843278cd701dcff223761a0b UNKNOWN *

[GitHub] [flink] JingsongLi commented on a change in pull request #12010: [FLINK-17286][connectors / filesystem]Integrate json to file system connector

2020-05-08 Thread GitBox
JingsongLi commented on a change in pull request #12010: URL: https://github.com/apache/flink/pull/12010#discussion_r422024809 ## File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonFileSystemFormatFactory.java ## @@ -0,0 +1,293 @@ +/* + *

[GitHub] [flink] flinkbot edited a comment on pull request #12003: [FLINK-10934] Support application mode for kubernetes

2020-05-08 Thread GitBox
flinkbot edited a comment on pull request #12003: URL: https://github.com/apache/flink/pull/12003#issuecomment-624416714 ## CI report: * 42d28bc43d900c8f13a6cdee75146739cebd3260 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12031: [FLINK-17017] Implement Bulk Slot Allocation

2020-05-08 Thread GitBox
flinkbot edited a comment on pull request #12031: URL: https://github.com/apache/flink/pull/12031#issuecomment-625706903 ## CI report: * 490fe2228a370527cc3db5431c8b066854a69ae8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11985: [FLINK-16989][table] Support ScanTableSource in blink planner

2020-05-08 Thread GitBox
flinkbot edited a comment on pull request #11985: URL: https://github.com/apache/flink/pull/11985#issuecomment-623545781 ## CI report: * be8f4d8caa346a125f6c75e241370e449040ffe9 Azure:

[jira] [Commented] (FLINK-17468) Provide more detailed metrics why asynchronous part of checkpoint is taking long time

2020-05-08 Thread Congxian Qiu(klion26) (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102397#comment-17102397 ] Congxian Qiu(klion26) commented on FLINK-17468: --- Hi [~qqibrow] from your previous reply,

[jira] [Updated] (FLINK-17570) BatchTableEnvironment#fromValues(Object... values) throws StackOverflowError

2020-05-08 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-17570: - Fix Version/s: 1.11.0 > BatchTableEnvironment#fromValues(Object... values) throws

[jira] [Updated] (FLINK-17570) BatchTableEnvironment#fromValues(Object... values) throws StackOverflowError

2020-05-08 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-17570: - Affects Version/s: 1.11.0 > BatchTableEnvironment#fromValues(Object... values) throws

[GitHub] [flink] flinkbot commented on pull request #12032: [FLINK-17570] Fix recursive call in BatchTableEnvironment#fromValues

2020-05-08 Thread GitBox
flinkbot commented on pull request #12032: URL: https://github.com/apache/flink/pull/12032#issuecomment-625730633 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] RocMarshal commented on a change in pull request #11979: [FLINK-17291][docs] Translate 'docs/training/event_driven.zh.md' to C…

2020-05-08 Thread GitBox
RocMarshal commented on a change in pull request #11979: URL: https://github.com/apache/flink/pull/11979#discussion_r422055502 ## File path: docs/training/event_driven.zh.md ## @@ -106,21 +104,20 @@ public static class PseudoWindow extends } {% endhighlight %} -Things to

[GitHub] [flink] leonardBang commented on a change in pull request #12010: [FLINK-17286][connectors / filesystem]Integrate json to file system connector

2020-05-08 Thread GitBox
leonardBang commented on a change in pull request #12010: URL: https://github.com/apache/flink/pull/12010#discussion_r422122393 ## File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonFileSystemFormatFactory.java ## @@ -0,0 +1,293 @@ +/* + *

[GitHub] [flink] pnowojski commented on a change in pull request #11687: [FLINK-16536][network][checkpointing] Implement InputChannel state recovery for unaligned checkpoint

2020-05-08 Thread GitBox
pnowojski commented on a change in pull request #11687: URL: https://github.com/apache/flink/pull/11687#discussion_r422058882 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RecoveredInputChannel.java ## @@ -177,17 +178,18 @@

[GitHub] [flink] flinkbot edited a comment on pull request #11920: [FLINK-17408] Introduce GPUDriver and discovery script

2020-05-08 Thread GitBox
flinkbot edited a comment on pull request #11920: URL: https://github.com/apache/flink/pull/11920#issuecomment-619909940 ## CI report: * 1d4794e9372856fd254b6aa958e9c5c340e9885b Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11985: [FLINK-16989][table] Support ScanTableSource in blink planner

2020-05-08 Thread GitBox
flinkbot edited a comment on pull request #11985: URL: https://github.com/apache/flink/pull/11985#issuecomment-623545781 ## CI report: * 44a5d8792e56e1e0676c76ff270720caf36558c1 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11950: [FLINK-17030] Add primary key syntax to DDL

2020-05-08 Thread GitBox
flinkbot edited a comment on pull request #11950: URL: https://github.com/apache/flink/pull/11950#issuecomment-621585318 ## CI report: * 45c8a9923caf06854cc7f3a7538103cab6a85152 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11892: [FLINK-17112][table] Support DESCRIBE statement in Flink SQL

2020-05-08 Thread GitBox
flinkbot edited a comment on pull request #11892: URL: https://github.com/apache/flink/pull/11892#issuecomment-618766534 ## CI report: * 196b7566be701c6c0759d08f76d7bec7148a47b3 UNKNOWN * d40ddaae8da56b1b9ebaab3693d8c04c6d6cbb43 Travis:

[GitHub] [flink] flinkbot commented on pull request #12036: [FLINK-17537][connectors / jdbc] Refactor flink-jdbc connector structure

2020-05-08 Thread GitBox
flinkbot commented on pull request #12036: URL: https://github.com/apache/flink/pull/12036#issuecomment-625745888 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Commented] (FLINK-17357) add "DROP catalog" DDL to blink planner

2020-05-08 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102457#comment-17102457 ] Nicholas Jiang commented on FLINK-17357: [~lzljs3620320]Could you please assign this issue to

[GitHub] [flink] TsReaper opened a new pull request #12037: [FLINK-14807][runtime][client] Introduce communication through REST API between the clients and the operator coordinators

2020-05-08 Thread GitBox
TsReaper opened a new pull request #12037: URL: https://github.com/apache/flink/pull/12037 ## What is the purpose of the change This PR is part of the [FLINK-14807](https://issues.apache.org/jira/browse/FLINK-14807) which is going to introduce a collecting method for tables. See

[jira] [Updated] (FLINK-14807) Add Table#collect api for fetching data to client

2020-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-14807: --- Labels: pull-request-available usability (was: usability) > Add Table#collect api for

[GitHub] [flink] jinglining commented on pull request #11752: [FLINK-14713][rest]Show All Attempts For Vertex SubTask In Rest Api

2020-05-08 Thread GitBox
jinglining commented on pull request #11752: URL: https://github.com/apache/flink/pull/11752#issuecomment-625765574 @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (FLINK-17571) A better way to show the files used in currently checkpoints

2020-05-08 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102482#comment-17102482 ] Piotr Nowojski commented on FLINK-17571: Do you mean that: {noformat} ./bin/flink checkpoint

[jira] [Updated] (FLINK-17577) SinkFormat#createSinkFormat should use DynamicTableSink.Context as the first parameter

2020-05-08 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chen updated FLINK-17577: --- Priority: Critical (was: Major) > SinkFormat#createSinkFormat should use DynamicTableSink.Context

[jira] [Commented] (FLINK-14101) Introduce SqlServerDialect

2020-05-08 Thread Canbin Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102484#comment-17102484 ] Canbin Zheng commented on FLINK-14101: -- [~f.pompermaier] Go ahead! > Introduce SqlServerDialect >

[jira] [Created] (FLINK-17577) SinkFormat#createSinkFormat should use DynamicTableSink.Context as the first parameter

2020-05-08 Thread Danny Chen (Jira)
Danny Chen created FLINK-17577: -- Summary: SinkFormat#createSinkFormat should use DynamicTableSink.Context as the first parameter Key: FLINK-17577 URL: https://issues.apache.org/jira/browse/FLINK-17577

[GitHub] [flink] danny0405 commented on pull request #12039: [FLINK-17577] SinkFormat#createSinkFormat should use DynamicTableSink…

2020-05-08 Thread GitBox
danny0405 commented on pull request #12039: URL: https://github.com/apache/flink/pull/12039#issuecomment-625772112 @twalthr Can you take a look ? This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (FLINK-14146) Introduce Pulsar connector

2020-05-08 Thread Canbin Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102517#comment-17102517 ] Canbin Zheng commented on FLINK-14146: -- +1, looking forward to faster progress of this feature. >

[GitHub] [flink] pnowojski commented on a change in pull request #11687: [FLINK-16536][network][checkpointing] Implement InputChannel state recovery for unaligned checkpoint

2020-05-08 Thread GitBox
pnowojski commented on a change in pull request #11687: URL: https://github.com/apache/flink/pull/11687#discussion_r422058882 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RecoveredInputChannel.java ## @@ -177,17 +178,18 @@

[GitHub] [flink] flinkbot commented on pull request #12034: [FLINK-17568][checkpointing] Fix the issue that task may consume input data after checkpoint barrier before checkpoint is performed for unal

2020-05-08 Thread GitBox
flinkbot commented on pull request #12034: URL: https://github.com/apache/flink/pull/12034#issuecomment-625744490 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] wxplovecc opened a new pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem

2020-05-08 Thread GitBox
wxplovecc opened a new pull request #12035: URL: https://github.com/apache/flink/pull/12035 What is the purpose of the change This pull request makes `HadoopRecoverableFsDataOutputStream#revokeLeaseByFileSystem` support `ViewFileSystem` when using viewfs the

[jira] [Updated] (FLINK-17569) to support ViewFileSystem when wait lease revoke of hadoop filesystem

2020-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-17569: --- Labels: pull-request-available (was: ) > to support ViewFileSystem when wait lease revoke

[GitHub] [flink] flinkbot commented on pull request #12032: [FLINK-17570] Fix recursive call in BatchTableEnvironment#fromValues

2020-05-08 Thread GitBox
flinkbot commented on pull request #12032: URL: https://github.com/apache/flink/pull/12032#issuecomment-625746734 ## CI report: * edd5c277f04e481d29db52167170a26bf71eb499 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #12003: [FLINK-10934] Support application mode for kubernetes

2020-05-08 Thread GitBox
flinkbot edited a comment on pull request #12003: URL: https://github.com/apache/flink/pull/12003#issuecomment-624416714 ## CI report: * 4488730c9004250063a6d26ae980ad8816a62999 Azure:

[GitHub] [flink] flinkbot commented on pull request #12037: [FLINK-14807][runtime][client] Introduce communication through REST API between the clients and the operator coordinators

2020-05-08 Thread GitBox
flinkbot commented on pull request #12037: URL: https://github.com/apache/flink/pull/12037#issuecomment-625766815 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] fpompermaier opened a new pull request #12038: [FLINK-14101][jdbc] Added MS SQL-server dialect

2020-05-08 Thread GitBox
fpompermaier opened a new pull request #12038: URL: https://github.com/apache/flink/pull/12038 ## What is the purpose of the change Add the implementation of the MS SQL-server dialect for JDBC connectors ## Brief change log - Implemented MsSqlServerDialect

  1   2   3   4   5   6   >