Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2024-01-03 Thread via GitHub
grzegorz8 commented on code in PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1440284283 ## flink-connector-jdbc/pom.xml: ## @@ -38,10 +38,12 @@ under the License. 2.12 2.12.7 3.23.1 +

Re: [PR] [FLINK-33964][pulsar][docs] Remove dead link [flink-connector-pulsar]

2024-01-03 Thread via GitHub
GOODBOY008 commented on PR #77: URL: https://github.com/apache/flink-connector-pulsar/pull/77#issuecomment-1875183000 @leonardBang PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-33814][autoscaler] Autoscaler Standalone control loop supports multiple threads [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
1996fanrui commented on code in PR #744: URL: https://github.com/apache/flink-kubernetes-operator/pull/744#discussion_r1440326118 ## flink-autoscaler/src/test/java/org/apache/flink/autoscaler/event/TestingEventCollector.java: ## @@ -42,7 +42,7 @@ public class

Re: [PR] [FLINK-32570][runtime][stream] Deprecates @Public/@PublicEvolving API that uses Flink's Time classes [flink]

2024-01-03 Thread via GitHub
1996fanrui commented on code in PR #22984: URL: https://github.com/apache/flink/pull/22984#discussion_r1440283481 ## flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java: ## @@ -53,13 +54,14 @@ public class StateTtlConfig implements Serializable {

Re: [PR] [FLINK-33814][autoscaler] Autoscaler Standalone control loop supports multiple threads [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
mxm commented on code in PR #744: URL: https://github.com/apache/flink-kubernetes-operator/pull/744#discussion_r1440293457 ## flink-autoscaler/src/test/java/org/apache/flink/autoscaler/event/TestingEventCollector.java: ## @@ -42,7 +42,7 @@ public class TestingEventCollector>

Re: [PR] [FLINK-33966] Fix the getNumRecordsInPerSecond Utility Function [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
Yang-LI-CS commented on code in PR #743: URL: https://github.com/apache/flink-kubernetes-operator/pull/743#discussion_r1440183532 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java: ## @@ -221,7 +221,7 @@ private static double

[jira] [Commented] (FLINK-32241) UnsupportedFileSystemException when using the ABFS Hadoop driver for checkpointing in Flink 1.17

2024-01-03 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802077#comment-17802077 ] Martijn Visser commented on FLINK-32241: [~luoyuxia] Have you looked more into this topic? >

[jira] [Updated] (FLINK-32570) Deprecate API that uses Flink's Time implementation (related to FLINK-14638)

2024-01-03 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-32570: Parent: FLINK-3957 Issue Type: Sub-task (was: Technical Debt) > Deprecate API that uses Flink's

Re: [PR] [FLINK-33964][pulsar][docs] Remove dead link [flink-connector-pulsar]

2024-01-03 Thread via GitHub
GOODBOY008 commented on PR #77: URL: https://github.com/apache/flink-connector-pulsar/pull/77#issuecomment-1875070692 @tisonkun PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [BP][FLINK-33964][pulsar][docs] Remove dead link [flink-connector-pulsar]

2024-01-03 Thread via GitHub
GOODBOY008 commented on PR #79: URL: https://github.com/apache/flink-connector-pulsar/pull/79#issuecomment-1875094367 @tisonkun PTAL, Backport to v4.1 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-03 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1440284858 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,28 +97,115 @@ public

Re: [PR] [FLINK-33966] Fix the getNumRecordsInPerSecond Utility Function [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
1996fanrui commented on code in PR #743: URL: https://github.com/apache/flink-kubernetes-operator/pull/743#discussion_r1440182777 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java: ## @@ -217,14 +217,13 @@ private static double

Re: [PR] [FLINK-33966] Fix the getNumRecordsInPerSecond Utility Function [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
Yang-LI-CS commented on code in PR #743: URL: https://github.com/apache/flink-kubernetes-operator/pull/743#discussion_r1440186827 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java: ## @@ -221,7 +221,7 @@ private static double

Re: [PR] [FLINK-33966] Fix the getNumRecordsInPerSecond Utility Function [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
Yang-LI-CS commented on code in PR #743: URL: https://github.com/apache/flink-kubernetes-operator/pull/743#discussion_r1440186563 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java: ## @@ -217,14 +217,13 @@ private static double

Re: [PR] [FLINK-33966] Fix the getNumRecordsInPerSecond Utility Function [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
1996fanrui commented on code in PR #743: URL: https://github.com/apache/flink-kubernetes-operator/pull/743#discussion_r1440197015 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java: ## @@ -216,15 +216,20 @@ private static double

[jira] [Commented] (FLINK-33940) Update the auto-derivation rule of max parallelism for enlarged upscaling space

2024-01-03 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802080#comment-17802080 ] Zhanghao Chen commented on FLINK-33940: --- Thanks for the input, [~fanrui]. I'll take a look on the

Re: [PR] [FLINK-33964][pulsar][docs] Remove dead link [flink-connector-pulsar]

2024-01-03 Thread via GitHub
boring-cyborg[bot] commented on PR #77: URL: https://github.com/apache/flink-connector-pulsar/pull/77#issuecomment-1875069060 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[jira] [Commented] (FLINK-33446) SubQueryAntiJoinTest#testMultiNotExistsWithCorrelatedOnWhere_NestedCorrelation doesn't produce the correct plan

2024-01-03 Thread Jeyhun Karimov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802090#comment-17802090 ] Jeyhun Karimov commented on FLINK-33446: Hi [~fsk119] I scanned through the issue a bit. I can

Re: [PR] [FLINK-33964][pulsar][docs] Remove dead link [flink-connector-pulsar]

2024-01-03 Thread via GitHub
GOODBOY008 commented on PR #77: URL: https://github.com/apache/flink-connector-pulsar/pull/77#issuecomment-1875081879 > Thank you! I'd appreciated it if you can backport to v4.1 branch also. @tisonkun Big thanks for your quick review. I want to add document check for connector

Re: [PR] [FLINK-33814][autoscaler] Autoscaler Standalone control loop supports multiple threads [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
mxm commented on code in PR #744: URL: https://github.com/apache/flink-kubernetes-operator/pull/744#discussion_r1440340673 ## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/StandaloneAutoscalerExecutor.java: ## @@ -48,22 +59,34 @@ public class

Re: [PR] [FLINK-33966] Fix the getNumRecordsInPerSecond Utility Function [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
Yang-LI-CS commented on code in PR #743: URL: https://github.com/apache/flink-kubernetes-operator/pull/743#discussion_r1440178966 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java: ## @@ -221,7 +221,7 @@ private static double

[jira] [Commented] (FLINK-33966) Fix the getNumRecordsInPerSecond Utility Function

2024-01-03 Thread Yang LI (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802057#comment-17802057 ] Yang LI commented on FLINK-33966: - Thanks to the clarification from [~fanrui] , now I think it's not a

Re: [PR] [FLINK-33966] Fix the getNumRecordsInPerSecond Utility Function [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
Yang-LI-CS commented on code in PR #743: URL: https://github.com/apache/flink-kubernetes-operator/pull/743#discussion_r1440202523 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java: ## @@ -216,15 +216,20 @@ private static double

[jira] [Updated] (FLINK-33970) Add necessary checks for connector document

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33970: --- Labels: pull-request-available (was: ) > Add necessary checks for connector document >

Re: [PR] [FLINK-33970] Add necessary checks for connector document [flink-connector-pulsar]

2024-01-03 Thread via GitHub
GOODBOY008 commented on PR #78: URL: https://github.com/apache/flink-connector-pulsar/pull/78#issuecomment-1875077994 @leonardBang @tisonkun PTAL. Currently, I just add simple scripts to check dead link instead of use hugo to build doc. -- This is an automated message from the Apache

Re: [PR] [FLINK-33966] Fix the getNumRecordsInPerSecond Utility Function [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
mxm commented on code in PR #743: URL: https://github.com/apache/flink-kubernetes-operator/pull/743#discussion_r1440322610 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java: ## @@ -216,15 +216,21 @@ private static double

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-03 Thread via GitHub
eskabetxe commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1440197286 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSourceBuilder.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-03 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1440284858 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,28 +97,115 @@ public

[jira] [Updated] (FLINK-33697) FLIP-386: Support adding custom metrics in Recovery Spans

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33697: --- Labels: pull-request-available (was: ) > FLIP-386: Support adding custom metrics in

Re: [PR] [FLINK-33970] Add necessary checks for connector document [flink-connector-pulsar]

2024-01-03 Thread via GitHub
tisonkun merged PR #78: URL: https://github.com/apache/flink-connector-pulsar/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-33973) Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33973: --- Labels: pull-request-available (was: ) > Add new interfaces for SinkV2 to synchronize the

Re: [PR] [FLINK-33973] Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API [flink]

2024-01-03 Thread via GitHub
flinkbot commented on PR #24022: URL: https://github.com/apache/flink/pull/24022#issuecomment-1875319278 ## CI report: * 922c6c60c3b8d66f925d9bc84855b4beaaa90359 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [docs] Typo: add missing word "start" [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
mxm commented on PR #745: URL: https://github.com/apache/flink-kubernetes-operator/pull/745#issuecomment-1875460950 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [docs] Typo: add missing word "start" [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
mxm merged PR #745: URL: https://github.com/apache/flink-kubernetes-operator/pull/745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33775] Report JobInitialization traces [flink]

2024-01-03 Thread via GitHub
StefanRRichter commented on code in PR #23908: URL: https://github.com/apache/flink/pull/23908#discussion_r1440576635 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java: ## @@ -155,7 +167,12 @@ public CheckpointStatsSnapshot

Re: [PR] [FLINK-33970] Add necessary checks for connector document [flink-connector-pulsar]

2024-01-03 Thread via GitHub
tisonkun commented on PR #78: URL: https://github.com/apache/flink-connector-pulsar/pull/78#issuecomment-1875647916 Now we can pick this patch to v4.1 >_< -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-33964][pulsar][docs] Remove dead link [flink-connector-pulsar]

2024-01-03 Thread via GitHub
tisonkun merged PR #77: URL: https://github.com/apache/flink-connector-pulsar/pull/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-33446) SubQueryAntiJoinTest#testMultiNotExistsWithCorrelatedOnWhere_NestedCorrelation doesn't produce the correct plan

2024-01-03 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802129#comment-17802129 ] Shengkai Fang commented on FLINK-33446: --- ?? {{Sql2RelConverter}} generates the correct plan?? Yes

[jira] [Created] (FLINK-33973) Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API

2024-01-03 Thread Peter Vary (Jira)
Peter Vary created FLINK-33973: -- Summary: Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API Key: FLINK-33973 URL: https://issues.apache.org/jira/browse/FLINK-33973 Project:

Re: [PR] [FLINK-25421] Add JdbcSink with new format [flink-connector-jdbc]

2024-01-03 Thread via GitHub
MartijnVisser commented on PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#issuecomment-1875367844 @wanglijie95 Do you have bandwidth to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-33976] AdaptiveScheduler cooldown period should be taken from JobManager's configuration [flink]

2024-01-03 Thread via GitHub
echauchot commented on PR #24021: URL: https://github.com/apache/flink/pull/24021#issuecomment-1875401922 Hi David, thanks for this PR, I'll take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-33814][autoscaler] Autoscaler Standalone control loop supports multiple threads [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
mxm commented on code in PR #744: URL: https://github.com/apache/flink-kubernetes-operator/pull/744#discussion_r1440505443 ## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/StandaloneAutoscalerExecutor.java: ## @@ -48,22 +59,34 @@ public class

Re: [PR] [FLINK-33697][state][metrics] Trace RocksDBIncremental remote files download time [flink]

2024-01-03 Thread via GitHub
flinkbot commented on PR #24023: URL: https://github.com/apache/flink/pull/24023#issuecomment-1875528953 ## CI report: * e7b15627f0fe1823eb893fff103e8c0f715bc223 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-20454][format][debezium] Allow to read metadata for debezium-avro-confluent format [flink]

2024-01-03 Thread via GitHub
MartijnVisser commented on PR #18744: URL: https://github.com/apache/flink/pull/18744#issuecomment-1875613760 If the PR gets rebased and the CI passes, someone could take a look most likely. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Updated] (FLINK-33970) Add necessary checks for connector document

2024-01-03 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen updated FLINK-33970: -- Fix Version/s: pulsar-4.2.0 pulsar-4.1.1 > Add necessary checks for connector

[jira] [Closed] (FLINK-33970) Add necessary checks for connector document

2024-01-03 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen closed FLINK-33970. - Resolution: Fixed master via 5b70da8f88e21057a5c590d139eab558f87e5dca Thanks a lot [~gongzhongqiang]!

Re: [PR] [BP][FLINK-33964][pulsar][docs] Remove dead link [flink-connector-pulsar]

2024-01-03 Thread via GitHub
tisonkun merged PR #79: URL: https://github.com/apache/flink-connector-pulsar/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [BP][FLINK-33964][pulsar][docs] Remove dead link [flink-connector-pulsar]

2024-01-03 Thread via GitHub
tisonkun commented on code in PR #79: URL: https://github.com/apache/flink-connector-pulsar/pull/79#discussion_r1440353899 ## .github/workflows/ci.yml: ## @@ -50,3 +50,13 @@ jobs: flink_version: ${{ matrix.flink }} timeout_global: 120 timeout_test: 80 +

[jira] [Created] (FLINK-33972) Enhance and synchronize Sink API to match the Source API

2024-01-03 Thread Peter Vary (Jira)
Peter Vary created FLINK-33972: -- Summary: Enhance and synchronize Sink API to match the Source API Key: FLINK-33972 URL: https://issues.apache.org/jira/browse/FLINK-33972 Project: Flink Issue

[jira] [Created] (FLINK-33976) AdaptiveScheduler cooldown period is taken from a wrong configuration

2024-01-03 Thread Jira
David Morávek created FLINK-33976: - Summary: AdaptiveScheduler cooldown period is taken from a wrong configuration Key: FLINK-33976 URL: https://issues.apache.org/jira/browse/FLINK-33976 Project:

[jira] [Assigned] (FLINK-33976) AdaptiveScheduler cooldown period is taken from a wrong configuration

2024-01-03 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-33976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Morávek reassigned FLINK-33976: - Assignee: David Morávek > AdaptiveScheduler cooldown period is taken from a wrong

Re: [PR] [FLINK-33976] AdaptiveScheduler cooldown period should be taken from JobManager's configuration [flink]

2024-01-03 Thread via GitHub
flinkbot commented on PR #24021: URL: https://github.com/apache/flink/pull/24021#issuecomment-1875300830 ## CI report: * 4cd91bc6028e0a5e78e4a7984201fa6eca84232f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [docs] Typo: add missing word "start" [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
gvauvert opened a new pull request, #745: URL: https://github.com/apache/flink-kubernetes-operator/pull/745 Typo: add missing word "start" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-33977) Adaptive scheduler may not minimize the number of TMs during downscaling

2024-01-03 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-33977: -- Component/s: Runtime / Coordination > Adaptive scheduler may not minimize the number of TMs

[PR] [FLINK-33697][state][metrics] Trace RocksDBIncremental remote files download time [flink]

2024-01-03 Thread via GitHub
pnowojski opened a new pull request, #24023: URL: https://github.com/apache/flink/pull/24023 This PR builds on top of https://github.com/apache/flink/pull/23908 ## Brief change log Please check individual commit messages ## Verifying this change This change has

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2024-01-03 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802136#comment-17802136 ] Shengkai Fang commented on FLINK-33490: --- Hi, [~martijnvisser]. I think this issue is just a bug

[jira] [Updated] (FLINK-33976) AdaptiveScheduler cooldown period is taken from a wrong configuration

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33976: --- Labels: pull-request-available (was: ) > AdaptiveScheduler cooldown period is taken from a

[PR] [FLINK-33973] Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API [flink]

2024-01-03 Thread via GitHub
pvary opened a new pull request, #24022: URL: https://github.com/apache/flink/pull/24022 ## What is the purpose of the change Add new SinkV2 API interfaces, set inheritance and deprecation for the old interfaces. ## Brief change log All the new API's defined in

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-03 Thread Jufang He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802147#comment-17802147 ] Jufang He commented on FLINK-33856: --- [~pnowojski] It seems reasonable to use TraceReporter to report

[jira] [Created] (FLINK-33977) Adaptive scheduler may not minimize the number of TMs during downscaling

2024-01-03 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-33977: - Summary: Adaptive scheduler may not minimize the number of TMs during downscaling Key: FLINK-33977 URL: https://issues.apache.org/jira/browse/FLINK-33977 Project:

Re: [PR] [FLINK-33966] Fix the getNumRecordsInPerSecond Utility Function [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
Yang-LI-CS commented on PR #743: URL: https://github.com/apache/flink-kubernetes-operator/pull/743#issuecomment-1875354667 > Looks good! I think this logic needs some comments because it is hard to understand the reasoning behind the logic. I added some additional suggestions.

Re: [PR] [BP][FLINK-33964][pulsar][docs] Remove dead link [flink-connector-pulsar]

2024-01-03 Thread via GitHub
GOODBOY008 commented on code in PR #79: URL: https://github.com/apache/flink-connector-pulsar/pull/79#discussion_r1440472270 ## .github/workflows/ci.yml: ## @@ -50,3 +50,13 @@ jobs: flink_version: ${{ matrix.flink }} timeout_global: 120 timeout_test: 80 +

Re: [PR] [FLINK-33966] Fix the getNumRecordsInPerSecond Utility Function [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
mxm commented on code in PR #743: URL: https://github.com/apache/flink-kubernetes-operator/pull/743#discussion_r1440519499 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java: ## @@ -216,15 +216,21 @@ private static double

[jira] [Created] (FLINK-33975) Tests for the new Sink V2 transformations

2024-01-03 Thread Peter Vary (Jira)
Peter Vary created FLINK-33975: -- Summary: Tests for the new Sink V2 transformations Key: FLINK-33975 URL: https://issues.apache.org/jira/browse/FLINK-33975 Project: Flink Issue Type: Sub-task

Re: [PR] [FLINK-33814][autoscaler] Autoscaler Standalone control loop supports multiple threads [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
1996fanrui commented on code in PR #744: URL: https://github.com/apache/flink-kubernetes-operator/pull/744#discussion_r1440384519 ## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/StandaloneAutoscalerExecutor.java: ## @@ -75,29 +98,38 @@

[jira] [Created] (FLINK-33974) Implement the Sink transformation depending on the new SinkV2 interfaces

2024-01-03 Thread Peter Vary (Jira)
Peter Vary created FLINK-33974: -- Summary: Implement the Sink transformation depending on the new SinkV2 interfaces Key: FLINK-33974 URL: https://issues.apache.org/jira/browse/FLINK-33974 Project: Flink

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2024-01-03 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802146#comment-17802146 ] Martijn Visser commented on FLINK-33490: [~fsk119] I'm not suggesting to have a FLIP for a

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core package api-common [flink]

2024-01-03 Thread via GitHub
GOODBOY008 commented on PR #23960: URL: https://github.com/apache/flink/pull/23960#issuecomment-1875416513 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core package api-common [flink]

2024-01-03 Thread via GitHub
GOODBOY008 commented on PR #23960: URL: https://github.com/apache/flink/pull/23960#issuecomment-1875472008 > https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=55925=logs=0da23115-68bb-5dcd-192c-bd4c8adebde1=24c3384f-1bcb-57b3-224f-51bf973bbee8=7264 > > The CI

Re: [PR] [FLINK-33970] Add necessary checks for connector document [flink-connector-pulsar]

2024-01-03 Thread via GitHub
tisonkun commented on PR #78: URL: https://github.com/apache/flink-connector-pulsar/pull/78#issuecomment-1875232119 CI broken. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33814][autoscaler] Autoscaler Standalone control loop supports multiple threads [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
1996fanrui commented on code in PR #744: URL: https://github.com/apache/flink-kubernetes-operator/pull/744#discussion_r1440355436 ## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/StandaloneAutoscalerExecutor.java: ## @@ -48,22 +59,34 @@

[jira] [Reopened] (FLINK-33490) Validate the name conflicts when creating view

2024-01-03 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reopened FLINK-33490: --- > Validate the name conflicts when creating view >

Re: [PR] [FLINK-33970] Add necessary checks for connector document [flink-connector-pulsar]

2024-01-03 Thread via GitHub
GOODBOY008 commented on PR #78: URL: https://github.com/apache/flink-connector-pulsar/pull/78#issuecomment-1875406878 > CI broken. PTAL. I had rebase to latest master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-33966] Fix the getNumRecordsInPerSecond Utility Function [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
Yang-LI-CS commented on code in PR #743: URL: https://github.com/apache/flink-kubernetes-operator/pull/743#discussion_r1440549106 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java: ## @@ -216,15 +216,21 @@ private static double

Re: [PR] [FLINK-33697][state][metrics] Trace RocksDBIncremental remote files download time [flink]

2024-01-03 Thread via GitHub
StefanRRichter commented on code in PR #24023: URL: https://github.com/apache/flink/pull/24023#discussion_r1440607428 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackendParametersImpl.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLIP 400] Introduces AsyncScalarFunction as a new UDF type [flink]

2024-01-03 Thread via GitHub
AlanConfluent commented on code in PR #23975: URL: https://github.com/apache/flink/pull/23975#discussion_r1440888375 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/AsyncCalcSyncModeRule.java: ## @@ -0,0 +1,146 @@ +/* + *

[PR] Lap 1 Training [flink-training]

2024-01-03 Thread via GitHub
ness-senthilRamamoorthy opened a new pull request, #71: URL: https://github.com/apache/flink-training/pull/71 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Comment Edited] (FLINK-32212) Job restarting indefinitely after an IllegalStateException from BlobLibraryCacheManager

2024-01-03 Thread Samuel Brotherton (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802295#comment-17802295 ] Samuel Brotherton edited comment on FLINK-32212 at 1/3/24 6:30 PM: --- We

Re: [PR] Lab 1 Training [flink-training]

2024-01-03 Thread via GitHub
ness-senthilRamamoorthy closed pull request #71: Lab 1 Training URL: https://github.com/apache/flink-training/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (FLINK-32212) Job restarting indefinitely after an IllegalStateException from BlobLibraryCacheManager

2024-01-03 Thread Samuel Brotherton (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802295#comment-17802295 ] Samuel Brotherton commented on FLINK-32212: --- We are seeing this issue as well; it breaks our

[jira] [Commented] (FLINK-33611) Support Large Protobuf Schemas

2024-01-03 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802335#comment-17802335 ] Sai Sharath Dandi commented on FLINK-33611: --- [~libenchao] All identifier names in the code are

[jira] [Comment Edited] (FLINK-33611) Support Large Protobuf Schemas

2024-01-03 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802335#comment-17802335 ] Sai Sharath Dandi edited comment on FLINK-33611 at 1/3/24 10:15 PM:

Re: [PR] [FLINK-33979] Implement restore tests for TableSink node [flink]

2024-01-03 Thread via GitHub
flinkbot commented on PR #24024: URL: https://github.com/apache/flink/pull/24024#issuecomment-1876189607 ## CI report: * 20da3f4a949949c419f4e8f989312c43172ef4c5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Resolved] (FLINK-33941) Use field reference index to compute window aggregate time attribute column

2024-01-03 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan resolved FLINK-33941. --- Resolution: Fixed > Use field reference index to compute window aggregate time attribute column >

[jira] [Closed] (FLINK-33941) Use field reference index to compute window aggregate time attribute column

2024-01-03 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan closed FLINK-33941. - > Use field reference index to compute window aggregate time attribute column >

[jira] [Updated] (FLINK-33939) Make husky in runtime-web no longer affect git global hooks

2024-01-03 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-33939: - Priority: Major (was: Minor) > Make husky in runtime-web no longer affect git global hooks >

[jira] [Updated] (FLINK-33939) Make husky in runtime-web no longer affect git global hooks

2024-01-03 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-33939: - Fix Version/s: 1.19.0 1.17.3 1.18.2 > Make husky in

[jira] [Created] (FLINK-33980) Reorganize job configuration

2024-01-03 Thread Junrui Li (Jira)
Junrui Li created FLINK-33980: - Summary: Reorganize job configuration Key: FLINK-33980 URL: https://issues.apache.org/jira/browse/FLINK-33980 Project: Flink Issue Type: Technical Debt

[PR] [FLINK-33980][core] Reorganize job configuration [flink]

2024-01-03 Thread via GitHub
JunRuiLee opened a new pull request, #24025: URL: https://github.com/apache/flink/pull/24025 ## What is the purpose of the change Reorganize job configuration ## Brief change log 1. Migrate configuration from non-ConfigOption objects to use ConfigOption. 2. Adopt

Re: [PR] [FLINK-33980][core] Reorganize job configuration [flink]

2024-01-03 Thread via GitHub
flinkbot commented on PR #24025: URL: https://github.com/apache/flink/pull/24025#issuecomment-187628 ## CI report: * 0d717f15ab0a48c816817eb0231b45378f00d8ec UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-03 Thread via GitHub
RocMarshal commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1441300360 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/reader/extractor/ResultExtractor.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-03 Thread via GitHub
RocMarshal commented on PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#issuecomment-1876318089 Hi, @eskabetxe Thank you very much for the review. And I left some discussion items for your comments. Please let me know what's your opinion~ :) -- This is an

[jira] [Updated] (FLINK-33971) Specifies whether to use HBase table that supports dynamic columns.

2024-01-03 Thread MOBIN (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] MOBIN updated FLINK-33971: -- Description: Specifies whether to use HBase table that supports dynamic columns. Refer to the dynamic.table

[jira] [Commented] (FLINK-33941) Use field reference index to compute window aggregate time attribute column

2024-01-03 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802374#comment-17802374 ] Jane Chan commented on FLINK-33941: --- Fixed in master: b957480112c00d9d777247fc48b602e9908652a2 > Use

[jira] [Updated] (FLINK-33941) Use field reference index to compute window aggregate time attribute column

2024-01-03 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-33941: -- Summary: Use field reference index to compute window aggregate time attribute column (was: Use field

[jira] [Updated] (FLINK-33939) Make husky in runtime-web no longer affect git global hooks

2024-01-03 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song updated FLINK-33939: - Affects Version/s: 1.9.0 > Make husky in runtime-web no longer affect git global hooks >

Re: [PR] Draft [flink]

2024-01-03 Thread via GitHub
JunRuiLee closed pull request #23993: Draft URL: https://github.com/apache/flink/pull/23993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-33980) Reorganize job configuration

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33980: --- Labels: pull-request-available (was: ) > Reorganize job configuration >

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2024-01-03 Thread via GitHub
RocMarshal commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1441298453 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33966] Fix the getNumRecordsInPerSecond Utility Function [flink-kubernetes-operator]

2024-01-03 Thread via GitHub
1996fanrui commented on code in PR #743: URL: https://github.com/apache/flink-kubernetes-operator/pull/743#discussion_r1441197747 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java: ## @@ -216,15 +216,23 @@ private static double

  1   2   >