[GitHub] flink pull request #2661: [FLINK-4283] ExecutionGraphRestartTest fails

GitHub user AlexanderShoshin opened a pull request: https://github.com/apache/flink/pull/2661 [FLINK-4283] ExecutionGraphRestartTest fails Tests were falling by timeout on less than 3 core CPU machines. There were several graph *RestartStrategies* that blocked threads from

[GitHub] flink pull request #2811: [Flink-4541] Support for SQL NOT IN operator

GitHub user AlexanderShoshin opened a pull request: https://github.com/apache/flink/pull/2811 [Flink-4541] Support for SQL NOT IN operator NOT IN was not working with nested queries because of missed DataSet cross join rule. I added DataSetSingleRowCrossRule that converts

[GitHub] flink pull request #2811: [FLINK-5159] Improve perfomance of inner joins wit...

Github user AlexanderShoshin commented on a diff in the pull request: https://github.com/apache/flink/pull/2811#discussion_r89628629 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/RichMapRunner.scala --- @@ -0,0 +1,52

[GitHub] flink issue #2811: [FLINK-4541] Support for SQL NOT IN operator

Github user AlexanderShoshin commented on the issue: https://github.com/apache/flink/pull/2811 Hi, Fabian. I've made all the corrections. One thing I didn't understand - are we going to allow the case of !joinCondition.isEqui in DataSetSingleRowCrossRule? I also

[GitHub] flink issue #2811: [FLINK-4541] Support for SQL NOT IN operator

Github user AlexanderShoshin commented on the issue: https://github.com/apache/flink/pull/2811 I think, that calling a JoinFunction inside a RichMapRunner make sence. I would also prefer not to touch the code generation if it's possible. But shouldn't we separate the support

[GitHub] flink issue #2811: [FLINK-4541] Support for SQL NOT IN operator

Github user AlexanderShoshin commented on the issue: https://github.com/apache/flink/pull/2811 Sure, I will do it tomorrow :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #2811: [FLINK-4541] Support for SQL NOT IN operator

Github user AlexanderShoshin commented on the issue: https://github.com/apache/flink/pull/2811 Thanks, Fabian. It's my mistake that I used a cross function. I will try to make the same with a map function. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request #2811: [FLINK-5159] Improve perfomance of inner joins wit...

Github user AlexanderShoshin commented on a diff in the pull request: https://github.com/apache/flink/pull/2811#discussion_r89960391 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetSingleRowJoin.scala --- @@ -0,0 +1,229

[GitHub] flink pull request #3009: [FLINK-5255] Improve single row check in DataSetSi...

GitHub user AlexanderShoshin opened a pull request: https://github.com/apache/flink/pull/3009 [FLINK-5255] Improve single row check in DataSetSingleRowJoinRule DataSetSingleRowJoinRule now supports not only `LogicalAggregate` as single row input, but also `LogicalCalc

[GitHub] flink pull request #2811: [FLINK-5159] Improve perfomance of inner joins wit...

Github user AlexanderShoshin commented on a diff in the pull request: https://github.com/apache/flink/pull/2811#discussion_r90034073 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetSingleRowJoin.scala --- @@ -0,0 +1,229

[GitHub] flink issue #2811: [FLINK-5159] Improve perfomance of inner joins with a sin...

Github user AlexanderShoshin commented on the issue: https://github.com/apache/flink/pull/2811 Hi, @fhueske. I've made the corrections that you asked. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project