[GitHub] flink pull request #4187: [FLINK-6998][Kafka Connector] Add kafka offset com...

2017-07-08 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4187#discussion_r126283316 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -104,7

[GitHub] flink pull request #4187: [FLINK-6998][Kafka Connector] Add kafka offset com...

2017-07-08 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4187#discussion_r126283335 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -184,6

[GitHub] flink pull request #4119: [docs] Fix typos (Souce -> Source)

2017-06-13 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/4119 [docs] Fix typos (Souce -> Source) This changes occurrences of *Souce* in the documentation to *Source*. You can merge this pull request into a Git repository by running: $ git pull ht

[GitHub] flink pull request #4764: [FLINK-7757] [checkpointing] Introduce resource gu...

2017-10-03 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4764#discussion_r142490404 --- Diff: flink-core/src/main/java/org/apache/flink/util/ResourceGuard.java --- @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] flink pull request #4791: [hotfix] [Javadoc] Fix typos

2017-10-10 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/4791 [hotfix] [Javadoc] Fix typos Fix typos in Javadoc for classes: - `org.apache.flink.api.java.typeutils.InputTypeConfigurable` - `org.apache.flink.core.fs.FileSystem` You can merge this pull

[GitHub] flink pull request #4803: [FLINK-7813] [metrics] Replace MetricRegistryThrea...

2017-10-17 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4803#discussion_r145122089 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java --- @@ -402,25 +401,4 @@ public void run

[GitHub] flink issue #4803: [FLINK-7813] [metrics] Replace MetricRegistryThreadFactor...

2017-10-17 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/4803 👍 I reviewed the code and can confirm that the implementations are virtually identical. ---

[GitHub] flink pull request #4807: [FLINK-7810] Switch from custom Flakka to Akka 2.4...

2017-10-12 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4807#discussion_r144245061 --- Diff: docs/start/building.md --- @@ -115,19 +115,7 @@ The `-Pvendor-repos` activates a Maven [build profile](http://maven.apache.org/g Flink has

[GitHub] flink issue #4777: [FLINK-7765] Enable dependency convergence

2017-10-13 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/4777 If this is merged, #2192 can be probably closed. ---

[GitHub] flink pull request #4755: [hotfix] [docs] Fix broken links

2017-10-01 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/4755 [hotfix] [docs] Fix broken links You can merge this pull request into a Git repository by running: $ git pull https://github.com/GJL/flink hotfix-broken-links Alternatively you can review

[GitHub] flink pull request #4856: [hotifx] [docs] Add required option -yn to example...

2017-10-19 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/4856 [hotifx] [docs] Add required option -yn to example command Example command to start the WordCount job via YARN does not work because it is missing the `-yn` option, which specifies the number of YARN

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-10 Thread GJL
Github user GJL closed the pull request at: https://github.com/apache/flink/pull/4980 ---

[GitHub] flink issue #5004: [FLINK-8040] [tests] Fix test instability in ResourceGuar...

2017-11-13 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/5004 👍 ---

[GitHub] flink issue #5004: [FLINK-8040] [tests] Fix test instability in ResourceGuar...

2017-11-13 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/5004 👍 ---

[GitHub] flink pull request #5079: [FLINK-7530][flip6] Migrate SubtaskMetricsHandler ...

2017-11-27 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5079 [FLINK-7530][flip6] Migrate SubtaskMetricsHandler to new RestServerEndpoint ## What is the purpose of the change *FLIP-6 efforts: Migrating HTTP handlers* ## Brief change log

[GitHub] flink pull request #5082: [FLINK-8143][flip6] Migrate SubtaskMetricsHandler ...

2017-11-27 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5082 [FLINK-8143][flip6] Migrate SubtaskMetricsHandler to new RestServerEndpoint ## What is the purpose of the change *FLIP-6 efforts: Migrating HTTP handlers* ## Brief change log

[GitHub] flink pull request #5079: [FLINK-8143][flip6] Migrate SubtaskMetricsHandler ...

2017-11-27 Thread GJL
Github user GJL closed the pull request at: https://github.com/apache/flink/pull/5079 ---

[GitHub] flink pull request #5081: [FLINK-7530][flip6] Migrate TaskManagerMetricsHand...

2017-11-27 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5081 [FLINK-7530][flip6] Migrate TaskManagerMetricsHandler to new RestServerEndpoint ## What is the purpose of the change *FLIP-6 efforts: Migrating HTTP handlers* ## Brief change log

[GitHub] flink issue #5079: [FLINK-8143][flip6] Migrate SubtaskMetricsHandler to new ...

2017-11-27 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/5079 My branch name is wrong. The commit messages are right. Let me know if this is a problem. ---

[GitHub] flink pull request #5084: [FLINK-7694][flip6] Migrate JobMetricsHandler to n...

2017-11-27 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5084 [FLINK-7694][flip6] Migrate JobMetricsHandler to new RestServerEndpoint ## What is the purpose of the change *FLIP-6 efforts: Migrating HTTP handlers* ## Brief change log

[GitHub] flink pull request #5083: [FLINK-7716][flip6] Migrate JobManagerMetricsHandl...

2017-11-27 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5083 [FLINK-7716][flip6] Migrate JobManagerMetricsHandler to new RestServerEndpoint ## What is the purpose of the change *FLIP-6 efforts: Migrating HTTP handlers* ## Brief change log

[GitHub] flink pull request #5093: [FLINK-8150] [flip6] Expose TaskExecutor's Resourc...

2017-11-28 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5093#discussion_r153482920 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerDetailsInfo.java --- @@ -43,7 +43,7

[GitHub] flink pull request #5093: [FLINK-8150] [flip6] Expose TaskExecutor's Resourc...

2017-11-28 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5093#discussion_r153483098 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerInfo.java --- @@ -53,8 +53,8 @@ public static final

[GitHub] flink pull request #5093: [FLINK-8150] [flip6] Expose TaskExecutor's Resourc...

2017-11-28 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5093#discussion_r153483875 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/json/ResourceIDSerializer.java --- @@ -29,16 +30,16 @@ /** * Json

[GitHub] flink pull request #5081: [FLINK-7717][flip6] Migrate TaskManagerMetricsHand...

2017-11-27 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5081#discussion_r153243460 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/metrics/TaskManagerMetricsHandler.java --- @@ -0,0 +1,64

[GitHub] flink pull request #5055: [FLINK-7718] [flip6] Add JobVertexMetricsHandler t...

2017-11-24 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5055#discussion_r152951899 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/metrics/AbstractMetricsHandler.java --- @@ -0,0 +1,141

[GitHub] flink pull request #5055: [FLINK-7718] [flip6] Add JobVertexMetricsHandler t...

2017-11-23 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5055#discussion_r152817079 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/job/metrics/MetricsFilterParameterTest.java --- @@ -0,0 +1,51

[GitHub] flink pull request #5055: [FLINK-7718] [flip6] Add JobVertexMetricsHandler t...

2017-11-23 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5055#discussion_r152837007 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/job/metrics/MetricsFilterParameterTest.java --- @@ -0,0 +1,51

[GitHub] flink issue #4757: [FLINK-7694][REST][Webfrontend]Port JobMetricsHandler to ...

2017-11-23 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/4757 @bowenli86 I am about to finish my work on [FLINK-7718](https://issues.apache.org/jira/browse/FLINK-7718), which is quite similar to your ticket. Unfortunately I missed that you are also migrating

[GitHub] flink pull request #5055: [FLINK-7718] [flip6] Add JobVertexMetricsHandler t...

2017-11-23 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5055#discussion_r152804507 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/metrics/AbstractMetricsHandler.java --- @@ -0,0 +1,141

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-11-30 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5107 [FLINK-8176][flip6] Start SubmittedJobGraphStore in Dispatcher ## What is the purpose of the change The FLIP-6 dispatcher never calls `start()` on its SubmittedJobGraphStore instance. Hence

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-11-30 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5107#discussion_r154128004 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java --- @@ -246,5 +258,11 @@ protected JobManagerRunner

[GitHub] flink pull request #5055: [FLINK-7718] [flip6] Add JobVertexMetricsHandler t...

2017-11-22 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5055 [FLINK-7718] [flip6] Add JobVertexMetricsHandler to DispatcherRestEndpoint ## Brief change log - *Migrate logic in `org.apache.flink.runtime.rest.handler.legacy.metrics.JobVertexMetricsHandler

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-12-04 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5107#discussion_r154747386 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -534,6 +536,40 @@ public void handleError(final Exception

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-12-04 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5107#discussion_r154748301 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java --- @@ -244,7 +302,32 @@ protected JobManagerRunner

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-12-04 Thread GJL
GitHub user GJL reopened a pull request: https://github.com/apache/flink/pull/5107 [FLINK-8176][flip6] Start SubmittedJobGraphStore in Dispatcher ## What is the purpose of the change The FLIP-6 dispatcher never calls `start()` on its SubmittedJobGraphStore instance. Hence

[GitHub] flink pull request #4889: [FLINK-7903] [tests] Add flip6 build profile

2017-12-18 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4889#discussion_r157468208 --- Diff: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/category/Flip6.java --- @@ -0,0 +1,25

[GitHub] flink pull request #5168: [FLINK-8234][flip6] WIP

2017-12-14 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5168#discussion_r157027881 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/JobExecutionResultCache.java --- @@ -0,0 +1,79 @@ +/* + * Licensed

[GitHub] flink pull request #5168: [FLINK-8234][flip6] WIP

2017-12-14 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5168#discussion_r157026590 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobExecutionResultHandler.java --- @@ -0,0 +1,107 @@ +/* + * Licensed

[GitHub] flink pull request #5168: [FLINK-8234][flip6] WIP

2017-12-14 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5168 [FLINK-8234][flip6] WIP WIP @tillrohrmann You can merge this pull request into a Git repository by running: $ git pull https://github.com/GJL/flink FLINK-8234 Alternatively you can

[GitHub] flink pull request #5168: [FLINK-8234][flip6] WIP

2017-12-14 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5168#discussion_r157027178 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/util/RestMapperUtils.java --- @@ -33,10 +40,23 @@ objectMapper.enable

[GitHub] flink pull request #5168: [FLINK-8234][flip6] WIP

2017-12-14 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5168#discussion_r157026313 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/util/RestMapperUtils.java --- @@ -33,10 +40,23 @@ objectMapper.enable

[GitHub] flink pull request #5168: [FLINK-8234][flip6] WIP

2017-12-14 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5168#discussion_r157027510 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/JobExecutionResultCache.java --- @@ -0,0 +1,79 @@ +/* + * Licensed

[GitHub] flink pull request #5168: [FLINK-8234][flip6] WIP

2017-12-14 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5168#discussion_r157027633 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/messages/JobExecutionResultNotFoundException.java --- @@ -0,0 +1,45 @@ +/* + * Licensed

[GitHub] flink pull request #5168: [FLINK-8234][flip6] WIP

2017-12-14 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5168#discussion_r157025791 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/JobExecutionResultCache.java --- @@ -0,0 +1,79 @@ +/* + * Licensed

[GitHub] flink pull request #4889: [FLINK-7903] [tests] Add flip6 build profile

2017-12-18 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4889#discussion_r157481924 --- Diff: pom.xml --- @@ -125,6 +125,9 @@ under the License. 1.6.5 1.3 false + --- End diff

[GitHub] flink pull request #5168: [FLINK-8234][flip6] WIP

2017-12-18 Thread GJL
Github user GJL closed the pull request at: https://github.com/apache/flink/pull/5168 ---

[GitHub] flink pull request #5168: [FLINK-8234][flip6] WIP

2017-12-18 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5168#discussion_r157489280 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -357,6 +362,28 @@ public void start() throws Exception

[GitHub] flink pull request #5168: [FLINK-8234][flip6] WIP

2017-12-18 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5168#discussion_r157462859 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobExecutionResult.java --- @@ -0,0 +1,112 @@ +/* + * Licensed

[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

2017-12-19 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5184#discussion_r157877406 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterJobDispatcher.java --- @@ -458,7 +465,14 @@ public JobExecutionResult

[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

2017-12-19 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5184#discussion_r157878862 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterJobDispatcher.java --- @@ -358,12 +360,12 @@ private DetachedFinalizer

[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

2017-12-19 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5184#discussion_r157876761 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/RestfulGateway.java --- @@ -92,4 +94,42 @@ * @return Future containing

[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

2017-12-19 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5184#discussion_r157876793 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/RestfulGateway.java --- @@ -92,4 +94,42 @@ * @return Future containing

[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

2017-12-19 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5184 [FLINK-8234][flip6] Cache JobExecutionResult in Dispatcher ## What is the purpose of the change Cache `JobExecutionResult` in `Dispatcher`, and add methods to `RestfulGateway` to enable

[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

2017-12-19 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5184#discussion_r157877969 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobExecutionResult.java --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #5168: [FLINK-8234][flip6] WIP

2017-12-20 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5168#discussion_r157961174 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/messages/JobExecutionResultNotFoundException.java --- @@ -0,0 +1,45 @@ +/* + * Licensed

[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

2017-12-20 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5184#discussion_r157962431 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterJobDispatcher.java --- @@ -458,7 +465,14 @@ public JobExecutionResult

[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

2017-12-20 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5184#discussion_r157963387 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterJobDispatcher.java --- @@ -405,22 +407,27 @@ private void

[GitHub] flink pull request #5168: [FLINK-8234][flip6] WIP

2017-12-20 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5168#discussion_r157960666 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/JobExecutionResultCache.java --- @@ -0,0 +1,79 @@ +/* + * Licensed

[GitHub] flink pull request #5168: [FLINK-8234][flip6] WIP

2017-12-20 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5168#discussion_r157960722 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -357,6 +362,28 @@ public void start() throws Exception

[GitHub] flink pull request #5168: [FLINK-8234][flip6] WIP

2017-12-20 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5168#discussion_r157960760 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/SerializedJobExecutionResult.java --- @@ -55,6 +56,26 @@ public

[GitHub] flink pull request #5168: [FLINK-8234][flip6] WIP

2017-12-20 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5168#discussion_r157961376 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/messages/JobExecutionResultNotFoundException.java --- @@ -0,0 +1,45 @@ +/* + * Licensed

[GitHub] flink issue #5168: [FLINK-8234][flip6] WIP

2017-12-20 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/5168 New PR #5184 ---

[GitHub] flink pull request #4995: [hotfix] [docs] Fix broken link to FLINK-7811

2017-11-10 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/4995 [hotfix] [docs] Fix broken link to FLINK-7811 This fixes a broken hyperlink on page https://ci.apache.org/projects/flink/flink-docs-release-1.4/start/building.html#scala-versions ![image

[GitHub] flink pull request #4915: [FLINK-7838] Bunch of hotfixes and fix missing syn...

2017-11-01 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4915#discussion_r148227364 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java --- @@ -226,13

[GitHub] flink pull request #4915: [FLINK-7838] Bunch of hotfixes and fix missing syn...

2017-11-01 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4915#discussion_r148226920 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011Test.java --- @@ -61,7

[GitHub] flink pull request #4955: [FLINK-7978][kafka] Ensure that transactional ids ...

2017-11-07 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4955#discussion_r149315106 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/TransactionalIdsGenerator.java

[GitHub] flink pull request #4955: [FLINK-7978][kafka] Ensure that transactional ids ...

2017-11-07 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4955#discussion_r149316761 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/internal/TransactionalIdsGeneratorTest.java

[GitHub] flink issue #4980: [FLINK-8005] [runtime] Set user code class loader before ...

2017-11-09 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/4980 There is only one thread dispatching the calls: ``` executor = Executors.newSingleThreadExecutor( new DispatcherThreadFactory(TASK_THREADS_GROUP

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149985097 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -277,8 +287,12 @@ public void invoke() throws

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149954849 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -254,12 +300,10 @@ else if (this.error == null

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149983878 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -277,8 +287,12 @@ public void invoke() throws

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149954576 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -58,99 +59,144 @@ import org.junit.Before

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149954606 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/DispatcherThreadFactory.java --- @@ -29,21 +31,41 @@ private final

[GitHub] flink issue #4980: [FLINK-8005] [runtime] Set user code class loader before ...

2017-11-09 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/4980 I addressed the comments. Let's wait for Travis and let me know if something else needs to be changed. @aljoscha @kl0u ---

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-09 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149955008 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -254,12 +300,10 @@ else if (this.error == null

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-08 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149637566 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -58,99 +58,119 @@ import org.junit.Before

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-08 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/4980 [FLINK-8005] [runtime] Set user code class loader before snapshot ## What is the purpose of the change *During checkpointing, user code may dynamically load classes from the user code jar

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-08 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149703888 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java --- @@ -58,99 +59,144 @@ import org.junit.Before

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-08 Thread GJL
GitHub user GJL reopened a pull request: https://github.com/apache/flink/pull/4980 [FLINK-8005] [runtime] Set user code class loader before snapshot ## What is the purpose of the change *During checkpointing, user code may dynamically load classes from the user code

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-08 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149703482 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskStopTest.java --- @@ -1,157 +0,0 @@ -/* - * Licensed to the Apache

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-08 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4980#discussion_r149703349 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskStopTest.java --- @@ -1,157 +0,0 @@ -/* - * Licensed to the Apache

[GitHub] flink pull request #4980: [FLINK-8005] [runtime] Set user code class loader ...

2017-11-08 Thread GJL
Github user GJL closed the pull request at: https://github.com/apache/flink/pull/4980 ---

[GitHub] flink pull request #4933: [FLINK-7960] [tests] Fix race conditions in Execut...

2017-11-01 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4933#discussion_r148305773 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/utils/SimpleAckingTaskManagerGateway.java --- @@ -48,6 +48,8

[GitHub] flink issue #4933: [FLINK-7960] [tests] Fix race conditions in ExecutionGrap...

2017-11-01 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/4933 While you are at it: `ExecutionGraphTestUtils#switchToRunning` ``` public static void switchToRunning(ExecutionGraph eg) { // check that all execution are in state

[GitHub] flink issue #4933: [FLINK-7960] [tests] Fix race conditions in ExecutionGrap...

2017-11-01 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/4933 On your branch `testRestartWithEagerSchedulingAndSlotSharing` is failing consistently ``` java.util.concurrent.TimeoutException

[GitHub] flink pull request #4933: [FLINK-7960] [tests] Fix race conditions in Execut...

2017-11-01 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4933#discussion_r148306365 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java --- @@ -844,7 +844,7 @@ else if (current == CANCELING || current

[GitHub] flink issue #4933: [FLINK-7960] [tests] Fix race conditions in ExecutionGrap...

2017-11-02 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/4933 LGTM 👍 Tests didn't fail after ~1000 local executions. ---

[GitHub] flink pull request #4933: [FLINK-7960] [tests] Fix race conditions in Execut...

2017-11-02 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4933#discussion_r148498481 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java --- @@ -844,7 +844,7 @@ else if (current == CANCELING || current

[GitHub] flink pull request #5087: [FLINK-8085] Thin out LogicalSlot interface

2017-12-05 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5087#discussion_r155015331 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/SchedulerIsolatedTasksTest.java --- @@ -294,11 +297,11 @@ public void

[GitHub] flink pull request #5087: [FLINK-8085] Thin out LogicalSlot interface

2017-12-05 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5087#discussion_r155012983 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java --- @@ -331,8 +334,19 @@ public void setInitialState

[GitHub] flink pull request #5087: [FLINK-8085] Thin out LogicalSlot interface

2017-12-05 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5087#discussion_r155016510 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionTest.java --- @@ -267,10 +270,77 @@ public void

[GitHub] flink pull request #5087: [FLINK-8085] Thin out LogicalSlot interface

2017-12-05 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5087#discussion_r155018207 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionTest.java --- @@ -267,10 +270,77 @@ public void

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-12-08 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5091#discussion_r155768880 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java --- @@ -0,0 +1,722 @@ +/* + * Licensed

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-12-08 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5091#discussion_r155770364 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManagerTest.java --- @@ -0,0 +1,502 @@ +/* + * Licensed

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-12-08 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5091#discussion_r155770104 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManagerTest.java --- @@ -0,0 +1,502 @@ +/* + * Licensed

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-12-08 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5091#discussion_r155758219 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java --- @@ -0,0 +1,722 @@ +/* + * Licensed

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-12-08 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5091#discussion_r155754738 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java --- @@ -266,104 +279,367 @@ public void

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-12-08 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5091#discussion_r155751694 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java --- @@ -266,104 +279,367 @@ public void

[GitHub] flink pull request #4987: [FLINK-8029] Create WebMonitorEndpoint

2017-12-08 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/4987#discussion_r155804733 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -757,6 +775,64 @@ public void heartbeatFromResourceManager(final

  1   2   3   4   5   6   >