[GitHub] yanghua closed pull request #6428: [FLINK-9961] Add CHR function for table/sql API

2018-07-27 Thread GitBox
yanghua closed pull request #6428: [FLINK-9961] Add CHR function for table/sql API URL: https://github.com/apache/flink/pull/6428 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] yanghua commented on issue #6428: [FLINK-9961] Add CHR function for table/sql API

2018-07-27 Thread GitBox
yanghua commented on issue #6428: [FLINK-9961] Add CHR function for table/sql API URL: https://github.com/apache/flink/pull/6428#issuecomment-408579119 Merged into PR #6432 , so close this one. This is an automated message

[GitHub] hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API

2018-07-27 Thread GitBox
hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r205932686 ## File path: docs/dev/table/tableApi.md ## @@ -2507,6 +2518,17 @@ concat_ws(separator,

[GitHub] hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API

2018-07-27 Thread GitBox
hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r205932661 ## File path: docs/dev/table/sql.md ## @@ -1850,6 +1860,17 @@ FROM_BASE64(text string)

[GitHub] hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API

2018-07-27 Thread GitBox
hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r205932678 ## File path: docs/dev/table/tableApi.md ## @@ -2507,6 +2518,17 @@ concat_ws(separator,

[GitHub] hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API

2018-07-27 Thread GitBox
hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r205932697 ## File path:

[GitHub] hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API

2018-07-27 Thread GitBox
hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r205932695 ## File path:

[GitHub] hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API

2018-07-27 Thread GitBox
hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r205932693 ## File path:

[GitHub] hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API

2018-07-27 Thread GitBox
hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r205932698 ## File path:

[GitHub] hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API

2018-07-27 Thread GitBox
hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r205932701 ## File path:

[GitHub] yanghua opened a new pull request #6444: [FLINK-9933] Simplify taskmanager memory default values

2018-07-27 Thread GitBox
yanghua opened a new pull request #6444: [FLINK-9933] Simplify taskmanager memory default values URL: https://github.com/apache/flink/pull/6444 ## What is the purpose of the change *This pull request simplify taskmanager memory default values* ## Brief change log

[GitHub] klion26 commented on issue #6430: [FLINK-8058][Queryable State]Queryable state should check types

2018-07-27 Thread GitBox
klion26 commented on issue #6430: [FLINK-8058][Queryable State]Queryable state should check types URL: https://github.com/apache/flink/pull/6430#issuecomment-408584575 @yanghua thank you for helping review, I have updated the code~

[GitHub] hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API

2018-07-28 Thread GitBox
hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r205938013 ## File path:

[GitHub] yanghua commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API

2018-07-28 Thread GitBox
yanghua commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r205934831 ## File path:

[GitHub] xueyumusic opened a new pull request #6445: [FLINK-8302][Table API & SQL] Add SHIFT_LEFT and SHIFT_RIGHT

2018-07-28 Thread GitBox
xueyumusic opened a new pull request #6445: [FLINK-8302][Table API & SQL] Add SHIFT_LEFT and SHIFT_RIGHT URL: https://github.com/apache/flink/pull/6445 ## What is the purpose of the change This PR is based on the previous closed and unfinished work

[GitHub] hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API

2018-07-28 Thread GitBox
hequn8128 commented on a change in pull request #6432: [FLINK-9970] Add ASCII/CHR function for table/sql API URL: https://github.com/apache/flink/pull/6432#discussion_r205938013 ## File path:

[GitHub] twalthr commented on a change in pull request #6422: [FLINK-9833] [e2e] Add a SQL Client end-to-end test with unified source/sink/format

2018-08-02 Thread GitBox
twalthr commented on a change in pull request #6422: [FLINK-9833] [e2e] Add a SQL Client end-to-end test with unified source/sink/format URL: https://github.com/apache/flink/pull/6422#discussion_r207261738 ## File path: flink-end-to-end-tests/flink-sql-client-test/pom.xml

[GitHub] tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP

2018-08-02 Thread GitBox
tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP URL: https://github.com/apache/flink/pull/6464#discussion_r207293251 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java ## @@ -894,17

[GitHub] tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP

2018-08-02 Thread GitBox
tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP URL: https://github.com/apache/flink/pull/6464#discussion_r207294014 ## File path: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java ## @@

[GitHub] tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP

2018-08-02 Thread GitBox
tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP URL: https://github.com/apache/flink/pull/6464#discussion_r207294205 ## File path: flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManagerTest.java ##

[GitHub] tillrohrmann opened a new pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger

2018-08-02 Thread GitBox
tillrohrmann opened a new pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger URL: https://github.com/apache/flink/pull/6479 ## What is the purpose of the change This commit changes the behaviour of the UnilateralSortMerger to keep

[GitHub] asfgit closed pull request #6456: [FLINK-9947] [docs] Document unified table sources/sinks/formats

2018-08-02 Thread GitBox
asfgit closed pull request #6456: [FLINK-9947] [docs] Document unified table sources/sinks/formats URL: https://github.com/apache/flink/pull/6456 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] StefanRRichter commented on issue #6467: [FLINK-9887] Ensure serializer upgrades work with timer service remake

2018-08-02 Thread GitBox
StefanRRichter commented on issue #6467: [FLINK-9887] Ensure serializer upgrades work with timer service remake URL: https://github.com/apache/flink/pull/6467#issuecomment-409973957 Thanks for the review @tzulitai ! Merged.

[GitHub] kl0u edited a comment on issue #6477: [FLINK-10027] Add logging to StreamingFileSink

2018-08-02 Thread GitBox
kl0u edited a comment on issue #6477: [FLINK-10027] Add logging to StreamingFileSink URL: https://github.com/apache/flink/pull/6477#issuecomment-409980715 Thanks for the review @zentol ! I integrated your comments. Let me know if I can merge. BTW the removing and re-adding the

[GitHub] tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP

2018-08-02 Thread GitBox
tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP URL: https://github.com/apache/flink/pull/6464#discussion_r207295725 ## File path: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java ## @@

[GitHub] tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP

2018-08-02 Thread GitBox
tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP URL: https://github.com/apache/flink/pull/6464#discussion_r207302752 ## File path: flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManagerTest.java ##

[GitHub] tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP

2018-08-02 Thread GitBox
tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP URL: https://github.com/apache/flink/pull/6464#discussion_r207302992 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java ## @@ -894,17

[GitHub] tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP

2018-08-02 Thread GitBox
tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP URL: https://github.com/apache/flink/pull/6464#discussion_r207306976 ## File path: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java ## @@

[GitHub] asfgit closed pull request #6477: [FLINK-10027] Add logging to StreamingFileSink

2018-08-02 Thread GitBox
asfgit closed pull request #6477: [FLINK-10027] Add logging to StreamingFileSink URL: https://github.com/apache/flink/pull/6477 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] kl0u edited a comment on issue #6477: [FLINK-10027] Add logging to StreamingFileSink

2018-08-02 Thread GitBox
kl0u edited a comment on issue #6477: [FLINK-10027] Add logging to StreamingFileSink URL: https://github.com/apache/flink/pull/6477#issuecomment-409980715 Thanks for the review @zentol ! I integrated your comments. Let me know if I can merge.

[GitHub] zentol commented on issue #6477: [FLINK-10027] Add logging to StreamingFileSink

2018-08-02 Thread GitBox
zentol commented on issue #6477: [FLINK-10027] Add logging to StreamingFileSink URL: https://github.com/apache/flink/pull/6477#issuecomment-409983473 +1. This is an automated message from the Apache Git Service. To respond to

[GitHub] kl0u commented on issue #6477: [FLINK-10027] Add logging to StreamingFileSink

2018-08-02 Thread GitBox
kl0u commented on issue #6477: [FLINK-10027] Add logging to StreamingFileSink URL: https://github.com/apache/flink/pull/6477#issuecomment-409988617 Thanks for the review @zentol . I will merge as soon as travis gives green.

[GitHub] asfgit closed pull request #6422: [FLINK-9833] [e2e] Add a SQL Client end-to-end test with unified source/sink/format

2018-08-02 Thread GitBox
asfgit closed pull request #6422: [FLINK-9833] [e2e] Add a SQL Client end-to-end test with unified source/sink/format URL: https://github.com/apache/flink/pull/6422 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] walterddr commented on issue #6471: [FLINK-10010][DataStream API] Deprecate unused BaseAlignedWindowAssigner related components

2018-08-02 Thread GitBox
walterddr commented on issue #6471: [FLINK-10010][DataStream API] Deprecate unused BaseAlignedWindowAssigner related components URL: https://github.com/apache/flink/pull/6471#issuecomment-409989144 thx for the review @yanghua . for some reason java checkstyle did not catch these problems.

[GitHub] zentol commented on a change in pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger

2018-08-02 Thread GitBox
zentol commented on a change in pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger URL: https://github.com/apache/flink/pull/6479#discussion_r207319672 ## File path:

[GitHub] kl0u commented on issue #6477: [FLINK-10027] Add logging to StreamingFileSink

2018-08-02 Thread GitBox
kl0u commented on issue #6477: [FLINK-10027] Add logging to StreamingFileSink URL: https://github.com/apache/flink/pull/6477#issuecomment-409980715 Thanks for the review @zentol ! Let me know if I can merge. This is an

[GitHub] zentol commented on a change in pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger

2018-08-02 Thread GitBox
zentol commented on a change in pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger URL: https://github.com/apache/flink/pull/6479#discussion_r207319425 ## File path:

[GitHub] tzulitai commented on a change in pull request #6440: [FLINK-9979] [table] Support a FlinkKafkaPartitioner for Kafka table sink factory

2018-08-01 Thread GitBox
tzulitai commented on a change in pull request #6440: [FLINK-9979] [table] Support a FlinkKafkaPartitioner for Kafka table sink factory URL: https://github.com/apache/flink/pull/6440#discussion_r206879886 ## File path:

[GitHub] NicoK opened a new pull request #6470: [FLINK-10006][network] improve logging in BarrierBuffer: prepend owning task name

2018-08-01 Thread GitBox
NicoK opened a new pull request #6470: [FLINK-10006][network] improve logging in BarrierBuffer: prepend owning task name URL: https://github.com/apache/flink/pull/6470 ## What is the purpose of the change Almost all log messages of `BarrierBuffer` do not contain the task name and

[GitHub] NicoK commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options

2018-08-01 Thread GitBox
NicoK commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options URL: https://github.com/apache/flink/pull/6355#discussion_r206905353 ## File path:

[GitHub] zentol commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics

2018-08-01 Thread GitBox
zentol commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics URL: https://github.com/apache/flink/pull/4801#discussion_r206919014 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/utils/SystemResourcesCounter.java

[GitHub] zentol commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics

2018-08-01 Thread GitBox
zentol commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics URL: https://github.com/apache/flink/pull/4801#discussion_r206918739 ## File path: docs/monitoring/metrics.md ## @@ -1370,6 +1370,147 @@ Thus, in order to infer the metric

[GitHub] medcv commented on issue #6259: [FLINK-9679] Implement AvroSerializationSchema

2018-08-01 Thread GitBox
medcv commented on issue #6259: [FLINK-9679] Implement AvroSerializationSchema URL: https://github.com/apache/flink/pull/6259#issuecomment-409619105 @tillrohrmann Thanks for the update! This is an automated message from

[GitHub] asfgit closed pull request #6427: [FLINK-9926][Kinesis Connector] Allow for ShardConsumer override in Kinesis consumer.

2018-08-01 Thread GitBox
asfgit closed pull request #6427: [FLINK-9926][Kinesis Connector] Allow for ShardConsumer override in Kinesis consumer. URL: https://github.com/apache/flink/pull/6427 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] asfgit closed pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6.x

2018-08-01 Thread GitBox
asfgit closed pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6.x URL: https://github.com/apache/flink/pull/6391 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] twalthr commented on a change in pull request #6456: [FLINK-9947] [docs] Document unified table sources/sinks/formats

2018-08-01 Thread GitBox
twalthr commented on a change in pull request #6456: [FLINK-9947] [docs] Document unified table sources/sinks/formats URL: https://github.com/apache/flink/pull/6456#discussion_r206883522 ## File path: docs/dev/table/sourceSinks.md ## @@ -1,5 +1,5 @@ --- -title: "Table

[GitHub] GJL commented on issue #6464: [FLINK-9936][mesos] WIP

2018-08-01 Thread GitBox
GJL commented on issue #6464: [FLINK-9936][mesos] WIP URL: https://github.com/apache/flink/pull/6464#issuecomment-409579075 @liurenjie1024 I currently have resources to work on this full time. I think I can create a new PR today or tomorrow. I'd be happy if you can review the code.

[GitHub] asfgit closed pull request #6440: [FLINK-9979] [table] Support a FlinkKafkaPartitioner for Kafka table sink factory

2018-08-01 Thread GitBox
asfgit closed pull request #6440: [FLINK-9979] [table] Support a FlinkKafkaPartitioner for Kafka table sink factory URL: https://github.com/apache/flink/pull/6440 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] twalthr commented on a change in pull request #6447: [FLINK-9963] [table] Add a string table format factory

2018-08-01 Thread GitBox
twalthr commented on a change in pull request #6447: [FLINK-9963] [table] Add a string table format factory URL: https://github.com/apache/flink/pull/6447#discussion_r206907666 ## File path: flink-formats/flink-string/pom.xml ## @@ -0,0 +1,112 @@ + +

[GitHub] yanghua commented on a change in pull request #6470: [FLINK-10006][network] improve logging in BarrierBuffer: prepend owning task name

2018-08-01 Thread GitBox
yanghua commented on a change in pull request #6470: [FLINK-10006][network] improve logging in BarrierBuffer: prepend owning task name URL: https://github.com/apache/flink/pull/6470#discussion_r206931425 ## File path:

[GitHub] yanghua commented on a change in pull request #6470: [FLINK-10006][network] improve logging in BarrierBuffer: prepend owning task name

2018-08-01 Thread GitBox
yanghua commented on a change in pull request #6470: [FLINK-10006][network] improve logging in BarrierBuffer: prepend owning task name URL: https://github.com/apache/flink/pull/6470#discussion_r206931865 ## File path:

[GitHub] GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP

2018-08-01 Thread GitBox
GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP URL: https://github.com/apache/flink/pull/6464#discussion_r206884046 ## File path: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java ## @@ -279,21

[GitHub] twalthr commented on issue #6456: [FLINK-9947] [docs] Document unified table sources/sinks/formats

2018-08-01 Thread GitBox
twalthr commented on issue #6456: [FLINK-9947] [docs] Document unified table sources/sinks/formats URL: https://github.com/apache/flink/pull/6456#issuecomment-409580684 Thanks for the review @fhueske. I updated the PR. This

[GitHub] aljoscha closed pull request #6469: [FLINK-10016] Make YARN/Kerberos end-to-end test stricter

2018-08-01 Thread GitBox
aljoscha closed pull request #6469: [FLINK-10016] Make YARN/Kerberos end-to-end test stricter URL: https://github.com/apache/flink/pull/6469 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] aljoscha commented on issue #6469: [FLINK-10016] Make YARN/Kerberos end-to-end test stricter

2018-08-01 Thread GitBox
aljoscha commented on issue #6469: [FLINK-10016] Make YARN/Kerberos end-to-end test stricter URL: https://github.com/apache/flink/pull/6469#issuecomment-409590273 merged This is an automated message from the Apache Git

[GitHub] twalthr commented on a change in pull request #6456: [FLINK-9947] [docs] Document unified table sources/sinks/formats

2018-08-01 Thread GitBox
twalthr commented on a change in pull request #6456: [FLINK-9947] [docs] Document unified table sources/sinks/formats URL: https://github.com/apache/flink/pull/6456#discussion_r206876401 ## File path: docs/dev/table/connect.md ## @@ -0,0 +1,1033 @@ +--- +title: "Connect

[GitHub] zentol commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics

2018-08-01 Thread GitBox
zentol commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics URL: https://github.com/apache/flink/pull/4801#discussion_r206916437 ## File path: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala ## @@

[GitHub] zentol commented on issue #4801: [FLINK-7812] Log system resources metrics

2018-08-01 Thread GitBox
zentol commented on issue #4801: [FLINK-7812] Log system resources metrics URL: https://github.com/apache/flink/pull/4801#issuecomment-409608732 Also needs a rebase. This is an automated message from the Apache Git Service.

[GitHub] zentol commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics

2018-08-01 Thread GitBox
zentol commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics URL: https://github.com/apache/flink/pull/4801#discussion_r206915837 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/utils/SystemResourcesCounter.java

[GitHub] zentol commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics

2018-08-01 Thread GitBox
zentol commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics URL: https://github.com/apache/flink/pull/4801#discussion_r206915920 ## File path:

[GitHub] asfgit closed pull request #6043: [FLINK-7386] evolve RequestIndexer API to make it working with Elastic 5.3+, evolve ElasticsearchApiCallBridge API to make it compatible with a possible Rest

2018-08-01 Thread GitBox
asfgit closed pull request #6043: [FLINK-7386] evolve RequestIndexer API to make it working with Elastic 5.3+, evolve ElasticsearchApiCallBridge API to make it compatible with a possible RestHighLevelClient implementation URL: https://github.com/apache/flink/pull/6043 This is a PR

[GitHub] asfgit closed pull request #6408: [FLINK-9897][Kinesis Connector] Make adaptive reads depend on run loop time instead of fetchintervalmillis

2018-08-01 Thread GitBox
asfgit closed pull request #6408: [FLINK-9897][Kinesis Connector] Make adaptive reads depend on run loop time instead of fetchintervalmillis URL: https://github.com/apache/flink/pull/6408 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] aljoscha commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics

2018-08-01 Thread GitBox
aljoscha commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics URL: https://github.com/apache/flink/pull/4801#discussion_r206900869 ## File path: docs/_includes/generated/task_manager_configuration.html ## @@ -37,6 +37,16 @@

[GitHub] yanghua commented on issue #6468: [FLINK-9900][tests] Include more information on timeout in Zookeeper HA ITCase

2018-08-01 Thread GitBox
yanghua commented on issue #6468: [FLINK-9900][tests] Include more information on timeout in Zookeeper HA ITCase URL: https://github.com/apache/flink/pull/6468#issuecomment-409626058 +1 This is an automated message from the

[GitHub] zentol commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics

2018-08-01 Thread GitBox
zentol commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics URL: https://github.com/apache/flink/pull/4801#discussion_r206915374 ## File path: docs/_includes/generated/task_manager_configuration.html ## @@ -37,6 +37,16 @@

[GitHub] zentol commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics

2018-08-01 Thread GitBox
zentol commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics URL: https://github.com/apache/flink/pull/4801#discussion_r206912468 ## File path: docs/monitoring/metrics.md ## @@ -1370,6 +1370,147 @@ Thus, in order to infer the metric

[GitHub] zentol commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics

2018-08-01 Thread GitBox
zentol commented on a change in pull request #4801: [FLINK-7812] Log system resources metrics URL: https://github.com/apache/flink/pull/4801#discussion_r206916150 ## File path:

[GitHub] GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP

2018-08-01 Thread GitBox
GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP URL: https://github.com/apache/flink/pull/6464#discussion_r206951198 ## File path: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java ## @@ -278,22

[GitHub] StephanEwen opened a new pull request #6480: [FLINK-10033] [runtime] Task releases reference to AbstractInvokable

2018-08-02 Thread GitBox
StephanEwen opened a new pull request #6480: [FLINK-10033] [runtime] Task releases reference to AbstractInvokable URL: https://github.com/apache/flink/pull/6480 ## What is the purpose of the change References to Task objects may under some conditions linger longer than for the

[GitHub] TisonKun commented on issue #6481: Add Event Time Details documentation page

2018-08-02 Thread GitBox
TisonKun commented on issue #6481: Add Event Time Details documentation page URL: https://github.com/apache/flink/pull/6481#issuecomment-410131208 FYI, the travis-ci failure is irrelevant about this PR. This is an automated

[GitHub] TisonKun commented on issue #6353: [FLINK-9875][runtime] Add concurrent creation of execution job vertex

2018-08-02 Thread GitBox
TisonKun commented on issue #6353: [FLINK-9875][runtime] Add concurrent creation of execution job vertex URL: https://github.com/apache/flink/pull/6353#issuecomment-410149936 Further discussion about parallelizing the creation of InputSplit goes to

[GitHub] tzulitai commented on a change in pull request #6478: [FLINK-9861][tests] Add StreamingFileSink E2E test

2018-08-02 Thread GitBox
tzulitai commented on a change in pull request #6478: [FLINK-9861][tests] Add StreamingFileSink E2E test URL: https://github.com/apache/flink/pull/6478#discussion_r207438658 ## File path:

[GitHub] TisonKun commented on issue #6481: Add Event Time Details documentation page

2018-08-02 Thread GitBox
TisonKun commented on issue #6481: Add Event Time Details documentation page URL: https://github.com/apache/flink/pull/6481#issuecomment-410131107 Hi @eliaslevy , thanks for you PR! It looks this PR is far more than a trivial work. Please take a look at the PULL_REQUEST_TEMPLATE as

[GitHub] glaksh100 commented on issue #6409: [FLINK-9899][Kinesis Connecotr] Add comprehensive per-shard metrics to ShardConsumer

2018-08-02 Thread GitBox
glaksh100 commented on issue #6409: [FLINK-9899][Kinesis Connecotr] Add comprehensive per-shard metrics to ShardConsumer URL: https://github.com/apache/flink/pull/6409#issuecomment-410145433 @tzulitai Sorry for the delay. Rebased the branch with latest master and added documentation for

[GitHub] glaksh100 edited a comment on issue #6409: [FLINK-9899][Kinesis Connecotr] Add comprehensive per-shard metrics to ShardConsumer

2018-08-02 Thread GitBox
glaksh100 edited a comment on issue #6409: [FLINK-9899][Kinesis Connecotr] Add comprehensive per-shard metrics to ShardConsumer URL: https://github.com/apache/flink/pull/6409#issuecomment-410145433 @zentol @tzulitai Sorry for the delay. Rebased the branch with latest master and added

[GitHub] TisonKun commented on issue #6481: [FLINK-10037] [Documentation] Add Event Time Details documentation page

2018-08-02 Thread GitBox
TisonKun commented on issue #6481: [FLINK-10037] [Documentation] Add Event Time Details documentation page URL: https://github.com/apache/flink/pull/6481#issuecomment-410143882 cc @zentol This is an automated message from

[GitHub] HuangZhenQiu commented on issue #6483: [Flink-7243][flink-formats] Add parquet input format

2018-08-02 Thread GitBox
HuangZhenQiu commented on issue #6483: [Flink-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#issuecomment-410152524 @suez1224 Would you please have a look this PR? This is an

[GitHub] tzulitai commented on a change in pull request #6482: [FLINK-10020] [kinesis] Support recoverable exceptions in listShards.

2018-08-02 Thread GitBox
tzulitai commented on a change in pull request #6482: [FLINK-10020] [kinesis] Support recoverable exceptions in listShards. URL: https://github.com/apache/flink/pull/6482#discussion_r207447268 ## File path:

[GitHub] TisonKun commented on a change in pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger

2018-08-02 Thread GitBox
TisonKun commented on a change in pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger URL: https://github.com/apache/flink/pull/6479#discussion_r207425876 ## File path:

[GitHub] TisonKun commented on a change in pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger

2018-08-02 Thread GitBox
TisonKun commented on a change in pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger URL: https://github.com/apache/flink/pull/6479#discussion_r207425876 ## File path:

[GitHub] TisonKun commented on a change in pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger

2018-08-02 Thread GitBox
TisonKun commented on a change in pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger URL: https://github.com/apache/flink/pull/6479#discussion_r207428623 ## File path:

[GitHub] eliaslevy commented on issue #6481: [FLINK-10037] [Documentation] Add Event Time Details documentation page

2018-08-02 Thread GitBox
eliaslevy commented on issue #6481: [FLINK-10037] [Documentation] Add Event Time Details documentation page URL: https://github.com/apache/flink/pull/6481#issuecomment-410135944 Done. This is an automated message from the

[GitHub] tweise opened a new pull request #6482: [FLINK-10020] [kinesis] Support recoverable exceptions in listShards.

2018-08-02 Thread GitBox
tweise opened a new pull request #6482: [FLINK-10020] [kinesis] Support recoverable exceptions in listShards. URL: https://github.com/apache/flink/pull/6482 This change fixes the retry behavior of listShards to match what getRecords already supports. Importantly this will prevent the

[GitHub] eliaslevy opened a new pull request #6481: Add Event Time Details documentation page

2018-08-02 Thread GitBox
eliaslevy opened a new pull request #6481: Add Event Time Details documentation page URL: https://github.com/apache/flink/pull/6481 *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution

[GitHub] TisonKun commented on issue #6480: [FLINK-10033] [runtime] Task releases reference to AbstractInvokable

2018-08-02 Thread GitBox
TisonKun commented on issue #6480: [FLINK-10033] [runtime] Task releases reference to AbstractInvokable URL: https://github.com/apache/flink/pull/6480#issuecomment-410124471 nice catch! memory leaks is one of the most terrible issues, this is helpful. +1 for merge

[GitHub] HuangZhenQiu opened a new pull request #6483: Add parquet input format

2018-08-02 Thread GitBox
HuangZhenQiu opened a new pull request #6483: Add parquet input format URL: https://github.com/apache/flink/pull/6483 *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best

[GitHub] GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP

2018-08-03 Thread GitBox
GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP URL: https://github.com/apache/flink/pull/6464#discussion_r207456451 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java ## @@ -894,17 +900,21 @@

[GitHub] GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP

2018-08-03 Thread GitBox
GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP URL: https://github.com/apache/flink/pull/6464#discussion_r207461474 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java ## @@ -894,17 +900,21 @@

[GitHub] GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP

2018-08-03 Thread GitBox
GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP URL: https://github.com/apache/flink/pull/6464#discussion_r207461514 ## File path: flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManagerTest.java ## @@

[GitHub] suez1224 opened a new pull request #6484: [FLINK-9134][Table API & SQL] upgrade Calcite dependency to 1.17

2018-08-03 Thread GitBox
suez1224 opened a new pull request #6484: [FLINK-9134][Table API & SQL] upgrade Calcite dependency to 1.17 URL: https://github.com/apache/flink/pull/6484 ## What is the purpose of the change upgrade Calcite dependency to 1.17 ## Brief change log - incoporate calcite

[GitHub] tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP

2018-08-03 Thread GitBox
tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP URL: https://github.com/apache/flink/pull/6464#discussion_r207463112 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java ## @@ -734,8

[GitHub] tillrohrmann commented on a change in pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger

2018-08-03 Thread GitBox
tillrohrmann commented on a change in pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger URL: https://github.com/apache/flink/pull/6479#discussion_r207459523 ## File path:

[GitHub] tillrohrmann commented on a change in pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger

2018-08-03 Thread GitBox
tillrohrmann commented on a change in pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger URL: https://github.com/apache/flink/pull/6479#discussion_r207459350 ## File path:

[GitHub] GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP

2018-08-03 Thread GitBox
GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP URL: https://github.com/apache/flink/pull/6464#discussion_r207461579 ## File path: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java ## @@ -278,22

[GitHub] GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP

2018-08-03 Thread GitBox
GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP URL: https://github.com/apache/flink/pull/6464#discussion_r207462105 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java ## @@ -734,8 +734,14 @@

[GitHub] zentol commented on a change in pull request #6409: [FLINK-9899][Kinesis Connector] Add comprehensive per-shard metrics to ShardConsumer

2018-08-03 Thread GitBox
zentol commented on a change in pull request #6409: [FLINK-9899][Kinesis Connector] Add comprehensive per-shard metrics to ShardConsumer URL: https://github.com/apache/flink/pull/6409#discussion_r207484326 ## File path:

[GitHub] tillrohrmann commented on a change in pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger

2018-08-03 Thread GitBox
tillrohrmann commented on a change in pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger URL: https://github.com/apache/flink/pull/6479#discussion_r207459818 ## File path:

[GitHub] TisonKun commented on issue #6485: [hotfix] [test] Wait CompletableFuture complete

2018-08-03 Thread GitBox
TisonKun commented on issue #6485: [hotfix] [test] Wait CompletableFuture complete URL: https://github.com/apache/flink/pull/6485#issuecomment-410171708 cc @tillrohrmann @zentol This is an automated message from the Apache

[GitHub] tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP

2018-08-03 Thread GitBox
tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP URL: https://github.com/apache/flink/pull/6464#discussion_r207463934 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java ## @@ -894,17

[GitHub] TisonKun opened a new pull request #6485: [hotfix] [test] Wait CompletableFuture complete

2018-08-03 Thread GitBox
TisonKun opened a new pull request #6485: [hotfix] [test] Wait CompletableFuture complete URL: https://github.com/apache/flink/pull/6485 ## What is the purpose of the change harden existing tests ## Brief change log wait CompletableFuture complete in JobMasterTest,

  1   2   3   4   5   6   7   8   9   10   >