[GitHub] flink issue #2288: Feature/s3 a fix

2016-08-15 Thread cresny
Github user cresny commented on the issue: https://github.com/apache/flink/pull/2288 I just returned from vacation so I have some catching up to do, but I'll take care of this today or tomorrow. On Aug 15, 2016 6:22 AM, "Ufuk Celebi" wrote:

[GitHub] flink pull request #2288: Feature/s3 a fix

2016-08-15 Thread cresny
Github user cresny commented on a diff in the pull request: https://github.com/apache/flink/pull/2288#discussion_r74774950 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java --- @@ -255,4 +257,33 @@ private Utils() { } return result

[GitHub] flink pull request #2288: Feature/s3 a fix

2016-08-15 Thread cresny
Github user cresny commented on a diff in the pull request: https://github.com/apache/flink/pull/2288#discussion_r74776047 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/util/HDFSCopyUtilitiesTest.java --- @@ -70,6 +70,85 @@ public void testCopyFromLocal

[GitHub] flink pull request #2288: Feature/s3 a fix

2016-08-16 Thread cresny
Github user cresny commented on a diff in the pull request: https://github.com/apache/flink/pull/2288#discussion_r74957429 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/HDFSCopyFromLocal.java --- @@ -62,4 +64,34 @@ public void run

[GitHub] flink pull request #2288: Feature/s3 a fix

2016-08-16 Thread cresny
Github user cresny commented on a diff in the pull request: https://github.com/apache/flink/pull/2288#discussion_r74974171 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/HDFSCopyFromLocal.java --- @@ -62,4 +64,34 @@ public void run

[GitHub] flink pull request #2288: Feature/s3 a fix

2016-08-16 Thread cresny
Github user cresny commented on a diff in the pull request: https://github.com/apache/flink/pull/2288#discussion_r74982416 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/HDFSCopyFromLocal.java --- @@ -62,4 +64,34 @@ public void run

[GitHub] flink issue #2288: Feature/s3 a fix

2016-08-17 Thread cresny
Github user cresny commented on the issue: https://github.com/apache/flink/pull/2288 refactored commit here: https://github.com/apache/flink/pull/2288/commits/8505e9c77f5ed79542af259f007be2c3a29edbc5 self-tested working in upstream master --- If your project is set up for

[GitHub] flink issue #2288: Feature/s3 a fix

2016-11-09 Thread cresny
Github user cresny commented on the issue: https://github.com/apache/flink/pull/2288 @uce I finally got around to fixing this. Regarding your above comments: - I think we got the "flattening" concern backwards. What I meant and wanted to avoid was to move all

[GitHub] flink pull request #2288: Feature/s3 a fix

2016-07-22 Thread cresny
GitHub user cresny opened a pull request: https://github.com/apache/flink/pull/2288 Feature/s3 a fix Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into

[GitHub] flink issue #2288: Feature/s3 a fix

2016-10-12 Thread cresny
Github user cresny commented on the issue: https://github.com/apache/flink/pull/2288 I was hoping that when the 1.2-SNAPSHOT dust cleared it would no longer be necessary. At this point it seems it's only necessary for staging a YARN session for an S3A configured FileS