Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/3357#discussion_r102693470
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/TableWithSQLITCase.scala
---
@@ -113,4 +114,26 @@ class
Github user kaibozhou commented on the issue:
https://github.com/apache/flink/pull/3357
Hi @twalthr , thank you for the reviewing. I have updated the PR according
to your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/3357#discussion_r102692495
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCorrelate.scala
---
@@ -188,7 +189,12 @@ trait
GitHub user kaibozhou opened a pull request:
https://github.com/apache/flink/pull/3357
[FLINK-5566] [table] Exception when do filter after join a UDTF which
returns a POJO type
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following
Github user kaibozhou closed the pull request at:
https://github.com/apache/flink/pull/4351
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kaibozhou opened a pull request:
https://github.com/apache/flink/pull/4355
[FLINK-7206] [table] Implementation of DataView to support state access
for UDAGG
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following
GitHub user kaibozhou opened a pull request:
https://github.com/apache/flink/pull/4351
[FLINK-6544] [table] Expose State Backend Interface for UDAGG
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128730510
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala
---
@@ -0,0 +1,99 @@
+/*
+ * Licensed
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128730577
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -357,6 +423,9 @@ class
Github user kaibozhou commented on the issue:
https://github.com/apache/flink/pull/4355
Comments addressed.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128963861
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/HeapViewFactory.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128963805
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/DataViewFactory.scala
---
@@ -0,0 +1,35 @@
+/*
+ * Licensed
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128994068
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -535,4 +654,21
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r128963446
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala
---
@@ -0,0 +1,99 @@
+/*
+ * Licensed
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r130628208
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r130625494
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -307,6 +312,119
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r130612699
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r130606340
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r130611417
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134653998
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1646,4 +1649,86 @@ abstract class
Github user kaibozhou commented on the issue:
https://github.com/apache/flink/pull/4355
@fhueske @wuchong
Thank you for your suggestion, I have update the PR and add test case,
thanks.
Do you have time to look at this?
Thanks, Kaibo
---
If your project is set
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134653928
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1646,4 +1649,86 @@ abstract class
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r134653871
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1646,4 +1649,86 @@ abstract class
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r133924725
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/runtime/utils/JavaUserDefinedAggFunctions.java
---
@@ -135,4 +138,172
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r133925097
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -405,6 +481,17 @@ class
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r133925176
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -179,13 +214,19 @@ class
Github user kaibozhou commented on the issue:
https://github.com/apache/flink/pull/4355
1. Use HeapMapView/HeapListView as default implementation
2. add initialize and cleanUp interface to GeneratedAggregations
---
If your project is set up for it, you can reply to this email
Github user kaibozhou closed the pull request at:
https://github.com/apache/flink/pull/3893
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kaibozhou opened a pull request:
https://github.com/apache/flink/pull/3895
[FLINK-6544] [table] Expose State Backend Interface for UDAGG
This PR partially solved "Expose State Backend Interface for UDAGG",
support over aggregate and unbounded group
GitHub user kaibozhou opened a pull request:
https://github.com/apache/flink/pull/3893
[Flink-6544][table] Expose State Backend Interface for UDAGG
This PR partially solved "Expose State Backend Interface for UDAGG",
support over aggregate and unbounded group
Github user kaibozhou closed the pull request at:
https://github.com/apache/flink/pull/3895
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kaibozhou commented on the issue:
https://github.com/apache/flink/pull/3895
The design has changed, and close it first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r135162070
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1469,4 +1526,26 @@ object
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r135163096
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/runtime/utils/JavaUserDefinedAggFunctions.java
---
@@ -135,4 +138,177
Github user kaibozhou commented on the issue:
https://github.com/apache/flink/pull/4355
In MapViewSerializer.scala, the function "override def serialize(record:
MapView[K, V], target: DataOutputView):" need to access var map which defined
in MapView.sca
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r135179087
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -161,13 +182,108 @@ class
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r135179101
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -178,13 +294,15 @@ class
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r135181433
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala
---
@@ -100,6 +108,17
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r135184770
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/table/runtime/utils/JavaUserDefinedAggFunctions.java
---
@@ -135,4 +138,177
Github user kaibozhou commented on the issue:
https://github.com/apache/flink/pull/4355
Thanks @fhueske for the suggestion.
All comments addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r135171980
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -356,6 +486,9 @@ class
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r135173258
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1469,4 +1526,26 @@ object
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r135179322
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/DataViewSpec.scala
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r135172148
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -759,10 +786,12 @@ object
Github user kaibozhou commented on the issue:
https://github.com/apache/flink/pull/4355
All comments addressed.
Do you have time to merge it @wuchong @fhueske ?
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user kaibozhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r135697894
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed
46 matches
Mail list logo
