[GitHub] flink pull request #3565: [FLINK-5413] [table] Convert TableEnvironmentITCas...

2017-03-18 Thread mtunique
GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/3565 [FLINK-5413] [table] Convert TableEnvironmentITCases to unit tests Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[GitHub] flink issue #3565: [FLINK-5413] [table] Convert TableEnvironmentITCases to u...

2017-03-18 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3565 @KurtYoung I sorry about it, I will change it. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #2977: Flink 5084

2016-12-09 Thread mtunique
GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/2977 Flink 5084 I replace the Java Table API ITCases by tests that check that the parsing step produces a valid logical plan. Before I delete the ITCases, I have check there are UTCases in scala

[GitHub] flink issue #2977: [FLINK-5084] Replace Java Table API integration tests by ...

2016-12-09 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/2977 Thanks @fhueske . I agree very much. It is necessary to split the tests into a validation and a plan test class. I will follow the suggestions. --- If your project is set up for it, you

[GitHub] flink issue #2977: [FLINK-5084] Replace Java Table API integration tests by ...

2016-12-12 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/2977 @fhueske I have finish there tasks: - remove `./test/java/org/apache/flink/api/java/batch/ExplainTest` - All tests in `test/java/org/apache/flink/api/java/batch/table` are implemented

[GitHub] flink pull request #3718: [FLINK-6112] Support Calcite 1.12's new numerical ...

2017-04-13 Thread mtunique
GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/3718 [FLINK-6112] Support Calcite 1.12's new numerical functions Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consider

[GitHub] flink pull request #3719: [FLINK-6303] Documentation support build in docker...

2017-04-13 Thread mtunique
GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/3719 [FLINK-6303] Documentation support build in docker on OSX Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink pull request #3720: [FLINK-6302] Documentation build error on ruby 2.4

2017-04-13 Thread mtunique
GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/3720 [FLINK-6302] Documentation build error on ruby 2.4 Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[GitHub] flink issue #3719: [FLINK-6303] Documentation support build in docker on OSX

2017-04-19 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3719 I will follow the branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink issue #3428: [FLINK-1743] Add multinomial logistic regression to machi...

2017-04-20 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3428 @thvasilo - Add `MultipleLinearRegression ` to provide interfaces for the set of common properties and functions generalized linear models share. - Change `LogisticLoss` to let it be with

[GitHub] flink issue #3428: [FLINK-1743] Add multinomial logistic regression to machi...

2017-04-20 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3428 Thanks all for the comments. The code from Spark has be labeled like some other codes from Spark. I will spilt this PR into two PRs. The other one is for FLINK-2013. --- If your project is

[GitHub] flink pull request #3756: [FLINK-2013] Create generalized linear model frame...

2017-04-22 Thread mtunique
GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/3756 [FLINK-2013] Create generalized linear model framework Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If

[GitHub] flink issue #3756: [FLINK-2013] Create generalized linear model framework

2017-04-22 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3756 Split from #3428. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #3428: [FLINK-1743] Add multinomial logistic regression to machi...

2017-04-22 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3428 @thvasilo After #3756 is merged, I will change this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3719: [FLINK-6303] Documentation support build in docker on OSX

2017-04-24 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3719 @patricklucas I have changed this PR follow #3751. In order to make the PRs clearly, the PR #3751 should just fix the issue FLINK-6330. --- If your project is set up for it, you can reply to this

[GitHub] flink pull request #3720: [FLINK-6302] Documentation build error on ruby 2.4

2017-04-25 Thread mtunique
Github user mtunique commented on a diff in the pull request: https://github.com/apache/flink/pull/3720#discussion_r113186880 --- Diff: docs/Gemfile.lock --- @@ -30,18 +30,19 @@ GEM redcarpet (~> 3.1) safe_yaml (~> 1.0) toml (~&

[GitHub] flink pull request #3720: [FLINK-6302] Documentation build error on ruby 2.4

2017-04-25 Thread mtunique
Github user mtunique commented on a diff in the pull request: https://github.com/apache/flink/pull/3720#discussion_r113186869 --- Diff: docs/Gemfile.lock --- @@ -30,18 +30,19 @@ GEM redcarpet (~> 3.1) safe_yaml (~> 1.0) toml (~&

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

2017-05-03 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3720 @StephanEwen I think it is the best way to solve this issue. I will follow the suggestion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request #3719: [FLINK-6303] Documentation support build in docker...

2017-05-09 Thread mtunique
Github user mtunique closed the pull request at: https://github.com/apache/flink/pull/3719 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #1985: [FLINK-1979] Add logistic loss, hinge loss and regulariza...

2017-02-11 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/1985 Could this PR be merged ? Maybe this PR blocks to design GLM([FLINK-2013](https://issues.apache.org/jira/browse/FLINK-2013)). --- If your project is set up for it, you can reply to this email and

[GitHub] flink pull request #3428: [FLINK-1743] Add multinomial logistic regression t...

2017-02-28 Thread mtunique
GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/3428 [FLINK-1743] Add multinomial logistic regression to machine learning library Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[GitHub] flink pull request #3463: [FLINK-5952] JobCancellationWithSavepointHandlersT...

2017-03-02 Thread mtunique
GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/3463 [FLINK-5952] JobCancellationWithSavepointHandlersTest uses deprecated JsonNode#getValuesAsText Thanks for contributing to Apache Flink. Before you open your pull request, please take the

[GitHub] flink pull request #3463: [FLINK-5952] JobCancellationWithSavepointHandlersT...

2017-03-02 Thread mtunique
Github user mtunique closed the pull request at: https://github.com/apache/flink/pull/3463 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2977: [FLINK-5084] Replace Java Table API integration tests by ...

2016-12-23 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/2977 Hi @fhueske , I have fixed the comments. Maybe you can review the changes, then I rebase the master branch and refactor the directory structure.Maybe this can be easy to review by two

[GitHub] flink pull request #3041: Flink 5084 tmp

2016-12-23 Thread mtunique
GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/3041 Flink 5084 tmp Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into

[GitHub] flink pull request #3041: Flink 5084 tmp

2016-12-23 Thread mtunique
Github user mtunique closed the pull request at: https://github.com/apache/flink/pull/3041 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2977: [FLINK-5084] Replace Java Table API integration tests by ...

2017-01-05 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/2977 @fhueske I have finished all about comments and rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink issue #2977: [FLINK-5084] Replace Java Table API integration tests by ...

2017-01-06 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/2977 @fhueske Done. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink pull request #3087: [FLINK-4917] Deprecate "CheckpointedAsynchronously...

2017-01-10 Thread mtunique
GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/3087 [FLINK-4917] Deprecate "CheckpointedAsynchronously" interface - [x] General - The pull request references the related JIRA issue ([FLINK-4917] Deprecate "Checkpointe

[GitHub] flink issue #3087: [FLINK-4917] Deprecate "CheckpointedAsynchronously" inter...

2017-01-10 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3087 I am sorry about it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink issue #3087: [FLINK-4917] Deprecate "CheckpointedAsynchronously" inter...

2017-01-11 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3087 @greghogan I have add the javadoc about replacement. Maybe `Checkpointed` has the same problem about javadoc. Fix it in this PR or create a new issue on jira? --- If your project is set up for it

[GitHub] flink pull request #3097: [FLINK-5448] Fix typo in StateAssignmentOperation ...

2017-01-11 Thread mtunique
GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/3097 [FLINK-5448] Fix typo in StateAssignmentOperation Exception Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink pull request #3098: [FLINK-5438] Typo in JobGraph generator Exception

2017-01-11 Thread mtunique
GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/3098 [FLINK-5438] Typo in JobGraph generator Exception Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[GitHub] flink pull request #3099: [FLINK-5268] Split TableProgramsTestBase into Tabl...

2017-01-12 Thread mtunique
GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/3099 [FLINK-5268] Split TableProgramsTestBase into TableProgramsCollectionTestBase and TableProgramsClusterTestBase …TestBase and TableProgramsClusterTestBase Thanks for contributing to

[GitHub] flink issue #3087: [FLINK-4917] Deprecate "CheckpointedAsynchronously" inter...

2017-01-23 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3087 Maybe we should open an issue about `Checkpointed` java doc to talk about how to replace the APIs. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request #3756: [FLINK-2013] Create generalized linear model frame...

2017-10-02 Thread mtunique
Github user mtunique commented on a diff in the pull request: https://github.com/apache/flink/pull/3756#discussion_r142308699 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/regression/MultipleLinearRegressionITSuite.scala --- @@ -75,15 +75,16 @@ class