Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3268
I added the test (which of course also required reflection) to an existing
test case. I figured that was the lesser of the two evils of requiring another
test application be deployed and hiding
Github user patricklucas closed the pull request at:
https://github.com/apache/flink/pull/3268
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user patricklucas opened a pull request:
https://github.com/apache/flink/pull/3268
[FLINK-5153] Support YARN application tags
Adds a new config option `yarn.tags`, a comma-separated list of strings
passed to YARN as application tags.
You can merge this pull request
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3268
I manually tested the behavior of this new feature as well as the other
YARN application options touched by this change with various Hadoop versions
(2.3/2.4/2.6) on a YARN cluster
GitHub user patricklucas opened a pull request:
https://github.com/apache/flink/pull/3355
[FLINK-5842] [docs] Fix ES5 "since" version
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/patricklucas/fl
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3332
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user patricklucas commented on a diff in the pull request:
https://github.com/apache/flink/pull/3332#discussion_r101786279
--- Diff: docs/check_links.sh ---
@@ -0,0 +1,36 @@
+#!/usr/bin/env bash
Github user patricklucas commented on a diff in the pull request:
https://github.com/apache/flink/pull/3332#discussion_r101678631
--- Diff: docs/check_links.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
Github user patricklucas commented on a diff in the pull request:
https://github.com/apache/flink/pull/3332#discussion_r101678241
--- Diff: docs/check_links.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
Github user patricklucas commented on a diff in the pull request:
https://github.com/apache/flink/pull/3332#discussion_r101678217
--- Diff: docs/check_links.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
GitHub user patricklucas opened a pull request:
https://github.com/apache/flink/pull/3329
[FLINK-5751] Fix some broken links in docs
I used a wget-based script to identify broken links then manually searched
and corrected as many as I found.
You can merge this pull request
GitHub user patricklucas opened a pull request:
https://github.com/apache/flink/pull/3618
[FLINK-6194] [docs] Fix broken links
Fix automatically-identified broken links in docs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user patricklucas opened a pull request:
https://github.com/apache/flink/pull/3658
[hotfix] [docs] Remove empty Docker docs page
This will be re-added when we have a coherent plan for Docker support
and after the official Docker images are available.
You can merge
GitHub user patricklucas opened a pull request:
https://github.com/apache/flink/pull/3751
[FLINK-6330] [docs] Add basic Docker, K8s docs
I may do some more work on these before 1.2.2/1.3, but I'd like to at least
get this basic information into master.
You can merge this pull
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3719
Thanks for the PR @mtunique! I actually ran into this today and have a fix
[in a
branch](https://github.com/patricklucas/flink/tree/FLINK-6330_improve_docker_docs)
that I will hopefully open
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3686
@fpompermaier FYI your author email address on this commit was
"f.pomperma...@gmai.com" (missing 'l'). You might have a typo in your gitconfig?
---
If your project is set up for i
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3734
Great, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user patricklucas opened a pull request:
https://github.com/apache/flink/pull/3734
[FLINK-6300] Use 'exec' in start-foreground calls
To avoid signal-handling issues in Docker, applications need to run as
a single executable or use a process manager that forwards signals
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3734
cc @greghogan, fyi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3734
@greghogan do you think you could merge this? (also to 1.2.1)
If not I can try to rope in someone else.
---
If your project is set up for it, you can reply to this email and have your
Github user patricklucas commented on a diff in the pull request:
https://github.com/apache/flink/pull/3494#discussion_r104979246
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -36,22 +31,24 @@ ENV PATH $PATH:$FLINK_HOME/bin
EXPOSE 8081
EXPOSE 6123
Github user patricklucas commented on a diff in the pull request:
https://github.com/apache/flink/pull/3494#discussion_r104982158
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -36,22 +31,24 @@ ENV PATH $PATH:$FLINK_HOME/bin
EXPOSE 8081
EXPOSE 6123
Github user patricklucas commented on a diff in the pull request:
https://github.com/apache/flink/pull/3494#discussion_r104986831
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -36,22 +31,24 @@ ENV PATH $PATH:$FLINK_HOME/bin
EXPOSE 8081
EXPOSE 6123
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3493
Since this PR is no longer directly related to publishing official Docker
images, could you change its title? (See my reply to your comment on #3494)
---
If your project is set up for it, you
Github user patricklucas commented on a diff in the pull request:
https://github.com/apache/flink/pull/3494#discussion_r105119473
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -36,22 +31,24 @@ ENV PATH $PATH:$FLINK_HOME/bin
EXPOSE 8081
EXPOSE 6123
GitHub user patricklucas opened a pull request:
https://github.com/apache/flink/pull/3494
[FLINK-5635] [docker] Improve Docker tooling
This PR supplants and extends @jgrier's #3205, updating with master, fixing
merge conflicts, making use of the new `start-foreground` param
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3494
cc @ex00 @tonycox @iemejia
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3493
I've opened my PR, #3494.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3493
Aha, I see. I didn't follow the chain up further. :)
Then yes, I'm generally on board with following this convention.
---
If your project is set up for it, you can reply to this email
Github user patricklucas commented on a diff in the pull request:
https://github.com/apache/flink/pull/3494#discussion_r104912987
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -36,22 +31,24 @@ ENV PATH $PATH:$FLINK_HOME/bin
EXPOSE 8081
EXPOSE 6123
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3351
I fixed the merge conflicts and some indentation here:
https://github.com/patricklucas/flink/tree/FLINK-4326_start_in_foreground
If you update your PR with those changes, hopefully we
GitHub user patricklucas opened a pull request:
https://github.com/apache/flink/pull/3492
[FLINK-4326] [scripts] Flink foreground services
This PR consists of @greghogan's commits from #3351 with the merge
conflicts fixed.
If merged, this PR supplants #3351, which can
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3204
I vote to close this issue since #3492 has been merged/FLINK-4326 has been
resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3493
Thanks @iemejia. I have a branch building on @jgrier's commits from #3205
which I hope to push before any further changes are made. Hopefully I can get
it done today.
---
If your project
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3493
I took a look through the [top official
Docker](https://hub.docker.com/explore/) repos to see what variants they
provide, and the first-listed Java-based project is
[Elasticsearch](https
GitHub user patricklucas opened a pull request:
https://github.com/apache/flink/pull/4299
[FLINK-7155] [metrics] Add Influxdb reporter
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/patricklucas/flink
FLINK
Github user patricklucas commented on a diff in the pull request:
https://github.com/apache/flink/pull/4299#discussion_r126742051
--- Diff: flink-metrics/flink-metrics-influxdb/pom.xml ---
@@ -0,0 +1,97 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="
Github user patricklucas commented on a diff in the pull request:
https://github.com/apache/flink/pull/4299#discussion_r126742152
--- Diff: flink-metrics/flink-metrics-influxdb/pom.xml ---
@@ -0,0 +1,97 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3751
It will be available before the next release, though I noticed just
yesterday that it seems we build the [official 1.2
docs](https://ci.apache.org/projects/flink/flink-docs-release-1.2
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3719
Here's the PR: #3751
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3751
@greghogan we're waiting patiently for @tianon to complete his review of
docker-library/official-images#2895. :)
As far as I know, we've done everything we need to do to get the images
Github user patricklucas commented on a diff in the pull request:
https://github.com/apache/flink/pull/3751#discussion_r115753699
--- Diff: docs/page/css/syntax.css ---
@@ -77,3 +77,6 @@
.highlight .vg { color: #008080 } /* Name.Variable.Global */
.highlight .vi { color
GitHub user patricklucas opened a pull request:
https://github.com/apache/flink/pull/3887
[hotfix] [docs] Fix link to docker-compose.yml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/patricklucas/flink
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3751
The link is available now!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user patricklucas opened a pull request:
https://github.com/apache/flink/pull/5380
[hotfix][connectors] Fix log format strings
Log4j uses '{}' instead of '%s' for interpolating values, meaning these
logging statements currently result in log entries with the literal string
GitHub user patricklucas opened a pull request:
https://github.com/apache/flink/pull/6396
[FLINK-9806][docs] Add canonical link element to docs
## What is the purpose of the change
Flink's documentation's SEO is a mess, with web searches often returning
results from many
GitHub user patricklucas opened a pull request:
https://github.com/apache/flink/pull/6402
[FLINK-9914][docs] Update Docker docs
## What is the purpose of the change
Clarify the Docker-related docs for current releases.
You can merge this pull request into a Git repository
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/6396
The "hotfix" was a necessary modification to the dev-only helper scripts
for building the docs locally. I assumed that it would just get squashed into
the main commit when being merg
48 matches
Mail list logo
