[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-26 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/319#discussion_r23526978 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -329,6 +330,15 @@ public void unregisterMemoryManager

[GitHub] flink pull request: [Flink-1436] refactor CLiFrontend to provide m...

2015-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/331#issuecomment-71467375 I think it would be better not to print the help if the user specified something incorrectly. Maybe just the error message and a note that -h prints the help

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-26 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/319#discussion_r23526836 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/SlotSharingGroupAssignment.java --- @@ -42,86 +44,82 @@ public

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-26 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/319#discussion_r23526787 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/SlotAvailabilityListener.java --- @@ -21,7 +21,7 @@ import

[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...

2015-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71464164 -1 I think we need to add the `build-target` directory into the list of ignored directories for apache rat. Rat will fail subsequent builds ``` 1 Unknown

[GitHub] flink pull request: [FLINK-1391] Add support for using Avro-POJOs ...

2015-01-26 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-1437][Java API] Fixes copy() methods in...

2015-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/342#issuecomment-71475896 This will probably conflict with https://github.com/apache/flink/pull/316. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1392] Add Kryo serializer for Protobuf

2015-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/322#issuecomment-71484526 I will make this change part of a new pull request for https://issues.apache.org/jira/browse/FLINK-1417. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...

2015-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71469736 Oh, actually, that should work because the configuration explicitly binds the plugin to the clean phase. --- If your project is set up for it, you can reply

[GitHub] flink pull request: Qa bot

2015-02-04 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/362#issuecomment-72886592 Sorry guys, I was confused with the different repositories. I'll close it again. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-592] Add support for Kerberos secured Y...

2015-02-04 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/358#issuecomment-72937500 Thank you. Thats good to hear. On 04.02.2015, at 21:56, Daniel Warneke notificati...@github.com wrote: Tested the code and everything works

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-02-02 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/202#issuecomment-72533930 Wordcount with build-in data works :+1: nice. ``` robert@robert-tower ...k-0.9-SNAPSHOT-bin/flink-0.9-SNAPSHOT (git)-[papipr] % ./bin/pyflink3.sh pyflink.py

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-02-02 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/202#discussion_r23952693 --- Diff: flink-addons/flink-language-binding/src/main/python/org/apache/flink/languagebinding/api/python/dill/__diff.py --- @@ -0,0 +1,247

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-02-02 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/202#issuecomment-72526181 I've tested the changes again, because I would really like to merge them The bin/pyflink3.sh script only works when called from the flink root dir

[GitHub] flink pull request: [FLINK-1105] Add support for locally sorted ou...

2015-02-02 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/347#discussion_r23914605 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/DataSink.java --- @@ -83,6 +93,107 @@ public DataSink(DataSetT data, OutputFormatT

[GitHub] flink pull request: [FLINK-1105] Add support for locally sorted ou...

2015-02-02 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/347#issuecomment-72430165 The change is good to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons (...

2015-02-07 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/335#issuecomment-73366441 I'm really sorry that I've messed up this pull request by renaming flink-addons to flink-staging :( I was doing it in a rush Really sorry. --- If your project

[GitHub] flink pull request: [FLINK-592] Add support for Kerberos secured Y...

2015-02-03 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/358 [FLINK-592] Add support for Kerberos secured YARN setups to Flink. This pull request is basically a port of @warneke's branch (https://github.com/warneke/flink/tree/security) to the latest `master

[GitHub] flink pull request: [Discuss] Simplify SplittableIterator interfac...

2015-02-04 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/338 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [Discuss] Simplify SplittableIterator interfac...

2015-02-04 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/338#issuecomment-72861601 Resolved in http://git-wip-us.apache.org/repos/asf/flink/commit/7ac6447f. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-592] Add support for Kerberos secured Y...

2015-02-04 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/358#issuecomment-72856331 Thank you for the good feedback! @mxm and I updated the pull request and addressed your concerns. I'm now running the tests on Travis. If they pass I'm going

[GitHub] flink pull request: [FLINK-1471][java-api] Fixes wrong input valid...

2015-02-04 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/359#discussion_r24085204 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java --- @@ -680,10 +680,20 @@ private static void validateInputType

[GitHub] flink pull request: yarn client tests

2015-02-05 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/134#issuecomment-73047820 Yes, the changes here have been subsumed by FLINK-883. @skunert can you close this pull request? --- If your project is set up for it, you can reply

[GitHub] flink pull request: Port FLINK-1391 and FLINK-1392 to release-0.8...

2015-02-05 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/364 Port FLINK-1391 and FLINK-1392 to release-0.8 branch. These commits port the fixes for the two issues (Avro and Protobuf support) to the release-0.8 branch. They also contain a hotfix regarding

[GitHub] flink pull request: [FLINK-1166] Add qa-check.sh tool

2015-02-05 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/366#issuecomment-73089829 Thank you for trying it out. Ideally, with the bot in place the number of warnings will go down over time. I'll address the comments in the source

[GitHub] flink pull request: [FLINK-1166] Add qa-check.sh tool

2015-02-05 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/366#issuecomment-73084319 Its not completely building flink, its only generating javadocs or compiling for getting the compiler warnings. The main purpose of the script is to be executed

[GitHub] flink pull request: [FLINK-1166] Add qa-check.sh tool

2015-02-06 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/366#issuecomment-73254306 I found out why the qa-check has more compile errors compared to the master: I've instructed the compiler to report them all ;) I've addressed all comments

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-02-03 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/354 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: Allow KeySelectors to implement ResultTypeQuer...

2015-02-03 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/354#issuecomment-72620298 I'll close it. I've filed a jira for the issue and assigned it to @twalthr: https://issues.apache.org/jira/browse/FLINK-1471 --- If your project is set up

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-02-02 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/202#discussion_r23950076 --- Diff: docs/python_programming_guide.md --- @@ -0,0 +1,600 @@ +--- +title: Python Programming Guide +--- +!-- +Licensed to the Apache

[GitHub] flink pull request: [FLINK-1478] Add support for strictly local in...

2015-02-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/375#issuecomment-73477321 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1179] Add button to JobManager web inte...

2015-02-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/374#issuecomment-73478511 I've tried it out locally. Looks very nice. Thank you. +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-14 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/304#discussion_r22968592 --- Diff: flink-java/pom.xml --- @@ -64,6 +64,18 @@ under the License. version0.5.1/version /dependency

[GitHub] flink pull request: [FLINK-1398] Introduce extractSingleField() in...

2015-01-14 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/308#issuecomment-69976328 +1 for some utilities. I'm not sure however where to put it. Should we add another maven module? Make it part of the current flink-java ? Or start it as a github

[GitHub] flink pull request: Add support for Subclasses, Interfaces, Abstra...

2015-01-15 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/236#issuecomment-70095528 I would like to have this merged soon. It contains some good changes to the TypeExtractor (support for interfaces abstract classes) --- If your project is set up

[GitHub] flink pull request: [FLINK-1147][Java API] TypeInference on POJOs

2015-01-20 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/315#issuecomment-70723442 I didn't find any issues in the code. Good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons

2015-01-20 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/326#discussion_r23252081 --- Diff: flink-addons/flink-gelly/src/main/java/org/apache/flink/gelly/Edge.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request: [FLINK-1392] Add Kryo serializer for Protobuf

2015-01-19 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/322 [FLINK-1392] Add Kryo serializer for Protobuf I've checked the added dependencies and its not overriding any versions and no transitive dependencies are added. You can merge this pull request

[GitHub] flink pull request: [FLINK-1382][java] Adds the new basic types Vo...

2015-01-16 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/299#issuecomment-70226685 The change looks good. I would like to see some test cases there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-16 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/311#issuecomment-70226947 How about names along the lines of Unmodified Fields ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-16 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/311#discussion_r23069617 --- Diff: flink-compiler/src/main/java/org/apache/flink/compiler/dag/BinaryUnionNode.java --- @@ -266,4 +268,44 @@ public void computeOutputEstimates

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-16 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/311#discussion_r23069937 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/functions/SemanticPropUtil.java --- @@ -40,38 +45,108 @@ import

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-16 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/311#discussion_r23070438 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java --- @@ -45,6 +46,16 @@ */ public class PojoTypeInfoT

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-16 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/311#discussion_r23070841 --- Diff: flink-compiler/src/main/java/org/apache/flink/compiler/dag/BinaryUnionNode.java --- @@ -266,4 +268,44 @@ public void computeOutputEstimates

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-16 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/311#issuecomment-70230559 Except for the comments and the missing documentation, the change looks good. I can however not really validate the changes in the optimizer. --- If your project

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-16 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/304#discussion_r23071236 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/KryoSerializer.java --- @@ -185,6 +187,8 @@ private void checkKryoInitialized

[GitHub] flink pull request: [FLINK-1395] Add support for JodaTime in KryoS...

2015-01-16 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/304#issuecomment-70231876 Change looks good except for comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-1406] update Flink compatibility notice

2015-01-16 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/314#issuecomment-70234048 Good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1382][java] Adds the new basic types Vo...

2015-01-16 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/299#issuecomment-70269761 Oh, yes .. sorry. I need to be more careful when reviewing pull requests. +1 to merge this. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-1183] Generate gentle notification mess...

2015-01-15 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/296#issuecomment-70090914 I think its fine to just merge it to the release-0.8 branch It will then automatically go into 0.8.1. I'll create a version in JIRA On Thu, Jan 15, 2015

[GitHub] flink pull request: [FLINK-1295][FLINK-883] Allow to deploy 'job o...

2015-01-21 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/292#discussion_r23292258 --- Diff: flink-yarn/src/main/scala/org/apache/flink/yarn/ApplicationMaster.scala --- @@ -41,9 +41,9 @@ object ApplicationMaster{ val

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons

2015-01-20 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/326#discussion_r23248831 --- Diff: flink-addons/flink-gelly/src/test/java/org/apache/flink/gelly/test/TestWeaklyConnected.java --- @@ -0,0 +1,143 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons

2015-01-20 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/326#issuecomment-70717064 Great, I'm super excited to see the graph API being offered to the main project. I'll start reviewing the code right away, to merge it as soon as possible

[GitHub] flink pull request: [FLINK-1372] [runtime] Fixes Akka logging

2015-01-21 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/329#issuecomment-70856935 Good to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: Release 0.8 Preparations

2015-01-18 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/294#issuecomment-70418596 The changes have been merged to 0.8 and master (except for FLINK-1385, but this fix needs to be implemented differently for master. I'll do that as part of my yarn pull

[GitHub] flink pull request: Release 0.8 Preparations

2015-01-18 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/294 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-1295][FLINK-883] Allow to deploy 'job o...

2015-01-18 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/292#issuecomment-70416726 Thank you for the feedback. I'll address the inline comments. Regarding the questions: 1. The separation between `flink-yarn` and `flink-yarn-tests` exists

[GitHub] flink pull request: [FLINK-1399] Add support for registering Seria...

2015-01-18 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/305#issuecomment-70424921 Maybe we should offer users both options: register and default serializer. In some cases, you don't know the exact types and you want to go for a default serializer

[GitHub] flink pull request: [FLINK-1504] support for secure HDFS access us...

2015-02-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/383#issuecomment-73912267 Looks good to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1504] support for secure HDFS access us...

2015-02-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/383#issuecomment-73916367 Rebased to master: https://github.com/rmetzger/flink/tree/kerberos_hdfs --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1510] Make AvroInputFormat splittable

2015-02-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/382#issuecomment-73917179 I'm closing the PR until I've added tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: support for secure HDFS access using kerberos

2015-02-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/383#issuecomment-73910366 https://issues.apache.org/jira/browse/FLINK-1504 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-1510] Make AvroInputFormat splittable

2015-02-11 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/382 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-1489] Fixes blocking scheduleOrUpdateCo...

2015-02-11 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/378#issuecomment-73911265 The job that was previously failing is fixed with this change. We should merge this change ASAP, because its kinda impossible right now to seriously use flink

[GitHub] flink pull request: [FLINK-1417] Automatically register types with...

2015-02-18 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/393#issuecomment-74833886 I would like to merge this pull request soon. @aljoscha, do you agree that we can investigate the performance for the PojoComparator also when the change is merged

[GitHub] flink pull request: [FLINK-1417] Automatically register types with...

2015-02-18 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/393#issuecomment-74843995 Yes. First we need to understand why exactly the performance is so poor. Maybe its an issue we can easily fix. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-947] Add a declarative expression API

2015-02-18 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/405#issuecomment-74832989 One more thing, the maven module is called flink-linq. Are we certain that we can use the name LINQ without problems here? --- If your project is set up for it, you can

[GitHub] flink pull request: [FLINK-1461][api-extending] Add SortPartition ...

2015-02-12 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/381#issuecomment-74120225 Looks good to me (I'm uncertain regarding the optimizer changes) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-1508] Removes AkkaUtil.ask

2015-02-12 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/384#issuecomment-74119549 I vote to merge this quickly and fix issues as they appear. The change touches a lot of different parts of the code and is predestined to become unmergeable quickly

[GitHub] flink pull request: [FLINK-1391] Register common Avro types at Kry...

2015-02-12 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/386 [FLINK-1391] Register common Avro types at Kryo You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink kryo081-2 Alternatively you can

[GitHub] flink pull request: [FLINK-1522][gelly] Added test for SSSP Exampl...

2015-02-17 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/414#discussion_r24829996 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/SingleSourceShortestPathsExample.java --- @@ -56,4 +63,77 @@ public static

[GitHub] flink pull request: [FLINK-1466] Add HCatInputFormats to read from...

2015-02-17 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/411#discussion_r24833839 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatInputFormatBase.java --- @@ -0,0 +1,413 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-1545] Fixes AsynchronousFileIOChannelsT...

2015-02-15 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/399#issuecomment-74414666 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request: [FLINK-947] Add a declarative expression API

2015-02-17 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/405#discussion_r24858527 --- Diff: docs/linq.md --- @@ -0,0 +1,65 @@ +--- +title: Language-Integrated Queries +--- +!-- +Licensed to the Apache Software Foundation

[GitHub] flink pull request: [FLINK-1549] Adds proper exception handling to...

2015-02-15 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/397#issuecomment-74414852 Changes look good. Thank you for taking care of this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [FLINK-1589] Add option to pass configuration ...

2015-02-20 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/427 [FLINK-1589] Add option to pass configuration to LocalExecutor Please review the changes. I'll add a testcase and update the documentation later today. You can merge this pull request

[GitHub] flink pull request: [FLINK-1589] Add option to pass configuration ...

2015-02-20 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/427#issuecomment-75244751 I've added documentation and tests to the change. Lets see if travis gives us a green light. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-1466] Add HCatInputFormats to read from...

2015-02-18 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/411#issuecomment-74895705 Cool. Then I think the change is good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-1501] Add metrics library for monitorin...

2015-02-19 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/421 [FLINK-1501] Add metrics library for monitoring TaskManagers Hey, I've spend some time exploring the [metrics](https://dropwizard.github.io/metrics/3.1.0/) library for improving

[GitHub] flink pull request: Add auto-parallelism to Jobs (0.8 branch)

2015-02-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/410#issuecomment-74638095 Cool. Lets merge this also to master and document it there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-1417] Automatically register types with...

2015-02-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/393#issuecomment-74665100 Thank you for reviewing the pull request. I've addressed your remark, added a fix for another issue (FLINK-1567) and now I'll run the performance tests

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-01-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/202#issuecomment-71612618 @dan-blanchard What non-JVM language are you looking for? Maybe we can do a little prototype with that language to see how well it works. Maybe you or somebody else

[GitHub] flink pull request: [FLINK-1328] Reworked semantic annotations

2015-01-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/311#issuecomment-71613018 +1 for merging it Whats the plan with the documentation? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...

2015-01-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71610034 In addition to that, we should probably investigate why the clean phase is not removing the directory. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-1457] exclude avro test file from RAT c...

2015-01-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/345#issuecomment-71656804 Good to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1433] Add HADOOP_CLASSPATH to start scr...

2015-01-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/337#issuecomment-71631049 Merging it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: FLINK-1452: Rename 'flink-addons' to 'flink-st...

2015-01-30 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/355 FLINK-1452: Rename 'flink-addons' to 'flink-staging'; add 'flink-contrib' You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink

[GitHub] flink pull request: [FLINK-1376] [runtime] Add proper shared slot ...

2015-01-31 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/317#issuecomment-72319309 Okay, I'll file a JIRA --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...

2015-01-25 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/301#issuecomment-71366256 The only reason why I added the two variants is that I want to give users freedom to choose between these two variants. Its one more line of code that might (someday

[GitHub] flink pull request: [FLINK-1434] [FLINK-1401] Streaming support ad...

2015-01-25 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/334#discussion_r23503538 --- Diff: flink-addons/flink-streaming/flink-streaming-core/pom.xml --- @@ -48,6 +48,12 @@ under the License. version${project.version

[GitHub] flink pull request: [FLINK-1434] [FLINK-1401] Streaming support ad...

2015-01-25 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/334#discussion_r23503540 --- Diff: flink-addons/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/StreamGraph.java --- @@ -536,4 +549,79 @@ public

[GitHub] flink pull request: [FLINK-1295][FLINK-883] Allow to deploy 'job o...

2015-01-26 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/292 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...

2015-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/301#issuecomment-71439040 You are right, I should have made the requirements clear in the beginning. I actually had a discussion with the user which approach is the best. I took the view

[GitHub] flink pull request: [Discuss] Simplify SplittableIterator interfac...

2015-01-26 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/338 [Discuss] Simplify SplittableIterator interface While working on something, I found the SplittableIterator interface unnecessary complicated. Let me know if you agree to merge

[GitHub] flink pull request: [FLINK-1433] Add HADOOP_CLASSPATH to start scr...

2015-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/337#issuecomment-71429315 It depends on what the user does with the `HADOOP_CLASSPATH`. In my understanding, it is meant as a variable for adding 3rd party jar files to Hadoop. The jar files

[GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...

2015-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/301#issuecomment-71432009 I've completely changed the mechanism of setting a custom file name. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...

2015-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/301#issuecomment-71434721 The user who requested this feature actually asked for a custom method to overwrite. There is one more important use-case for a custom method: If users want

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons (...

2015-01-25 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/335#issuecomment-71376640 Thank you. Looks good. History is preserved and you addressed my comments. +1 for merging it. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-1433] Add HADOOP_CLASSPATH to start scr...

2015-01-25 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/337 [FLINK-1433] Add HADOOP_CLASSPATH to start scripts You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink FLINK-1433 Alternatively you

[GitHub] flink pull request: [Flink-1436] refactor CLiFrontend to provide m...

2015-01-25 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/331#issuecomment-71376859 @mxm: Since you have some experience with the CliFrontend now, would you mind looking into https://issues.apache.org/jira/browse/FLINK-1424 as well? --- If your project

  1   2   3   4   5   6   7   8   9   10   >