Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2260
@rmetzger Sure, that would be great. Thanks for your help with merging this.
Thanks for your contribution @chadnickbok :)
---
If your project is set up for it, you can reply to this email and
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2369#discussion_r75569347
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2369#discussion_r75569873
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka010Fetcher.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2369#discussion_r75571320
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer010.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2369#discussion_r75571478
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer010.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2369#discussion_r75572212
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer010.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2369#discussion_r75572263
--- Diff: docs/apis/streaming/connectors/kafka.md ---
@@ -291,3 +301,35 @@ higher value.
There is currently no transactional producer for Kafka, so
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2369
Left a few comments on some high-level design choices for a first review.
Mostly on `FlinkKafkaProducer010`, I wonder if there are other better
possibilities over there?
---
If your project is
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/2414
[FLINK-4341] Let idle consumer subtasks emit max value watermarks and fail
on resharding
This is a short-term fix, until the min-watermark service for the
JobManager described in the JIRA
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2416
Hi @smarthi,
Thank you for picking this up. The changes LGTM :) Also tested the 2.3.5 ES
version bump.
Good catches on the Guava and broken example also!
---
If your project is set up for
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2414
Ah yes, correct. I'll update this soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2369#discussion_r76264614
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer010.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2369#discussion_r76268268
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer010.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2369#discussion_r76268687
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer010.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2369#discussion_r76274826
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka010Fetcher.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2369#discussion_r76275805
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/SimpleConsumerThread.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2369#discussion_r76275879
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2369#discussion_r76277062
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/internals
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2369
Thanks Robert for addressing my comments :)
Overall, I like the new hybrid producer approach. However, I'm still
curious whether or not it is possible / reasonable to dro
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2414
To include the missing case @rmetzger mentioned, it turns out the fix is
actually more complicated than I expected due to correct state determination
after every reshard, and requires a bit of
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2414
@rmetzger, @aljoscha the changes are ready for another review now, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2414
Thanks @rmetzger !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/2432
[FLINK-4514][kinesis-connector] Handle unexpected ExpiredIteratorExceptions
Handle any unexpected {{ExpiredIteratorException}}s on {{getRecords()}}
calls be refreshing the failing shard iterator
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2432
@rmetzger I know it might be a bit of a rush, but could you have a quick
look at this too?
It's not a critical blocker, but might as well would be good to make it
into the 1.1.2 patch f
Github user tzulitai commented on the pull request:
https://github.com/apache/flink/commit/7b574cf5b6e7549ae53ea0846022c4430a979a01#commitcomment-18811598
From the original Kinesis consumer documentation, I don't think it's
necessary to mention this, because there's
Github user tzulitai commented on the pull request:
https://github.com/apache/flink/commit/7b574cf5b6e7549ae53ea0846022c4430a979a01#commitcomment-18811645
AFAIK, the original issue reporters set the parallelism to the number of
Kinesis shards because they realized only then will the
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2432
I think it'll also make sense to limit the config setting
`ConsumerConfigConstants.SHARD_GETRECORDS_INTERVAL_MILLIS` to be lower than the
shard iterator expire time, otherwise the shard ite
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2432
The latest commit sets the check to be less than 5 minutes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2432#discussion_r76620194
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2432
Max seems to have just hotfixed the failing flink-mesos tests.
Rebasing this PR on latest master. Merging this once Travis turns green.
I'll open a separate JIRA to improve the fetch int
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2432
Thanks for the confirmation.
The build will probably fail again due to an unused import:
https://travis-ci.org/tzulitai/flink/jobs/156191304, which was just hotfixed,
so we need to rebase again
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2432
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/2470
[FLINK-4559][kinesis-connector] Fix AWSUtil.getCredentialsProvider() to not
return null
Let `AWSUtil#getCredentialsProvider` return a
`DefaultAWSCredentialsProviderChain` instead of `null` when
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2470
Thanks for the review @greghogan.
I think it makes sense to let `AUTO` be the default, as the usual use case
for most AWS users is to auto-detect the credentials delivered to instances by
AWS&#
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2470
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/1962
Thanks @HungUnicorn, thats useful info. I wonder though if this config
should be set by the user, instead of letting the connector internally set this.
---
If your project is set up for it, you
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/2509
[FLINK-4280][kafka-connector] Explicit start position configuration for
Kafka Consumer
This PR adds the following new explicit setter methods to configure the
starting position for the Kafka
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2452
Sorry for chiming in late. Left some comments on the ML thread.
Overall I think it's ok to switch focus on supporting 1.0+ Storm versions
only.
---
If your project is set up for it, yo
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2369
Looks like we need to rebase this PR on the recently merged Kerberos
support.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2369
@cjstehno I would expect this to be in the 1.2.0 major release, which would
probably be ~2 months from now according to Flink's past release cycle. The
Flink community usually doesn't rel
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3505
[backport-1.2] [FLINK-6006] [kafka] Always use complete restored state in
FlinkKafkaConsumer
(This PR is the fix of FLINK-6006 for Flink 1.2)
Previously, the Kafka Consumer performs
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3507
[FLINK-6006] [kafka] Always use complete restored state in
FlinkKafkaConsumer
(This PR is the fix of FLINK-6006 for Flink 1.1)
Previously, the Kafka Consumer performs partition list
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3508
R: @aljoscha @StefanRRichter
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3508
[FLINK-5991] [state-backend, streaming] Expose Broadcast Operator State
This PR exposes broadcast operator state through the `CheckpointedFunction`
interface, by adding broadcast state access
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2687
Rebased on the latest Kafka consumer changes in `master`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3517
[FLINK-6025] [core] Add Flink's own JavaSerializer for Kryo serialization
(This PR should also be backported for `release-1.1` and `release-1.2`.
Separate PRs are not opened for the back
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3518
[backport-1.2] [FLINK-6025] [core] Add Flink's own JavaSerializer for Kryo
serialization
This is a backport of #3517 for `release-1.2`.
You can merge this pull request into a Git reposito
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3519
[backport-1.1] [FLINK-6025] [core] Add Flink's own JavaSerializer for Kryo
serialization
This is a backport of #3518 for `release-1.1`.
You can merge this pull request into a Git reposito
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2687#discussion_r105687880
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -558,11
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2687#discussion_r105688259
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -558,11
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3527
[FLINK-3398] [kafka] Allow disabling offset committing for
FlinkKafkaConsumer
This PR allows users to completely disable offset committing back to Kafka.
The way configuration works
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3517
Thank you for the reviews @rmetzger! I'll proceed to merge this and the
backport PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2687
Thanks for the fast reviews :-) Merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3528
[FLINK-5949] [yarn] Don't check Kerberos credentials for non-Kerberosâ¦
Additionally uses the `UserGroupInformation#getAuthenticationMethod()` to
determine whether `KERBEROS` is use
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3505#discussion_r105860279
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3505#discussion_r105860440
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -489,16
Github user tzulitai closed the pull request at:
https://github.com/apache/flink/pull/3518
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3518
Thanks for the reminder :-D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user tzulitai closed the pull request at:
https://github.com/apache/flink/pull/3519
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3505
Merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3528
Thanks for the review :-)
Failing tests seem to be something instable with Maven.
Merging this to `master` and `release-1.2` ..
---
If your project is set up for it, you can reply to this
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3527
Did a final test run on a Kafka installation, and things worked as expected.
One minor improvement would be to add logs for what exactly the commit mode
is used when it is determined in `open
Github user tzulitai closed the pull request at:
https://github.com/apache/flink/pull/3505
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3507
Doing another Travis run locally before merging just to be safe:
https://travis-ci.org/tzulitai/flink/builds/211031758
---
If your project is set up for it, you can reply to this email and have
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3507
Merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user tzulitai closed the pull request at:
https://github.com/apache/flink/pull/3507
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3549
[FLINK-5701] [kafka] FlinkKafkaProducer should check asyncException on
checkpoints
This is a backport of FLINK-5701 for `release-1.1`.
The added tests are identical to #3278, with only
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3549#discussion_r106221523
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBase.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3549#discussion_r106221979
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBase.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3549#discussion_r106222066
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBase.java
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3549
Thanks for the review!
Travis is green (local branch), with only test timeouts:
https://travis-ci.org/tzulitai/flink
Merging this ..
---
If your project is set up for it, you can
Github user tzulitai closed the pull request at:
https://github.com/apache/flink/pull/3549
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3458
@StephanEwen yes, I think that would be nice. I'll try to reach out to some
of the Kinesis Flink users I know of.
---
If your project is set up for it, you can reply to this email and have
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3508
Nice following the discussion here :)
I think I'm also leaning a bit more towards naming it `UnionListState`.
From the user's prospective, it seems to be more clearer if the n
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3562
+1 to the rename. I was thinking the same here :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3562#discussion_r106776351
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -162,22 +176,422 @@ protected
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3562#discussion_r106776283
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -162,22 +176,422 @@ protected
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3562#discussion_r106776232
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -82,13 +90,19 @@
import static
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3562#discussion_r106776337
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -162,22 +176,422 @@ protected
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3562#discussion_r106776326
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -162,22 +176,422 @@ protected
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3562#discussion_r106776607
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -162,22 +176,422 @@ protected
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3562#discussion_r106775966
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -162,22 +176,422 @@ protected
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3562#discussion_r106776304
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -162,22 +176,422 @@ protected
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3562#discussion_r106776621
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -162,22 +176,422 @@ protected
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3562#discussion_r106776349
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -162,22 +176,422 @@ protected
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3562#discussion_r106776563
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -162,22 +176,422 @@ protected
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3562#discussion_r106776658
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -162,22 +176,422 @@ protected
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3562#discussion_r106776518
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -162,22 +176,422 @@ protected
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3562
@aljoscha I've been trying out this PR to also test some Kryo behaviours. I
can address the above comments along the way and open a PR against this one :-)
---
If your project is set up f
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3582
[FLINK-6139] [doc] Documentation for running Flink with MapR
Includes how to properly build Flink & setup job client to be able to run
Flink on YARN with a MapR cluster.
You can merge this
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3556
Thanks for the fix, LGTM.
@rmetzger could you proceed to merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3587#discussion_r107450020
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
---
@@ -138,7 +138,7
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3587
Thanks a lot for addressing my comments @aljoscha!
That's so much cleaner now :-D Really like the refactoring in the fixes.
I actually didn't realize the mock stubs and util me
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3587#discussion_r107506662
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
---
@@ -122,6 +121,19
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3562
Here's my follow-up fixes for this:
https://github.com/tzulitai/flink/tree/FLINK-6018
It also includes a rebase for the merge conflict + test fixes.
We can continue with this
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3562
@aljoscha sure, I'll do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3603
[FLINK-6018] Add tests for KryoSerializer restore with registered types
(This PR is a re-opened version of #3562, including @aljoscha's initial
work and my follow-up fixes. The below descri
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3562
Done. Re-opened at #3603.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3587
Thanks a lot for the extra pair of eyes on this @kl0u!
I can fix the typo and proceed to merge this to `master` and `release-1-2`.
---
If your project is set up for it, you can reply to this
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3587
Merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
1 - 100 of 1930 matches
Mail list logo
