Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2084
I think the Kinesis connector is missed out as part of this cleanup. Thanks
for this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2084
Oops, my mistake again ;) Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2084
Ah right, sorry I was mistaken by the guava dependency in pom.xml. The
dependency can actually be safely removed also though, must have accidentally
left it there when the connector was cleaned up
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/2081
[FLINK-4020][streaming-connectors] Move shard list querying to open() for
Kinesis consumer
Remove shard list querying from the constructor, and let all subtasks
independently discover which
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/2071
[FLINK-4018](streaming-connectors) Configurable idle time between
getRecords requests to Kinesis shards
Along with this new configuration and the already existing
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/1962
Hi @sbcd90,
Sorry for the late reply, as I'm currently busy some other things. I'll be
happy to help review again within the next 2~3 days.
---
If your project is set up for it, you can reply
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2081
Hi @rmetzger,
Thanks for letting me know. However, I'd like to close this PR for now for
the following reasons:
1. The new shard-to-subtask assignment logic introduced with this change
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1962#discussion_r66385603
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1962#discussion_r66385681
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1962#discussion_r66388492
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1962#discussion_r66388796
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1962#discussion_r66388852
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/1962
Hi @sbcd90,
Gave the changes a quick review and commented. please let me know your
opinion on them. Hope they'll be helpful to get you going.
---
If your project is set up for it, you can
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2131
The ManualExactlyOnceTest and ManualExactlyOnceWithStreamReshardingTest is
a bit buggy, fixing with a follow-up commit ...
---
If your project is set up for it, you can reply to this email
Github user tzulitai closed the pull request at:
https://github.com/apache/flink/pull/2081
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/2131
[FLINK-3231][streaming-connectors] FlinkKinesisConsumer rework to handle
Kinesis resharding
This change attempts to solve 2 issues:
1. [FLINK-3231](https://issues.apache.org/jira/browse/FLINK
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2081
Hi @rmetzger,
Update: I'm closing this PR now. The new PR with FLINK-4020 & FLINK-3231 is
at https://github.com/apache/flink/pull/2131.
---
If your project is set up for it, you can r
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1962#discussion_r67636217
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1962#discussion_r67636257
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1962#discussion_r67636370
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1962#discussion_r67636398
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/1962
Hi @sbcd90,
I think to address "add reconnect attempt" alone, checking whether or not
the transport client is connected to nodes and retry connect if lost connection
in `invoke
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1962#discussion_r67637714
--- Diff:
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2153
This will be very helpful! LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2131
@rmetzger tagging just to make sure you're notified of this PR :)
When will you be free to review? Just for my own time allocation for when
to continue working on the Kinesis connector
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2153#discussion_r68272113
--- Diff:
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/test/java/TestSkeleton.java
---
@@ -0,0 +1,184
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2153#discussion_r68276459
--- Diff:
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/test/java/TestSkeleton.java
---
@@ -0,0 +1,184
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68409807
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68412025
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68414043
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68409331
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68409932
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68408986
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68411242
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2071#discussion_r68420387
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumerThread.java
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2071
Thank you for reviewing this @rmetzger. Should I address your comment after
the rework in https://github.com/apache/flink/pull/2131 is merged, and rebase
this PR on that?
---
If your project
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2131
@rmetzger Thank you! No problem, I can wait and address the current
comments meanwhile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2131
@rmetzger
No problem, thank you! I'll reply to your comments after you finish
reviewing :)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68698386
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68696712
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68694102
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardDiscoverer.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68731349
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68730716
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68711841
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2131
@rmetzger
Thanks a lot for your helpful review :) I should be able to address your
comments before tomorrow so we can start testing it.
---
If your project is set up for it, you can reply
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68733201
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardDiscoverer.java
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/1813
Hi,
I've tested this on a local single node installation & cluster
installation. It works and have not come across problems.
Have a few other questions on the usage of the connecto
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2131
I've also tested the last commit on the unit & manual tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2131
Hi @rmetzger ,
I've addressed your initial comments with the last commit. No urgent hurry
on the remaining review, please take your time :) Thanks!
---
If your project is set up for it, you
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/1813
Hi @mjsax,
Regarding 1): just came to me that for SORTED_SET, a fixed secondary key
doesn't make sense, because the secondary key is supposed to define the order
of the inserted element
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2180#discussion_r68908245
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/SequenceNumber.java
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/2180
[FLINK-4080][kinesis-connector] Guarantee exactly-once for Kinesis consumer
when fail in middle of aggregated records
If multiple Kinesis records were aggregated into a single record by KPL,
when
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2180#discussion_r68906196
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/SequenceNumber.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60928569
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
Github user tzulitai commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-213491263
@rmetzger
Thank you very much for your detailed review on the PR :)
I've replied to the comments you added, please .
I can address the issues and follow up
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60753879
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60770825
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/KinesisConfigConstants.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60760294
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60755162
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60756732
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60752259
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60760085
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
Github user tzulitai commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-213465308
@rmetzger Regarding the need to upgrade Jackson to get the example working:
After updating the code for Flink 1.0.x to prepare for PR, I only tested
the consumer
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60825742
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60825740
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60825678
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60825532
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60828180
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60828156
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user tzulitai commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-213736435
@rmetzger I've addressed your comments with the latest commits. Thanks in
advance for your help on reviewing them :) Please let me know if there is
anything else
Github user tzulitai commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-213907816
I wonder why one of the Travis CI builds is failing on `flink-ml`? My
current FLINK-3229 branch is a few commits behind current apache/master, does
it have anything
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r61480982
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60906191
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1982#discussion_r62816359
--- Diff:
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/BatchJob.java
---
@@ -32,28 +32,29
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1982#discussion_r62820828
--- Diff:
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/BatchJob.java
---
@@ -32,28 +32,29
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1982#discussion_r62817913
--- Diff:
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/BatchJob.java
---
@@ -32,28 +32,29
Github user tzulitai commented on the pull request:
https://github.com/apache/flink/pull/1982#issuecomment-218413341
Made comments on some rather trivial javadoc / comment related stuff,
overall the PR looks good!
I like how you've also made effort to tidy up some details
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1982#discussion_r62818171
--- Diff:
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/BatchJob.java
---
@@ -32,28 +32,29
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1982#discussion_r62818792
--- Diff:
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/BatchJob.java
---
@@ -32,28 +32,29
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1982#discussion_r62816955
--- Diff:
flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/src/main/scala/StreamingJob.scala
---
@@ -0,0 +1,69
Github user tzulitai commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-217201356
Thanks Robert. I'll keep notice of your FLINK-3229-review branch for the
changes (I'm assuming your working on FLINK-3229-review for the protobuf
problem, please tell
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60346774
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user tzulitai commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-212340127
ah ok :) see it now, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tzulitai commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-212330070
@rmetzger Hi Robert,
I'm rebasing my PR, but I could not find the merged Kinesis producer /
maven module in the current apache/flink master. Please correct me
Github user tzulitai commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-212376531
Quick update:
1. Rebased and integrated the consumer code into the maven module that came
with the producer merge.
2. Appended documentation for the consumer
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1911#discussion_r60531075
--- Diff: flink-streaming-connectors/pom.xml ---
@@ -45,6 +45,7 @@ under the License.
flink-connector-rabbitmq
flink
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/1911
[FLINK-3229] Flink streaming consumer for AWS Kinesis
I've been using this consumer for a while in off-production environments.
I understand we should have good test coverage for each PR
Github user tzulitai commented on the pull request:
https://github.com/apache/flink/pull/1911#issuecomment-211847140
@rmetzger Sure, that seems reasonable. I'll wait until the producer is
merged and resubmit a new PR for the integrated consumer.
---
If your project is set up
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2228
Rebasing on merge of https://github.com/apache/flink/pull/2071 ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2071
No problem, thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2228
We should probably also merge https://github.com/apache/flink/pull/2227
before this one, to reduce effort on rebasing.
---
If your project is set up for it, you can reply to this email and have
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/2228
[FLINK-4170][kinesis-connector] Simplify Kinesis connecter config keys to
be less overly verbose
Changes included with this PR:
1) Separate consumer & producer config keys into 2 cla
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2227
Hi @skidder, I like the add, I think serious users will definitely need
this.
One thing I'm concerned about is how `CONFIG_AWS_REGION` and
`CONFIG_AWS_ENDPOINT` should co-exist
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2231
The errors are due to some of the changes to `AbstractFetcher` in
https://github.com/apache/flink/commit/41f58182289226850b23c61a32f01223485d4775.
Some of the Kafka 0.9 connector code that has
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/1690
What's the status of this PR? I think it is a good functionality to add.
@shikhar if you'd like to continue working on this, I'm happy to help shepherd
this PR for merging.
Some of my
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2231
@radekg Thank you for the quick fix. I hope to find time over the weekend
to test + review this, if not than early next week :)
---
If your project is set up for it, you can reply to this email
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2231
Hi @radekg ,
There was a recent change to the connector code to how the Kafka metrics
are reported, so right now the PR has conflicts and can't be built. Would you
like to rebase this PR
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2260
Hi @chadnickbok,
I've gave the new config a test on AWS EC2 instances with appropriate IAM
roles attached, and it works as expected and nicely. I think the changes are
good to merge once
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/1690
@shikhar Sure, please feel free to tag me for a review once you are done. I
think you'll need to manually close this PR yourself, you can close it when the
new PR is opened. Another option
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/1690
@shikhar Ok, sure no problem :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
1 - 100 of 1924 matches
Mail list logo
