GitHub user wangzhijiang999 opened a pull request:
https://github.com/apache/flink/pull/2141
[flink-4021] Problem of setting autoread for netty channel when more taâ¦
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/3113
@StephanEwen , I already created #5703 for further detail recovery process
and it may cover your considerations. Wish your further response, thank you!
---
If your project is set up
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2770#discussion_r99736682
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -340,7 +344,8 @@ public
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/2770
@tillrohrmann , thank you for review!
Actually this PR is out-of-date based on flip-6, and my following
modifications do not update this PR. This PR should be re-submitted based
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/3151
@tillrohrmann . Thank you for detail review and comments!
This PR just submit the heartbeat logic in TM side, because there is
already a jira of JM heartbeat side.
For my
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3151#discussion_r99732047
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -1058,6 +1092,30 @@ public void handleError
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3151#discussion_r99733319
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
---
@@ -112,6 +114,13 @@ public TaskManagerRunner
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3151#discussion_r99731288
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterGateway.java
---
@@ -218,4 +218,12 @@ void failSlot(final
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3151#discussion_r99732610
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -1058,6 +1092,30 @@ public void handleError
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2770#discussion_r99737151
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerGateway.java
---
@@ -122,4 +122,11 @@ void
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2770#discussion_r99737093
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -137,6 +140,7 @@ public ResourceManager
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3151#discussion_r99734627
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -741,6 +763,18 @@ private void
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2770#discussion_r99737255
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
---
@@ -99,6 +101,13 @@ public TaskManagerRunner
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2770#discussion_r99737204
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -1099,4 +1121,23 @@ public void run
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3151#discussion_r99736386
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -126,6 +129,9 @@
/** The metric
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3151#discussion_r100222823
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
---
@@ -112,6 +114,13 @@ public
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/3113
@StephanEwen , thank you for the concrete suggestions. Sorry for delay
response because of Chinese Spring Festival Holiday.
I have considered and added some tests to validate
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/3125
@StephanEwen
Yes, the current concern is only focusing on state restore performance.
This PR does not consider all the scenarios and it may be only the first step
for the slot location
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/3151
@tillrohrmann , I am preparing the testing code and can submit the updates
this week. Thank you for continuous help!
---
If your project is set up for it, you can reply to this email
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3151#discussion_r100030725
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -741,6 +763,18 @@ private void
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3151#discussion_r100031031
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
---
@@ -112,6 +114,13 @@ public
GitHub user wangzhijiang999 opened a pull request:
https://github.com/apache/flink/pull/3303
[FLINK-5133][core] Add new setResource API for DataStream and DataSet
This is part of the fine-grained resource configuration.
For **DataStream**, the **setResource** API will be setted
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/3303
@StephanEwen , this PR includes the new API that would be visible to user,
but it can not work completely because the following codes in runtime have not
been submitted. In order
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/3151
@tillrohrmann , I have submitted the updates that may cover your
suggestions.
There are still two issues that I am not confirmed.
First, for heartbeat interval and timeout
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/3340
@StephanEwen , wish your reviews. Thank you for any comments!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user wangzhijiang999 opened a pull request:
https://github.com/apache/flink/pull/3340
[FLINK-5703][runtime]Job manager failure recovery via reconciliation with
TaskManager reports
This is part of [Non-disruptive JobManager Failures via Reconciliation
](https
Github user wangzhijiang999 closed the pull request at:
https://github.com/apache/flink/pull/2798
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user wangzhijiang999 opened a pull request:
https://github.com/apache/flink/pull/3151
[FLINK-4364][runtime]mplement TaskManager side of heartbeat from JobMâ¦
1. **TaskManagerRunner** creates **HeartbeatManagerImpl** components when
constructs the **TaskManager**.
2
GitHub user wangzhijiang999 opened a pull request:
https://github.com/apache/flink/pull/3125
[FLINK-5499][JobManager]Reuse the resource location of prior executioâ¦
Currently when schedule execution to request to allocate slot from
**SlotPool**, the **TaskManagerLocation
GitHub user wangzhijiang999 opened a pull request:
https://github.com/apache/flink/pull/2400
[FLINK-4363] Implement TaskManager basic startup of all components in java
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75648894
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75650354
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75652404
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75649383
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75651298
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75651382
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/2400
Thank you for your review and advice, mxm. Another concern is whether to
modify the parameters in the methods "selectNetworkInterfaceAndRunTaskMa
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r76189882
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -36,27 +82,617 @@
*/
public
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r76190061
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -36,27 +82,617 @@
*/
public
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r76189450
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -36,27 +82,617 @@
*/
public
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r76189334
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -94,12 +729,11 @@ public void
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/2400
@mxm , could we remove the parameter "taskManagerHostname" from
"startTaskManagerComponentsAndActor" method, I think the hostname can be got by
{{TaskExecutor}} its
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r76213620
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -36,27 +82,617 @@
*/
public
Github user wangzhijiang999 closed the pull request at:
https://github.com/apache/flink/pull/2400
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/2461
@tillrohrmann , I created the `TaskExecutorRunner` for constructing the
related components for starting `TaskExecutor`, and removed the factory class.
Currently only the `ResourceID
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/2461
@tillrohrmann , the current implementation is just follow the previous
process for yarn and standalone modes. And I agree your opinion and actually it
is not very clear for current ways. I
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2461#discussion_r77329068
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/YarnTaskExecutorFactory.java
---
@@ -0,0 +1,198 @@
+package
GitHub user wangzhijiang999 opened a pull request:
https://github.com/apache/flink/pull/2461
[FLINK-4505][Cluster Management] Implement TaskManagerFactory to brinâ¦
Implement TaskExecutorFactory that should be an abstract class with the
helper methods to bring up the TaskManager
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/2461
@mxm , The {{StandaloneTaskExecutorFactory}} can be used for mini cluster
or testing mode I think, and the {{YarnTaskExecutorFactory}} used for yarn
mode. After you confirm
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/2461
@tillrohrmann , I tried to understand your idea as follows:
1. Provide specific TaskExecutorFactory class instead of abstract factory
for both standalone/yarn mode.
2. Network
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/2400
@mxm , I have created the FLINK-4505 for TaskExecutorFactory issue. As you
mentioned, it should be an abstract class and provide an abstract method maybe
called 'createAndStartTaskExecutor
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/2400
@mxm, I already push my changes and solve the conflicts based on the new
flip-6 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r75805009
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/2400
Hi @mxm , I pushed some modifications based on your comments, including:
1. Make var as final
2. Implement TaskExecutorConfiguration class in java instead of
TaskManagerConfiguration
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2400#discussion_r76367829
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
@@ -35,27 +79,634 @@
*/
public
Github user wangzhijiang999 closed the pull request at:
https://github.com/apache/flink/pull/2461
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/2461
@tillrohrmann , thank you for merging and help. If there are any following
works to do related with TaskManager, you can assign to me and I am willing to
do.
---
If your project is set up
GitHub user wangzhijiang999 opened a pull request:
https://github.com/apache/flink/pull/2770
[FLINK-4354]Implement TaskManager side of heartbeat from ResourceManager
When TaskManager registers at the new ResourceManager, the SlotReport will
be attached in the message. In heartbeat
GitHub user wangzhijiang999 opened a pull request:
https://github.com/apache/flink/pull/2798
[FLINK-4364]Implement TaskManager side of heartbeat from JobManager
1. **TaskManagerRunner** creates **HeartbeatManagerImpl** components for
monitoring **JobManager** and **ResourceManager
GitHub user wangzhijiang999 opened a pull request:
https://github.com/apache/flink/pull/3113
[FLINK-4912] Introduce RECONCILIATING state in ExecutionGraph and Exeâ¦
This is part of the non-disruptive JobManager failure recovery.
Add a JobStatus and ExecutionState
Github user wangzhijiang999 closed the pull request at:
https://github.com/apache/flink/pull/2907
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user wangzhijiang999 closed the pull request at:
https://github.com/apache/flink/pull/2906
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user wangzhijiang999 opened a pull request:
https://github.com/apache/flink/pull/3114
[FLINK-5132]Introduce the ResourceSpec for grouping different resourcâ¦
This is part of the fine-grained resource configuration.
The current resource factors include cpu cores
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3113#discussion_r95975088
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/execution/ExecutionState.java
---
@@ -25,16 +25,23 @@
* {@code
GitHub user wangzhijiang999 opened a pull request:
https://github.com/apache/flink/pull/2906
[FLINK-5132][FLINK-5133][FLINK-5134][Core,DataStream API,DataSet API]
Fine-grained Resource Configuration
Introduce the **ResourceSpec** structure to describe the different resource
GitHub user wangzhijiang999 opened a pull request:
https://github.com/apache/flink/pull/2907
[FLINK-5135][JM]ResourceProfile for slot request should be expanded to
correspond with ResourceSpec
Currently the **ResourceProfile** only contains cpu cores and memory
properties
66 matches
Mail list logo
