Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74697490
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74697524
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74699827
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74699842
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka08JsonTableSink.java
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74699840
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka08JsonTableSink.java
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74699836
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74699857
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -590,7 +592,7 @@ class Table(
.map(field
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74700046
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/sinks/TableSinkBase.scala
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74700122
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/JsonRowSerializationSchema.java
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2244
LGTM except a few nits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74703534
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -592,7 +592,7 @@ class Table(
.map(field
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r74703734
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/sinks/TableSinkBase.scala
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2244
The CsvTableSinkTest failed, can you check it ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2371#discussion_r74720168
--- Diff:
flink-core/src/test/java/org/apache/flink/configuration/DelegatingConfigurationTest.java
---
@@ -88,4 +89,51 @@ private String typeParamToString
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2371
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2372
[FLINK-4281] [table] Wrap all Calcite Exceptions in Flink Exceptions
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2372#discussion_r74747473
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/FlinkPlannerImpl.scala
---
@@ -68,12 +68,16 @@ class FlinkPlannerImpl
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2372
@twalthr @mushketyk review comments addressed, and fix the conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2305
I'm ok with the `with(...)` approach. In addition, we should create a JIRA
under [FLINK-3957]
"Breaking API changes for Flink 2.0", to keep track of deprecating and
changing the
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2384
[FLINK-4420] [table] Introduce star(*) to select all of the columns in the
table
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2244
Could we move `CsvTableSinkTest` to `TableSinkITCase` or just remove
`CsvTableSinkTest` ? I think `TableSinkITCase` has tested `CsvTableSink` with
default delimiter and custom delimiter.
---
If
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2404
[FLINK-4435] Replace Guava's VisibleForTesting annotation with Flink's
annotation
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2411
[FLINK-4453] [docs] Scala code example in Window documentation shows Java
quick fix... ð
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r75998992
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -223,10 +223,28 @@ trait
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2374#discussion_r76011481
--- Diff: docs/apis/metrics.md ---
@@ -157,6 +157,55 @@ public class MyMapper extends RichMapFunction {
}
{% endhighlight %}
+ Meter
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2374#discussion_r76012984
--- Diff: docs/apis/metrics.md ---
@@ -157,6 +157,55 @@ public class MyMapper extends RichMapFunction {
}
{% endhighlight %}
+ Meter
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2411
Hi @fhueske , it seems that a Scala version of WindowFunction does exist,
which is `org.apache.flink.streaming.api.scala.function.WindowFunction`. And
both Scala WindowedStream and AllWindowedStream
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2319#discussion_r76036947
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala
---
@@ -223,10 +223,28 @@ trait
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2305
Yes, I would like.
> å¨ 2016å¹´8æ24æ¥ï¼20:38ï¼Stephan Ewen
åéï¼
>
> @wuchong Do you want to update this PR with the with(...) approach and
file the JIRA for
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2305
Hi @StephanEwen @aljoscha , I have updated this PR with the `with(...)`
approach , could you have a look at it?
And log FLINK-4503 JIRA for Flink 2.0 breaking changes.
---
If your project
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2305
Hi @StephanEwen , comments addressed.
I'm not sure whether the comments are correct. Let me know if I'm wrong.
---
If your project is set up for it, you can reply to this emai
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2102
Thanks @twalthr . This issue is more complex than I expected before. I will
try to update this PR in next days.
---
If your project is set up for it, you can reply to this email and have your
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2305
Hi @aljoscha @StephanEwen , this issue has been blocked for some days. It
would be great, if you can have a look again ?
---
If your project is set up for it, you can reply to this email and
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2453
[FLINK-4510] [checkpoint] Always create CheckpointCoordinator
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2454
[FLINK-4546] [table] Remove STREAM keyword in Stream SQL
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2453
Make sense. I will update this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2454#discussion_r77507678
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/schema/DataStreamTable.scala
---
@@ -18,22 +18,11 @@
package
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2454
Hi @fhueske , thanks for reviewing, I updated this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2453
Hi @StephanEwen , I have updated this PR according to your suggestion. In
addition, I use an interval of `Long.MAX_VALUE` for disabled periodic
checkpoint. In this way, we will not break interval
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2102
As I mentioned above, the `cannot translate call AS($t0, $t1)` error
because of a Calcite bug. The
[CALCITE-1297](https://issues.apache.org/jira/browse/CALCITE-1297) fixed it ,
but not yet released
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2454
Hi @fhueske @twalthr , do you have time to have a look again? Any advices
are welcome.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2482
[FLINK-4579] [StateBackend] Add StateBackendFactory for RocksDB Backend
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2482
Hi @StephanEwen , if we want to have a shortcut (`rocksdb`), what should
we do? Add the rocksdb dependency into `flink-streaming-java` module ? Or use
java reflect ?
---
If your project is set
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2535
[FLINK-4662] Bump Calcite version up to 1.9
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2482
Added a shortcut (rocksdb) for configuring RocksDB state backend and added
the dedicated option config `state.backend.rocksdb.checkpointdir`.
---
If your project is set up for it, you can reply to
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3107
@twalthr Yes, I will update it in these days.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3107
@twalthr I have updated this PR regarding to the idea you proposed that
`env.sql(s"SELECT * FROM $table JOIN $otherTable")`
---
If your project is set up for it, you can reply to this
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3107
updated the documentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3667
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2653
Sounds great. Thanks Fabian .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87707411
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala
---
@@ -194,9 +263,10
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87707098
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala
---
@@ -135,50 +130,124
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87707013
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala
---
@@ -135,50 +130,124
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87708645
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateUtil.scala
---
@@ -61,25 +61,108 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87706978
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala
---
@@ -135,50 +130,124
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87708469
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateUtil.scala
---
@@ -61,25 +61,108 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87707250
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/IncrementalAggregateAllTimeWindowFunction.scala
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87693902
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateUtil.scala
---
@@ -61,25 +61,108 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87693746
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/AggregationsITCase.scala
---
@@ -177,6 +177,58 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87693718
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/AggregationsITCase.scala
---
@@ -177,6 +177,58 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87693848
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateUtil.scala
---
@@ -61,25 +61,108 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87693820
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala
---
@@ -103,19 +103,12
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2758#discussion_r87993759
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/batch/sql/SqlITCase.java
---
@@ -118,4 +119,39 @@ public void testJoin
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88406527
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/TableFunction.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88406551
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/batch/UserDefinedTableFunctionITCase.java
---
@@ -0,0 +1,201
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2653
Hi @fhueske , you mentioned two ways to reduce IT cases. One is comparing
the logical plans of two tables, this can reduce Java IT cases. Another is
using `TableTestBase` tool to write unit tests
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88593490
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -154,6 +154,10 @@ under the License.
maven-shade-plugin
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2653
Thank you @fhueske @twalthr for the review, I will update the PR in this
weekend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88594421
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -542,11 +563,14 @@ class CodeGenerator
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88594410
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/java/table/StreamTableEnvironment.scala
---
@@ -164,4 +167,24 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88594489
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/utils/TableSqlFunction.scala
---
@@ -0,0 +1,99
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88594496
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/utils/TableSqlFunction.scala
---
@@ -0,0 +1,99
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88594602
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/java/table/BatchTableEnvironment.scala
---
@@ -162,4 +165,24 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r88591760
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableProject.scala
---
@@ -0,0 +1,67
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r88591928
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/BatchTableSourceProjectRule.scala
---
@@ -0,0 +1,81
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r88591967
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/datastream/StreamTableSourceProjectRule.scala
---
@@ -0,0 +1,82
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r88609838
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/sources/ProjectableTableSource.scala
---
@@ -0,0 +1,32
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r88591860
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/StreamTableProject.scala
---
@@ -0,0 +1,67
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r88592516
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableProject.scala
---
@@ -0,0 +1,67
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88614200
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -162,24 +191,107
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88614416
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/call.scala
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88615712
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetCorrelate.scala
---
@@ -0,0 +1,136
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88617047
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/schema/FlinkTableFunctionImpl.scala
---
@@ -0,0 +1,77
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88617248
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/validate/FunctionCatalog.scala
---
@@ -47,13 +52,50 @@ class FunctionCatalog
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88617192
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -611,6 +612,130 @@ class Table
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88622767
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/TableFunction.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r88778110
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/IncrementalAggregateReduceFunction.scala
---
@@ -0,0 +1,69
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r88796985
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/IncrementalAggregateReduceFunction.scala
---
@@ -0,0 +1,69
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2758
It would be great if you can rebase your branch and resolve the conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2758
The Travis CI has failed because of `BuiltInMethods` line length, could
you fix this ?
```
[INFO] --- scalastyle-maven-plugin:0.8.0:check (default) @ flink-table_2.10
---
error
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2758
Great ! The PR looks good to me now, thank you for your contribution !
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r88844164
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableProject.scala
---
@@ -0,0 +1,67
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r88869401
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableProject.scala
---
@@ -0,0 +1,67
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89091052
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/sources/ProjectableTableSource.scala
---
@@ -0,0 +1,32
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89090976
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableProject.scala
---
@@ -0,0 +1,67
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2810
Hi @tonycox , the
[`RowCsvInputFormat`](https://github.com/apache/flink/blob/master/flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/io/RowCsvInputFormat.scala#L100
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r89124491
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -162,24 +191,107
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r89124951
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -162,24 +191,107
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2653
Regarding to the mixing parser Expression and Logical Node, how about to
create a `LogicalParser` which is used to parse string to LogicalNode ? This
can separate expressions and logical nodes, and
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2810
Hi @tonycox , the overall change looks good to me. I will do more thorough
review in this weekend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
1 - 100 of 647 matches
Mail list logo
