[GitHub] flink pull request #3552: [FLINK-5978] Fix JM WebFrontend address ConfigOpti...

2017-03-15 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/3552 [FLINK-5978] Fix JM WebFrontend address ConfigOption is defined in Co… …nfigConstants Thanks for contributing to Apache Flink. Before you open your pull request, please take

[GitHub] flink issue #4075: [FLINK-6494] Migrate ResourceManager/Yarn/Mesos configura...

2017-08-01 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4075 @zentol I updated this PR and fix some code conflicts, could you please have a look when you're free, thanks --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #4455: [FLINK-7251] Merge the flink-java8 project into correspon...

2017-08-01 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4455 @zentol Thank you for your suggestion, it sounds good to me and I have fixed them, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink issue #4455: [FLINK-7251] Merge the flink-java8 project into correspon...

2017-08-02 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4455 The `JobRetrievalITCase` is ok when I remove the tycho-compiler completely, I think it may be a bug of the tycho-compiler :( --- If your project is set up for it, you can reply to this email

[GitHub] flink issue #4455: [FLINK-7251] Merge the flink-java8 project into correspon...

2017-08-02 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4455 Maybe it's better to move *ITCase to `Flink-java` project and rename them to *Test, I find it will be alright, what do you think? @zentol --- If your project is set up for it, you can reply

[GitHub] flink issue #4455: [FLINK-7251] Merge the flink-java8 project into correspon...

2017-08-02 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4455 1. For the `StateBackendITCase`, it can be resolved by bumping the tycho compiler version to 1.0.0, but when I try to use tycho compiler version 1.0.0 in `flink-java`, it will cause lambda exception

[GitHub] flink pull request #4475: [FLINK-7251] Add proper command line parsing tool ...

2017-08-04 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4475 [FLINK-7251] Add proper command line parsing tool to ClusterEntrypoint ## What is the purpose of the change Add a proper command line parsing tool `CommandLineParser` to the entry point

[GitHub] flink pull request #4476: [FLINK-7307] Add proper command line parsing tool ...

2017-08-04 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4476 [FLINK-7307] Add proper command line parsing tool to ClusterEntrypoint ## What is the purpose of the change Add a proper command line parsing tool `CommandLineParser` to the entry point

[GitHub] flink issue #4475: [FLINK-7251] Add proper command line parsing tool to Clus...

2017-08-04 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4475 @tillrohrmann I create `CommandLineParser` instead of `ParameterTool` in `ClusterEntrypoint#parseArguments`, please have a look when you're free, thanks --- If your project is set up for it, you

[GitHub] flink pull request #4475: [FLINK-7307] Add proper command line parsing tool ...

2017-08-04 Thread zjureel
Github user zjureel closed the pull request at: https://github.com/apache/flink/pull/4475 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #4476: [FLINK-7307] Add proper command line parsing tool to Clus...

2017-08-14 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4476 @tillrohrmann @aljoscha I have fixed [https://issues.apache.org/jira/browse/FLINK-7307](https://issues.apache.org/jira/browse/FLINK-7307) in this PR, could you please have a look when you're free

[GitHub] flink issue #4524: [FLINK-7419] Shade jackson dependency in flink-avro

2017-08-14 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4524 @zentol Thank you for your review, I have rename the pattern, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #4511: [FLINK-7396] Don't put multiple directories in HAD...

2017-08-10 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4511 [FLINK-7396] Don't put multiple directories in HADOOP_CONF_DIR in config.sh ## What is the purpose of the change Fix put multiple directories in HADOOP_CONF_DIR in config.sh

[GitHub] flink issue #4511: [FLINK-7396] Don't put multiple directories in HADOOP_CON...

2017-08-10 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4511 @aljoscha What do you think of this change for [https://issues.apache.org/jira/browse/FLINK-7396](https://issues.apache.org/jira/browse/FLINK-7396) Thanks --- If your project is set up

[GitHub] flink issue #4511: [FLINK-7396] Don't put multiple directories in HADOOP_CON...

2017-08-13 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4511 Thank you for merging it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink pull request #4511: [FLINK-7396] Don't put multiple directories in HAD...

2017-08-13 Thread zjureel
Github user zjureel closed the pull request at: https://github.com/apache/flink/pull/4511 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #4511: [FLINK-7396] Don't put multiple directories in HADOOP_CON...

2017-08-10 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4511 @aljoscha Sorry it's my fault, I have fixed it, thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #4524: [FLINK-7419] Shade jackson dependency in flink-avr...

2017-08-10 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4524 [FLINK-7419] Shade jackson dependency in flink-avro ## What is the purpose of the change Shade jackson dependency in flink-avro to avoid incompatible versions ## Brief change log

[GitHub] flink pull request #4307: [FLINK-7100] TaskManager metrics are registered tw...

2017-07-12 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4307 [FLINK-7100] TaskManager metrics are registered twice Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink issue #3921: [FLINK-6058] fix read DEFAULT_PARALLELISM from ContextEnv...

2017-07-10 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3921 I have fixed it, thanks @aljoscha --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request #4278: [FLINK-7099] Replace usages of deprecated JOB_MANA...

2017-07-10 Thread zjureel
Github user zjureel commented on a diff in the pull request: https://github.com/apache/flink/pull/4278#discussion_r126383468 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java --- @@ -185,8 +185,8 @@ public static WebMonitor

[GitHub] flink pull request #4292: [FLINK-6588] Rename NumberOfFullRestarts metric

2017-07-10 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4292 [FLINK-6588] Rename NumberOfFullRestarts metric Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[GitHub] flink pull request #4278: [FLINK-7099] Replace usages of deprecated JOB_MANA...

2017-07-10 Thread zjureel
Github user zjureel commented on a diff in the pull request: https://github.com/apache/flink/pull/4278#discussion_r126366568 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java --- @@ -185,8 +185,8 @@ public static WebMonitor

[GitHub] flink issue #4307: [FLINK-7100] TaskManager metrics are registered twice

2017-07-12 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4307 @zentol @aljoscha I have tried to fix this issue, please have a look when you are free, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request #3921: [FLINK-6058] fix read DEFAULT_PARALLELISM from Con...

2017-07-11 Thread zjureel
Github user zjureel closed the pull request at: https://github.com/apache/flink/pull/3921 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #3921: [FLINK-6058] fix read DEFAULT_PARALLELISM from ContextEnv...

2017-07-11 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3921 Thank you for merging it @aljoscha --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #4307: [FLINK-7100] TaskManager metrics are registered twice

2017-07-13 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4307 @zentol Thank you for your review, I have fix the problems you metioned as follows: 1. rename `TaskExecutorMetricsInitializer` to `MetricUtils` 2. move `taskManagerMetricGroup.close()` from

[GitHub] flink issue #4277: [FLINK-6667] Pass a callback type to the RestartStrategy,...

2017-07-17 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4277 Thank you for your reply, I will fix [FLINK-6665](https://issues.apache.org/jira/browse/FLINK-6665) after this PR is merged, thanks :) --- If your project is set up for it, you can reply

[GitHub] flink issue #4292: [FLINK-6588] Rename NumberOfFullRestarts metric

2017-07-17 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4292 @zentol What do you think of @StephanEwen 's suggestion? I think this change does cause some incompatibilities for user, thanks --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request #4278: [FLINK-7099] Replace usages of deprecated JOB_MANA...

2017-07-10 Thread zjureel
Github user zjureel commented on a diff in the pull request: https://github.com/apache/flink/pull/4278#discussion_r126343858 --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkSubmitter.java --- @@ -91,12 +91,11 @@ public static void submitTopology

[GitHub] flink pull request #4376: [FLINK-6521] Add per job cleanup methods to HighAv...

2017-07-20 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4376 [FLINK-6521] Add per job cleanup methods to HighAvailabilityServices Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list

[GitHub] flink pull request #4361: [FLINK-7222] fix Kafka010ITCase fails on windows

2017-07-18 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4361 [FLINK-7222] fix Kafka010ITCase fails on windows Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[GitHub] flink issue #3915: [FLINK-6352] Support to use timestamp to set the initial ...

2017-07-19 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3915 @tzulitai No problem, thank you for your attension :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #4361: [FLINK-7222] fix Kafka010ITCase fails on windows

2017-07-19 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4361 @tzulitai Thank you for your reply. I found there's no such problem for Kafka 08, and I have already fix this for 09 too. Thanks --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request #4277: [FLINK-6667] Pass a callback type to the RestartSt...

2017-07-23 Thread zjureel
Github user zjureel closed the pull request at: https://github.com/apache/flink/pull/4277 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #4220: [FLINK-6665] Pass a ScheduledExecutorService to th...

2017-07-23 Thread zjureel
Github user zjureel closed the pull request at: https://github.com/apache/flink/pull/4220 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #4277: [FLINK-6667] Pass a callback type to the RestartStrategy,...

2017-07-23 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4277 Thank you for your merging, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #4220: [FLINK-6665] Pass a ScheduledExecutorService to the Resta...

2017-07-23 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4220 @StephanEwen Thank you for your merging :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #4415: [FLINK-7269] Refactor passing of dynamic properties

2017-07-28 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4415 @tillrohrmann @aljoscha I create this PR and try to fix [https://issues.apache.org/jira/browse/FLINK-7269](https://issues.apache.org/jira/browse/FLINK-7269), could you please have look when you're

[GitHub] flink pull request #4415: [FLINK-7269] Refactor passing of dynamic propertie...

2017-07-28 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4415 [FLINK-7269] Refactor passing of dynamic properties *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your

[GitHub] flink issue #4075: [FLINK-6494] Migrate ResourceManager/Yarn/Mesos configura...

2017-06-28 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4075 @zentol Thank you for your suggestion, I have fixed the problems you metioned. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #3915: [FLINK-6352] Support to use timestamp to set the i...

2017-06-30 Thread zjureel
Github user zjureel commented on a diff in the pull request: https://github.com/apache/flink/pull/3915#discussion_r124977924 --- Diff: flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer010.java --- @@ -128,6

[GitHub] flink issue #3915: [FLINK-6352] Support to use timestamp to set the initial ...

2017-06-30 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3915 @tzulitai Thank you for your suggestion. I think move the conversion between date and offset to `KafkaConsumerThread` is really a good idea. I have fixed the NPE in test case, and move

[GitHub] flink pull request #4184: [FLINK-6310] Use lock object for synchronization

2017-07-04 Thread zjureel
Github user zjureel closed the pull request at: https://github.com/apache/flink/pull/4184 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #4184: [FLINK-6310] Use lock object for synchronization

2017-07-04 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4184 @aljoscha Thank you for merging it, I will close it, thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #4220: [FLINK-6665] Pass a ScheduledExecutorService to the Resta...

2017-07-04 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4220 @tillrohrmann Thank you for your review, I have remove `restart(ExecutionGraph executionGraph)`, and use `ScheduledExecutor` instead of `ScheduledExecutorService` you metioned. Thanks --- If your

[GitHub] flink issue #4204: [FLINK-6522] Add ZooKeeper cleanup logic to ZooKeeperHaSe...

2017-07-05 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4204 @tillrohrmann Thank you for your review. I use `prefix` as the name of sub directory, and add test case to `FileSystemStateStorageHelper#closeAndCleanupAllData`. Also I have fixed the problem you

[GitHub] flink issue #4173: [FLINK-6499] Migrate state configuration options

2017-07-05 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4173 @tzulitai Thank you for merging this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #4220: [FLINK-6665] Pass a ScheduledExecutorService to the Resta...

2017-07-06 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4220 @StephanEwen Thank you for your suggestion, I think you raise an important problem about this issue. I agree with you, I will pick [FLINK-6667](https://issues.apache.org/jira/browse/FLINK-6667

[GitHub] flink pull request #4220: [FLINK-6665] Pass a ScheduledExecutorService to th...

2017-06-29 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4220 [FLINK-6665] Pass a ScheduledExecutorService to the RestartStrategy … avoid any sleeps. Thanks for contributing to Apache Flink. Before you open your pull request, please take

[GitHub] flink pull request #4204: [FLINK-6522] Add ZooKeeper cleanup logic to ZooKee...

2017-06-27 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4204 [FLINK-6522] Add ZooKeeper cleanup logic to ZooKeeperHaServices Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink issue #4277: [FLINK-6667] Pass a callback type to the RestartStrategy,...

2017-07-06 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4277 @StephanEwen @tillrohrmann As discussed in https://github.com/apache/flink/pull/4220, I create this PR to fix issue [FLINK-6667](https://issues.apache.org/jira/browse/FLINK-6667). Could you please

[GitHub] flink issue #3921: [FLINK-6058] fix read DEFAULT_PARALLELISM from ContextEnv...

2017-07-06 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3921 I have updated the code according to your suggestion, please have a look when you are free, thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request #4277: [FLINK-6667] Pass a callback type to the RestartSt...

2017-07-06 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4277 [FLINK-6667] Pass a callback type to the RestartStrategy, rather than the full ExecutionGraph … the full ExecutionGraph Thanks for contributing to Apache Flink. Before you open your pull

[GitHub] flink issue #3921: [FLINK-6058] fix read DEFAULT_PARALLELISM from ContextEnv...

2017-07-06 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3921 @aljoscha Sorry for replying late, your suggestion sounds good to me. In fact, I was hesitating to add `getDefaultParallelism()` in `ContextEnvironment` and `ClusterClient` for there have been

[GitHub] flink pull request #4278: [FLINK-7099] Replace usages of deprecated JOB_MANA...

2017-07-07 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4278 [FLINK-7099] Replace usages of deprecated JOB_MANAGER_IPC_PORT_KEY and JOB_MANAGER_IPC_ADDRESS_KEY …d JOB_MANAGER_IPC_ADDRESS_KEY Thanks for contributing to Apache Flink. Before you open

[GitHub] flink issue #4415: [FLINK-7269] Refactor passing of dynamic properties

2017-07-30 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4415 @tillrohrmann Thank you for your suggestion, I have update the PR template and add test case, thanks --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request #4292: [FLINK-6588] Rename NumberOfFullRestarts metric

2017-07-30 Thread zjureel
Github user zjureel closed the pull request at: https://github.com/apache/flink/pull/4292 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #4500: [FLINK-6787] Fix Job-/StoppingException extend Fli...

2017-08-09 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4500 [FLINK-6787] Fix Job-/StoppingException extend FlinkException ## What is the purpose of the change Fix Job-/StoppingException extend FlinkException ## Brief change log

[GitHub] flink pull request #4455: [FLINK-7251] Merge the flink-java8 project into co...

2017-08-01 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4455 [FLINK-7251] Merge the flink-java8 project into corresponding flink project ## What is the purpose of the change Merge the codes in flink-java8 project into corresponding flink project

[GitHub] flink issue #4415: [FLINK-7269] Refactor passing of dynamic properties

2017-07-31 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4415 @tillrohrmann Great, use `loadConfigurationWithDynamicProperties` instead of `loadConfiguration` and `setDynamicProperties` will be more concise, it sounds good to me, thanks --- If your project

[GitHub] flink issue #4376: [FLINK-6521] Add per job cleanup methods to HighAvailabil...

2017-07-31 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4376 I found the following kinda stuff from CI, and it seems not relevant to this issue, what do you think? @tillrohrmann ``` Running

[GitHub] flink issue #4500: [FLINK-6787] Fix Job-/StoppingException extend FlinkExcep...

2017-08-09 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4500 @zentol I have created this PR to fix [https://issues.apache.org/jira/browse/FLINK-6787](https://issues.apache.org/jira/browse/FLINK-6787), could you please have a look when you're free, thanks

[GitHub] flink issue #4562: [FLINK-7402] Fix ineffective null check in NettyMessage#w...

2017-08-22 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4562 @tedyu @NicoK Than you for your suggestions, it sounds good to me, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request #4574: [FLINK-6864] Fix confusing "invalid POJO type" mes...

2017-08-22 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4574 [FLINK-6864] Fix confusing "invalid POJO type" messages from TypeExtractor ## What is the purpose of the change Fix confusing "invalid POJO type" message

[GitHub] flink issue #4574: [FLINK-6864] Fix confusing "invalid POJO type" messages f...

2017-08-22 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4574 @tzulitai I create this PR to fix [https://issues.apache.org/jira/browse/FLINK-6864](https://issues.apache.org/jira/browse/FLINK-6864), I think add logs instead of removing them will be better, what

[GitHub] flink pull request #4562: [FLINK-7402] Fix ineffective null check in NettyMe...

2017-08-23 Thread zjureel
Github user zjureel commented on a diff in the pull request: https://github.com/apache/flink/pull/4562#discussion_r134704354 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -220,9 +220,7 @@ void releaseBuffer

[GitHub] flink pull request #4562: [FLINK-7402] Fix ineffective null check in NettyMe...

2017-08-18 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4562 [FLINK-7402] Fix ineffective null check in NettyMessage#write() ## What is the purpose of the change Fix ineffective null check in NettyMessage#write() ## Brief change log

[GitHub] flink issue #3766: [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner ...

2017-05-14 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3766 @tzulitai Thank you for your replay. For 1, the `ExecutorService` is used to control timeout of fetching kafka partitions. When fetch kafka partitions, a `Future` will be created

[GitHub] flink issue #3766: [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner ...

2017-05-15 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3766 @tzulitai Thank you for your suggestion, and I think you are right. I will create a new PR from the master and cherry-pick my commits for this issue soon. --- If your project is set up for it, you

[GitHub] flink issue #3904: [FLINK-6439] Fix close OutputStream && InputStream in Ope...

2017-05-15 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3904 @zentol I have fix the issue 6439 in this PR, could you please review the code here when you are free. Thaks :) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request #3901: [FLINK-6288] fix FlinkKafkaProducer's custom Parti...

2017-05-15 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/3901 [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic …voked with number of partitions of default topic Thanks

[GitHub] flink issue #3901: [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner ...

2017-05-15 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3901 @tzulitai I created the new PR here for issue 6288. As discussed in [https://github.com/apache/flink/pull/3766](url), there are two ways to control timeout of fetching kafka meta 1. Depend

[GitHub] flink pull request #3904: [FLINK-6439] Fix close OutputStream && InputStream...

2017-05-15 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/3904 [FLINK-6439] Fix close OutputStream && InputStream in OperatorSnapshotUtil …tUtil Thanks for contributing to Apache Flink. Before you open your pull request, please take the f

[GitHub] flink issue #3915: [FLINK-6352] Support to use timestamp to set the initial ...

2017-05-17 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3915 Thank you for your suggestion. It sounds good and will be more friendly to users than throwing exception in `FlinkKafkaConsumerBase`. I'll fix it soon, thanks :) --- If your project is set up

[GitHub] flink pull request #3915: [FLINK-6352] Support to use timestamp to set the i...

2017-05-18 Thread zjureel
Github user zjureel commented on a diff in the pull request: https://github.com/apache/flink/pull/3915#discussion_r117206216 --- Diff: flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer08.java --- @@ -187,31

[GitHub] flink issue #3915: [FLINK-6352] Support to use timestamp to set the initial ...

2017-05-18 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3915 @tzulitai I have fixed `setStartFromSpecificDate` problem, and updated `FlinkKafkaConsumer08` so that it supports to set start offsets of Kafka by date --- If your project is set up for it, you can

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-17 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/3935 [FLINK-6495] Migrate Akka configuration options Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[GitHub] flink issue #3915: [FLINK-6352] Support to use timestamp to set the initial ...

2017-05-17 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3915 @tzulitai Glad to hear from you. In fact I'm also entangled with whether to put the `setStartFromSpecificDate` method into `FlinkKafkaConsumerBase`, and I put it into `FlinkKafkaComsumerBase

[GitHub] flink pull request #3915: [FLINK-6352] Support to use timestamp to set the i...

2017-05-17 Thread zjureel
Github user zjureel commented on a diff in the pull request: https://github.com/apache/flink/pull/3915#discussion_r117162289 --- Diff: flink-connectors/flink-connector-kafka-0.10/pom.xml --- @@ -37,7 +37,7 @@ under the License. - 0.10.0.1

[GitHub] flink issue #3901: [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner ...

2017-05-15 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3901 Yes, user can config the timeout and retry times to fetch kafka meta beyond the configuration of kafka itself. @tzulitai --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request #3921: [FLINK-6058] fix read DEFAULT_PARALLELISM from Con...

2017-05-16 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/3921 [FLINK-6058] fix read DEFAULT_PARALLELISM from ContextEnvironment Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink issue #3901: [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner ...

2017-05-16 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3901 @tzulitai I agree with you and `ExecutorService` is really unnecessary. I will update the code and remove `ExecutorService` --- If your project is set up for it, you can reply to this email

[GitHub] flink issue #3915: [FLINK-6352] Support to use timestamp to set the initial ...

2017-05-16 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3915 @tzulitai Could you please review code here when you are free, thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #3904: [FLINK-6439] Fix close OutputStream && InputStream in Ope...

2017-05-16 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3904 @zentol Thank you for your reply, I have update the code and add space after `try` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #3915: [FLINK-6352] Support to use timestamp to set the i...

2017-05-16 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/3915 [FLINK-6352] Support to use timestamp to set the initial offset of kafka Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list

[GitHub] flink issue #3861: [Flink-6352] Support to use timestamp to set the initial ...

2017-05-16 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3861 Use [https://github.com/apache/flink/pull/3915](url) instead --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #4075: [FLINK-6494] Migrate ResourceManager/Yarn/Mesos co...

2017-06-21 Thread zjureel
Github user zjureel commented on a diff in the pull request: https://github.com/apache/flink/pull/4075#discussion_r123180174 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java --- @@ -52,7 +52,74 @@ key("yarn.pe

[GitHub] flink issue #4123: [FLINK-6498] Migrate Zookeeper configuration options

2017-06-21 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4123 @zentol Thank you for your suggestions. I have fixed them, thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink issue #4075: [FLINK-6494] Migrate ResourceManager/Yarn/Mesos configura...

2017-06-22 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4075 I have fixed the problems you metioned, thanks @zentol --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #4022: [FLINK-5488] stop YarnClient before exception is t...

2017-06-21 Thread zjureel
Github user zjureel commented on a diff in the pull request: https://github.com/apache/flink/pull/4022#discussion_r123425557 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClientV2.java --- @@ -146,7 +146,9 @@ public ApplicationStatus getApplicationStatus

[GitHub] flink pull request #4123: [FLINK-6498] Migrate Zookeeper configuration optio...

2017-06-21 Thread zjureel
Github user zjureel commented on a diff in the pull request: https://github.com/apache/flink/pull/4123#discussion_r123424835 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java --- @@ -370,11 +370,11 @@ public static String

[GitHub] flink issue #3921: [FLINK-6058] fix read DEFAULT_PARALLELISM from ContextEnv...

2017-06-22 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3921 @zentol Thank you for your comment, I have fixed the problem you metioned. Could you please review the new commit when you are free? Thanks --- If your project is set up for it, you can reply

[GitHub] flink pull request #4184: [FLINK-6310] Use lock object for synchronization

2017-06-26 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4184 [FLINK-6310] Use lock object for synchronization Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[GitHub] flink pull request #4173: [FLINK-6499] Migrate state configuration options

2017-06-23 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4173 [FLINK-6499] Migrate state configuration options Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your

[GitHub] flink pull request #3915: [FLINK-6352] Support to use timestamp to set the i...

2017-06-23 Thread zjureel
Github user zjureel closed the pull request at: https://github.com/apache/flink/pull/3915 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #3915: [FLINK-6352] Support to use timestamp to set the i...

2017-06-23 Thread zjureel
GitHub user zjureel reopened a pull request: https://github.com/apache/flink/pull/3915 [FLINK-6352] Support to use timestamp to set the initial offset of kafka Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list

[GitHub] flink issue #3915: [FLINK-6352] Support to use timestamp to set the initial ...

2017-06-23 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3915 @tzulitai I find there are many conficts between this PR and master, and I have fixed them. Please have a look when you are free, thanks --- If your project is set up for it, you can reply

[GitHub] flink issue #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-21 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3935 @zentol Thank you for your suggestions, and I have fixed the problems you mentioned :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #3935: [FLINK-6495] Migrate Akka configuration options

2017-05-18 Thread zjureel
Github user zjureel commented on a diff in the pull request: https://github.com/apache/flink/pull/3935#discussion_r117390018 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java --- @@ -28,31 +28,143 @@ @PublicEvolving public class

  1   2   >