[GitHub] [flink] KarmaGYZ edited a comment on issue #10746: [FLINK-15417] Remove the docker volume or mount when starting Mesos e…
KarmaGYZ edited a comment on issue #10746: [FLINK-15417] Remove the docker
volume or mount when starting Mesos e…
URL: https://github.com/apache/flink/pull/10746#issuecomment-581315998
@GJL
Thanks for your comments. That's really helpful. I've updated the PR and
test it on Ubuntu 18 and MacOS. It works well in both systems.
One minor concern, we may not redirect the error message of `rm -rf
${TEST_DATA_DIR}`. WDYT?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ edited a comment on issue #10746: [FLINK-15417] Remove the docker volume or mount when starting Mesos e…
KarmaGYZ edited a comment on issue #10746: [FLINK-15417] Remove the docker volume or mount when starting Mesos e… URL: https://github.com/apache/flink/pull/10746#issuecomment-574460501 - Regarding the `wait_job_terminal_state_mesos`, I still prefer the REST way. It will free our test from the fabricated contract with LOG. - Regarding the `copy_logs_from_container`, yes, you're right. The `chmod -R ugo+rw` looks good to me, but can you ensure this command will not meet permission issue? Maybe we need the `sudo` privilege here. If that makes sense to you, I'll update the PR asap. @GJL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] KarmaGYZ edited a comment on issue #10746: [FLINK-15417] Remove the docker volume or mount when starting Mesos e…
KarmaGYZ edited a comment on issue #10746: [FLINK-15417] Remove the docker volume or mount when starting Mesos e… URL: https://github.com/apache/flink/pull/10746#issuecomment-573974153 > will we always run into permission issues Sorry, I'm not sure about this. At least so far, I could not figure out what happens in [FLINK-15377](https://issues.apache.org/jira/browse/FLINK-15377) cause the permission issue. It always runs well on my local environment(MacOS). But I think this PR could prevent that happening again. > Another approach I have found is described here It sounds good, I give a try on this approach. However, I meet `addgroup: The GID '20' is already in use` issue. It seems this approach does not run well with MacOS. I'm not sure about that. https://github.com/pyro-ppl/pyro/issues/700#issuecomment-359984295 https://github.com/docker/docker-py/issues/1714 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
