[GitHub] [flink] StephanEwen commented on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor
StephanEwen commented on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor URL: https://github.com/apache/flink/pull/9646#issuecomment-530817767 I am also not sure why the runtime need to know about this interface. As far as I understand the current state of the FLIP-27 discussions, the `SourceReader` runs in a source operator (which handles the events, splits-to-checkpointed-state mapping, etc.). The runtime would interact only with that source operator. The fact that the source operator as a source reader internally seems like a detail that should not be leaking into the runtime. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor
StephanEwen commented on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor URL: https://github.com/apache/flink/pull/9646#issuecomment-530816761 I think in that case there should be a placeholder interface in `flink-runtime` that is used, instead of a preliminary version of `SourceReader`. That placeholder gets refactored/replaced by the proper source reader then. That placeholder should also have only the necessary methods, nothing about splits, start, etc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor
StephanEwen commented on issue #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor URL: https://github.com/apache/flink/pull/9646#issuecomment-530266736 FLIP 27 is not yet ready or voted on. The `SourceReader` interface is not yet converged, even the name of package is not agreed upon. We should not add this before those steps, it is otherwise leaving the code in a weird intermediate state that confuses users. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
