[GitHub] [flink] azagrebin commented on a change in pull request #12690: [FLINK-18186][doc] Various updates on standalone kubernetes document

2020-06-30 Thread GitBox


azagrebin commented on a change in pull request #12690:
URL: https://github.com/apache/flink/pull/12690#discussion_r447536097



##
File path: docs/ops/deployment/kubernetes.md
##
@@ -89,6 +93,7 @@ and use `kubectl` to terminate the common components:
 kubectl delete -f flink-configuration-configmap.yaml
 # if created then also the rest service
 kubectl delete -f jobmanager-rest-service.yaml
+kubectl delete -f taskmanager-query-state-service.yaml

Review comment:
   ```suggestion
   # if created then also the queryable state service
   kubectl delete -f taskmanager-query-state-service.yaml
   ```

##
File path: docs/ops/deployment/kubernetes.md
##
@@ -81,6 +81,10 @@ You can then access the Flink UI via different ways:
 
 {% highlight bash %}./bin/flink run -m : 
./examples/streaming/WordCount.jar{% endhighlight %}
 
+* Create a `NodePort` service on the query state service of taskmanager:

Review comment:
   by using `* ` you continue the list related to:
   `You can then access the Flink UI via different ways:`

##
File path: docs/ops/deployment/kubernetes.md
##
@@ -81,6 +81,10 @@ You can then access the Flink UI via different ways:
 
 {% highlight bash %}./bin/flink run -m : 
./examples/streaming/WordCount.jar{% endhighlight %}
 
+* Create a `NodePort` service on the query state service of taskmanager:

Review comment:
   ```suggestion
   You can also access the queryable state of TaskManager if you create a 
`NodePort` service for it:
   ```

##
File path: docs/ops/deployment/kubernetes.md
##
@@ -81,6 +81,10 @@ You can then access the Flink UI via different ways:
 
 {% highlight bash %}./bin/flink run -m : 
./examples/streaming/WordCount.jar{% endhighlight %}
 
+* Create a `NodePort` service on the query state service of taskmanager:
+1. Run `kubectl create -f taskmanager-query-state-service.yaml` to create 
the `NodePort` service on taskmanager. The example of 
`taskmanager-query-state-service.yaml` can be found in 
[appendix](#common-cluster-resource-definitions).
+2. Run `kubectl get svc flink-taskmanager-query-state` to know the 
`node-port` of this service. Then `QueryableStateClient(, 
)` could be used to submit the user queries.

Review comment:
   ```suggestion
   2. Run `kubectl get svc flink-taskmanager-query-state` to know the 
`node-port` of this service. Then you can create the 
[QueryableStateClient(, )]({{ site.baseurl 
}}/dev/stream/state/queryable_state.html#querying-state) to submit the state 
queries.
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] azagrebin commented on a change in pull request #12690: [FLINK-18186][doc] Various updates on standalone kubernetes document

2020-06-25 Thread GitBox


azagrebin commented on a change in pull request #12690:
URL: https://github.com/apache/flink/pull/12690#discussion_r445413795



##
File path: docs/ops/deployment/kubernetes.md
##
@@ -264,6 +264,24 @@ spec:
 component: jobmanager
 {% endhighlight %}
 
+`taskmanager-query-state-service.yaml`. Optional service, that exposes the 
taskmanager `query-state` port as public Kubernetes node's port.

Review comment:
   ```suggestion
   `taskmanager-query-state-service.yaml`. Optional service, that exposes the 
taskmanager port to access the queryable state as a public Kubernetes node's 
port.
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] azagrebin commented on a change in pull request #12690: [FLINK-18186][doc] Various updates on standalone kubernetes document

2020-06-25 Thread GitBox


azagrebin commented on a change in pull request #12690:
URL: https://github.com/apache/flink/pull/12690#discussion_r445413795



##
File path: docs/ops/deployment/kubernetes.md
##
@@ -264,6 +264,24 @@ spec:
 component: jobmanager
 {% endhighlight %}
 
+`taskmanager-query-state-service.yaml`. Optional service, that exposes the 
taskmanager `query-state` port as public Kubernetes node's port.

Review comment:
   ```suggestion
   `taskmanager-query-state-service.yaml`. Optional service, that exposes the 
TaskManager port to access the queryable state as a public Kubernetes node's 
port.
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] azagrebin commented on a change in pull request #12690: [FLINK-18186][doc] Various updates on standalone kubernetes document

2020-06-25 Thread GitBox


azagrebin commented on a change in pull request #12690:
URL: https://github.com/apache/flink/pull/12690#discussion_r445412890



##
File path: docs/ops/deployment/kubernetes.md
##
@@ -264,6 +264,24 @@ spec:
 component: jobmanager
 {% endhighlight %}
 
+`taskmanager-query-state-service.yaml`. Optional service, that exposes the 
taskmanager `query-state` port as public Kubernetes node's port.

Review comment:
   should we mention this service in `## Deploy Flink cluster on 
Kubernetes` chapter?
   like we describe `jobmanager-rest-service.yaml`:
   - after description of access REST API, we could mention that the 
`query-state` port can be accessed in a similar way.
   - add the optional `kubectl create/delete -f 
taskmanager-query-state-service.yaml` command





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] azagrebin commented on a change in pull request #12690: [FLINK-18186][doc] Various updates on standalone kubernetes document

2020-06-23 Thread GitBox


azagrebin commented on a change in pull request #12690:
URL: https://github.com/apache/flink/pull/12690#discussion_r444297993



##
File path: docs/ops/deployment/kubernetes.md
##
@@ -319,6 +341,8 @@ spec:
 ports:
 - containerPort: 6122
   name: rpc
+- containerPort: 6125

Review comment:
   Btw the user actually also needs a `Service` for the `query-state` port 
or something else, like we documented for REST. Maybe, this could be a 
follow-up improvement if not in this PR.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] azagrebin commented on a change in pull request #12690: [FLINK-18186][doc] Various updates on standalone kubernetes document

2020-06-23 Thread GitBox


azagrebin commented on a change in pull request #12690:
URL: https://github.com/apache/flink/pull/12690#discussion_r444262305



##
File path: docs/ops/deployment/kubernetes.md
##
@@ -365,14 +384,12 @@ spec:
 - name: jobmanager
   image: flink:{% if site.is_stable 
%}{{site.version}}-scala{{site.scala_version_suffix}}{% else %}latest{% endif %}
   env:
-  args: ["standalone-job", "--job-classname", "com.job.ClassName", 
["--job-id", "",] ["--fromSavepoint", "/path/to/savepoint", 
["--allowNonRestoredState",]] [job arguments]]
+  args: ["standalone-job", "--job-classname", "com.job.ClassName", 
"--job-id", "", "--fromSavepoint", "/path/to/savepoint", 
"--allowNonRestoredState", ]

Review comment:
   ```suggestion
 args: ["standalone-job", "--job-classname", "com.job.ClassName", 
, ] # optional arguments: ["--job-id", "", "--fromSavepoint", "/path/to/savepoint", "--allowNonRestoredState"]
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org