[GitHub] [flink] caidezhi commented on issue #10333: [FLINK-14970]Doomed test for equality to NaN
caidezhi commented on issue #10333: [FLINK-14970]Doomed test for equality to NaN URL: https://github.com/apache/flink/pull/10333#issuecomment-562848900 Thanks Kurt. refine PR as you suggested. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] caidezhi commented on issue #10333: [FLINK-14970]Doomed test for equality to NaN
caidezhi commented on issue #10333: [FLINK-14970]Doomed test for equality to NaN URL: https://github.com/apache/flink/pull/10333#issuecomment-562519709 Only ` Double.NaN` does't work. I update the Jira issue description and the type as "Improvement-Trivial". Deleting the `NaN` test seems not worth a PR. Sorry for causing any inconvenience, will be more careful in future. (Thanks for your patience :) ) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] caidezhi commented on issue #10333: [FLINK-14970]Doomed test for equality to NaN
caidezhi commented on issue #10333: [FLINK-14970]Doomed test for equality to NaN URL: https://github.com/apache/flink/pull/10333#issuecomment-562493939 Hi @KurtYoung , i also aware of that. Calcite uses BigDecimal for handling DOUBLE, FLOAT. when we pass unnormal numerical value((eg: INFINITY, NaN) literalType=DoubleType, literalValue=null are passed to method "GenerateUtils.generateLiteral", the program will go to another branch, the pattern matching which has bug will not cause any impact. can we just remove the pattern matching logic to make it clean? if it is ok, i will make another commit for this PR. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] caidezhi commented on issue #10333: [FLINK-14970]Doomed test for equality to NaN
caidezhi commented on issue #10333: [FLINK-14970]Doomed test for equality to NaN
URL: https://github.com/apache/flink/pull/10333#issuecomment-562123413
hi @KurtYoung the latest build failed("misc" module ), but it is not related
to the PR. Do you think it is required to trigger another build?(the travis-ci
seems quite busy, a request may stay in the queue for a whole day :( )
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] caidezhi commented on issue #10333: [FLINK-14970]Doomed test for equality to NaN
caidezhi commented on issue #10333: [FLINK-14970]Doomed test for equality to NaN URL: https://github.com/apache/flink/pull/10333#issuecomment-561093093 @KurtYoung I have add some UT cases as you suggested. Would you please help to review? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
