[GitHub] [flink] dianfu commented on issue #11055: [FLINK-15990][table] Remove register source and sink in ConnectTableDescriptor

2020-02-11 Thread GitBox
dianfu commented on issue #11055: [FLINK-15990][table] Remove register source 
and sink in ConnectTableDescriptor
URL: https://github.com/apache/flink/pull/11055#issuecomment-584620126
 
 
   @JingsongLi Thanks for the quick update! +1 from my side.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] dianfu commented on issue #11055: [FLINK-15990][table] Remove register source and sink in ConnectTableDescriptor

2020-02-11 Thread GitBox
dianfu commented on issue #11055: [FLINK-15990][table] Remove register source 
and sink in ConnectTableDescriptor
URL: https://github.com/apache/flink/pull/11055#issuecomment-584607034
 
 
   @JingsongLi Thanks for the PR. There are still a few files which should also 
be updated, e.g. test_udf.py, test_table_environment_api.py, python_shell.md, 
etc. Could you search the key words and make sure that all places are updated? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services