[GitHub] [flink] godfreyhe commented on a change in pull request #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner

2019-08-15 Thread GitBox
godfreyhe commented on a change in pull request #9433: [FLINK-13708] 
[table-planner-blink] transformations should be cleared after execution in 
blink planner
URL: https://github.com/apache/flink/pull/9433#discussion_r314556026
 
 

 ##
 File path: 
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala
 ##
 @@ -75,4 +84,41 @@ class TableEnvironmentTest {
   "  LogicalTableScan(table=[[default_catalog, default_database, 
MyTable]])\n"
 assertEquals(expected, actual)
   }
+
+  @Test
+  def testExecuteTwiceUsingSameTableEnv(): Unit = {
+val settings = 
EnvironmentSettings.newInstance().useBlinkPlanner().inBatchMode().build()
 
 Review comment:
   added `TableEnvironmentITCase` to test batch and stream


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [flink] godfreyhe commented on a change in pull request #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner

2019-08-14 Thread GitBox
godfreyhe commented on a change in pull request #9433: [FLINK-13708] 
[table-planner-blink] transformations should be cleared after execution in 
blink planner
URL: https://github.com/apache/flink/pull/9433#discussion_r314159071
 
 

 ##
 File path: 
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala
 ##
 @@ -75,4 +84,41 @@ class TableEnvironmentTest {
   "  LogicalTableScan(table=[[default_catalog, default_database, 
MyTable]])\n"
 assertEquals(expected, actual)
   }
+
+  @Test
+  def testExecuteTwiceUsingSameTableEnv(): Unit = {
+val settings = 
EnvironmentSettings.newInstance().useBlinkPlanner().inBatchMode().build()
+val tEnv = TableEnvironmentImpl.create(settings)
 
 Review comment:
   use impl class instead of interface class to avoid error: "Static methods in 
interface require -target:jvm-1.8" in scala


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services