[GitHub] [flink] kl0u commented on issue #10346: [FLINK-14972] Make Remote(Stream)Environment use Executors.

2019-12-03 Thread GitBox
kl0u commented on issue #10346: [FLINK-14972] Make Remote(Stream)Environment use Executors. URL: https://github.com/apache/flink/pull/10346#issuecomment-561106046 Thanks for the comments @TisonKun @aljoscha and @tweise . Merged

[GitHub] [flink] kl0u commented on issue #10346: [FLINK-14972] Make Remote(Stream)Environment use Executors.

2019-11-30 Thread GitBox
kl0u commented on issue #10346: [FLINK-14972] Make Remote(Stream)Environment use Executors. URL: https://github.com/apache/flink/pull/10346#issuecomment-559954470 @TisonKun The old `RemoteExecutor` is still used by the `ScalaShell` and that is why it is not removed in this PR. As soon as

[GitHub] [flink] kl0u commented on issue #10346: [FLINK-14972] Make Remote(Stream)Environment use Executors.

2019-11-29 Thread GitBox
kl0u commented on issue #10346: [FLINK-14972] Make Remote(Stream)Environment use Executors. URL: https://github.com/apache/flink/pull/10346#issuecomment-559820381 Thanks a lot @TisonKun and also I believe that now with the `Executors`, the reason why this method was introduced does not

[GitHub] [flink] kl0u commented on issue #10346: [FLINK-14972] Make Remote(Stream)Environment use Executors.

2019-11-29 Thread GitBox
kl0u commented on issue #10346: [FLINK-14972] Make Remote(Stream)Environment use Executors. URL: https://github.com/apache/flink/pull/10346#issuecomment-559814745 I rebased to the master. This is an automated message from

[GitHub] [flink] kl0u commented on issue #10346: [FLINK-14972] Make Remote(Stream)Environment use Executors.

2019-11-28 Thread GitBox
kl0u commented on issue #10346: [FLINK-14972] Make Remote(Stream)Environment use Executors. URL: https://github.com/apache/flink/pull/10346#issuecomment-559691884 I addressed the comments. Let me know if now it is good to merge @TisonKun and @aljoscha

[GitHub] [flink] kl0u commented on issue #10346: [FLINK-14972] Make Remote(Stream)Environment use Executors.

2019-11-28 Thread GitBox
kl0u commented on issue #10346: [FLINK-14972] Make Remote(Stream)Environment use Executors. URL: https://github.com/apache/flink/pull/10346#issuecomment-559450678 @aljoscha I integrated your comments. This is an automated