[GitHub] [flink] lirui-apache commented on issue #9217: [FLINK-13277][hive] add documentation of Hive source/sink

2019-08-15 Thread GitBox
lirui-apache commented on issue #9217: [FLINK-13277][hive] add documentation of Hive source/sink URL: https://github.com/apache/flink/pull/9217#issuecomment-521864363 @bowenli86 Thanks for letting me know. I have synced the changes to zh docs. --

[GitHub] [flink] lirui-apache commented on issue #9217: [FLINK-13277][hive] add documentation of Hive source/sink

2019-08-14 Thread GitBox
lirui-apache commented on issue #9217: [FLINK-13277][hive] add documentation of Hive source/sink URL: https://github.com/apache/flink/pull/9217#issuecomment-521500667 @xuefuz @bowenli86 PR updated according to your feedbacks.

[GitHub] [flink] lirui-apache commented on issue #9217: [FLINK-13277][hive] add documentation of Hive source/sink

2019-08-14 Thread GitBox
lirui-apache commented on issue #9217: [FLINK-13277][hive] add documentation of Hive source/sink URL: https://github.com/apache/flink/pull/9217#issuecomment-521159013 @bowenli86 @xuefuz I have updated the PR to address your comments. And since we have decided not to support timestamp in 1.

[GitHub] [flink] lirui-apache commented on issue #9217: [FLINK-13277][hive] add documentation of Hive source/sink

2019-08-13 Thread GitBox
lirui-apache commented on issue #9217: [FLINK-13277][hive] add documentation of Hive source/sink URL: https://github.com/apache/flink/pull/9217#issuecomment-520731616 Given that we already have `read_write_hive.md`, maybe we don't need a section for Hive connector in `connectors.md`. What

[GitHub] [flink] lirui-apache commented on issue #9217: [FLINK-13277][hive] add documentation of Hive source/sink

2019-07-24 Thread GitBox
lirui-apache commented on issue #9217: [FLINK-13277][hive] add documentation of Hive source/sink URL: https://github.com/apache/flink/pull/9217#issuecomment-514586651 Hive table source and sink are not mentioned in the doc since they're not meant to be public APIs. @xuefuz @zjuwangg ple