[GitHub] [flink] lirui-apache commented on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo …
lirui-apache commented on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo … URL: https://github.com/apache/flink/pull/9432#issuecomment-530206036 Updated to revert unnecessary changes. @bowenli86 Please take a look. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] lirui-apache commented on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo …
lirui-apache commented on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo … URL: https://github.com/apache/flink/pull/9432#issuecomment-528797477 Managed to add tests to verify this PR works with both new and old type systems. @bowenli86 @xuefuz @zjuwangg please have a look. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] lirui-apache commented on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo …
lirui-apache commented on issue #9432: [FLINK-13653][sql-client] ResultStore should avoid using RowTypeInfo … URL: https://github.com/apache/flink/pull/9432#issuecomment-521538668 > the JIRA ticket mentioned that "As a result, querying a Hive table with decimal column from SQL CLI will hit the following exception", can we add a test showing the problem is covered now? We can't because we don't have integration tests for LocalExecutor and Hive connector ... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
