[GitHub] [flink] pnowojski commented on a change in pull request #11071: [FLINK-16019][runtime] fix ContinuousFileReaderOperator error handling
pnowojski commented on a change in pull request #11071: [FLINK-16019][runtime]
fix ContinuousFileReaderOperator error handling
URL: https://github.com/apache/flink/pull/11071#discussion_r378697278
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
##
@@ -449,7 +450,7 @@ private void cleanUp() {
try {
r.run();
} catch (Exception e) {
- firstException =
ExceptionUtils.firstOrSuppressed(firstException, e);
+ firstException =
ExceptionUtils.firstOrSuppressed(e, firstException);
Review comment:
> the only difference will be in error message and stacktrace.
Isn't that's the whole point of using `firstOrSuppressed` - to have the
correct exception message?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #11071: [FLINK-16019][runtime] fix ContinuousFileReaderOperator error handling
pnowojski commented on a change in pull request #11071: [FLINK-16019][runtime]
fix ContinuousFileReaderOperator error handling
URL: https://github.com/apache/flink/pull/11071#discussion_r378696814
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
##
@@ -380,10 +380,11 @@ public void processWatermark(Watermark mark) throws
Exception {
public void dispose() throws Exception {
Exception e = null;
if (state != ReaderState.CLOSED) {
+ state = ReaderState.CLOSED;
Review comment:
If it's not worth testing, then why do we need this code?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #11071: [FLINK-16019][runtime] fix ContinuousFileReaderOperator error handling
pnowojski commented on a change in pull request #11071: [FLINK-16019][runtime]
fix ContinuousFileReaderOperator error handling
URL: https://github.com/apache/flink/pull/11071#discussion_r378696814
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
##
@@ -380,10 +380,11 @@ public void processWatermark(Watermark mark) throws
Exception {
public void dispose() throws Exception {
Exception e = null;
if (state != ReaderState.CLOSED) {
+ state = ReaderState.CLOSED;
Review comment:
If it's not worth testing, then do we need this code?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #11071: [FLINK-16019][runtime] fix ContinuousFileReaderOperator error handling
pnowojski commented on a change in pull request #11071: [FLINK-16019][runtime]
fix ContinuousFileReaderOperator error handling
URL: https://github.com/apache/flink/pull/11071#discussion_r378317546
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
##
@@ -449,7 +450,7 @@ private void cleanUp() {
try {
r.run();
} catch (Exception e) {
- firstException =
ExceptionUtils.firstOrSuppressed(firstException, e);
+ firstException =
ExceptionUtils.firstOrSuppressed(e, firstException);
Review comment:
Could we add some simple test for this bug?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #11071: [FLINK-16019][runtime] fix ContinuousFileReaderOperator error handling
pnowojski commented on a change in pull request #11071: [FLINK-16019][runtime]
fix ContinuousFileReaderOperator error handling
URL: https://github.com/apache/flink/pull/11071#discussion_r378316796
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
##
@@ -380,10 +380,11 @@ public void processWatermark(Watermark mark) throws
Exception {
public void dispose() throws Exception {
Exception e = null;
if (state != ReaderState.CLOSED) {
+ state = ReaderState.CLOSED;
Review comment:
I guess we could add a test simple test coverage for this `state =
ReaderState.CLOSED`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
