[GitHub] [flink] pnowojski commented on a change in pull request #9646: [FLINK-14004][runtime] Define SourceReaderOperator to verify the integration with StreamOneInputProcessor
pnowojski commented on a change in pull request #9646: [FLINK-14004][runtime]
Define SourceReaderOperator to verify the integration with
StreamOneInputProcessor
URL: https://github.com/apache/flink/pull/9646#discussion_r333898900
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceReaderOperator.java
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api.operators;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.streaming.runtime.io.PushingAsyncDataInput;
+
+/**
+ * Base source operator only used for integrating the source reader which is
proposed by FLIP-27. It implements
+ * the interface of {@link PushingAsyncDataInput} for naturally compatible
with one input processing in runtime
+ * stack.
+ *
+ * @param The output type of the operator
+ */
+@PublicEvolving
+public abstract class SourceReaderOperator extends
AbstractStreamOperator implements PushingAsyncDataInput {
Review comment:
nit: maybe add a note, that we are expecting this to be changed to the
concrete class once `SourceReader` interface is introduced?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #9646: [FLINK-14004][runtime] Define SourceReaderOperator to verify the integration with StreamOneInputProcessor
pnowojski commented on a change in pull request #9646: [FLINK-14004][runtime]
Define SourceReaderOperator to verify the integration with
StreamOneInputProcessor
URL: https://github.com/apache/flink/pull/9646#discussion_r333898651
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceReaderOperator.java
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api.operators;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.streaming.runtime.io.PushingAsyncDataInput;
+
+/**
+ * Base source operator only used for integrating the source reader which is
proposed by FLIP-27. It implements
+ * the interface of {@link PushingAsyncDataInput} for naturally compatible
with one input processing in runtime
+ * stack.
+ *
+ * @param The output type of the operator
+ */
+@PublicEvolving
Review comment:
I think I would mark it as `Internal` and let the API folks later decide
whether to expose this, or just the `SourceReader`. (Imo there is no need to
expose the `SourceReaderOperator`).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
