[GitHub] [flink] vthinkxie commented on issue #11498: [FLINK-16741][WEB] add tm log list & tm log detail page
vthinkxie commented on issue #11498: [FLINK-16741][WEB] add tm log list & tm log detail page URL: https://github.com/apache/flink/pull/11498#issuecomment-604973557 > > Hi, it is ok to hide the log name from the UI, but it would have a log name when user click the download button, what name should the file be named then? > > Previously it was `taskmanager__log`. Since this can be already considered an inconsistency, maybe we don't have to hide the log name. ok, I will update the display name to `taskmanager__log` too This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] vthinkxie commented on issue #11498: [FLINK-16741][WEB] add tm log list & tm log detail page
vthinkxie commented on issue #11498: [FLINK-16741][WEB] add tm log list & tm log detail page URL: https://github.com/apache/flink/pull/11498#issuecomment-604963480 > The changes look fine now. > > I have one more question: The log files appear to be listed not in a particular order (see screenshot below). Does it make sense to define a better ordering on the listed log files, e.g., lexicographical or last modification date? > >  it follows the sequence from the restAPI, I can sort it based on the filename or the filesize (not the modify date since not returned by the restAPI), but I'm not sure if it is a good idea. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] vthinkxie commented on issue #11498: [FLINK-16741][WEB] add tm log list & tm log detail page
vthinkxie commented on issue #11498: [FLINK-16741][WEB] add tm log list & tm log detail page URL: https://github.com/apache/flink/pull/11498#issuecomment-604962215 > One minor inaccuracy I have found is that when accessing the TM primary log file directly, the filename is rendered as `taskmanager.log`. > >  > > However, currently the only way to resolve this is to not render the filename when accessing the primary log directly. What do you think about this? Hi, it is ok to hide the log name from the UI, but it would have a log name when user click the download button, what name should the file be named then? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] vthinkxie commented on issue #11498: [FLINK-16741][WEB] add tm log list & tm log detail page
vthinkxie commented on issue #11498: [FLINK-16741][WEB] add tm log list & tm log detail page URL: https://github.com/apache/flink/pull/11498#issuecomment-604804589  Hi @GJL I added a compact mode to the `flink-refresh-download` component, it would fix the style error in job manager. The UI of jobmanager's log will be same as taskmanager after https://issues.apache.org/jira/browse/FLINK-16303 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] vthinkxie commented on issue #11498: [FLINK-16741][WEB] add tm log list & tm log detail page
vthinkxie commented on issue #11498: [FLINK-16741][WEB] add tm log list & tm log detail page URL: https://github.com/apache/flink/pull/11498#issuecomment-604440726 > I think it's inconvenient that on the JM log page the Reload/Download/Fullscreen buttons overlap with the logs. Fullscreen does not appear to have a function at the moment. > >  sorry for the style error in the jm page, will update it soon This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] vthinkxie commented on issue #11498: [FLINK-16741][WEB] add tm log list & tm log detail page
vthinkxie commented on issue #11498: [FLINK-16741][WEB] add tm log list & tm log detail page URL: https://github.com/apache/flink/pull/11498#issuecomment-603130976 cc @hsuanxyz This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
