[GitHub] [flink] wangyang0918 commented on a change in pull request #10852: [FLINK-15564][yarn][test] Fix YarnClusterDescriptorTest that failed to validate the original intended behavior

2020-01-14 Thread GitBox 
wangyang0918 commented on a change in pull request #10852: 
[FLINK-15564][yarn][test] Fix YarnClusterDescriptorTest that failed to validate 
the original intended behavior
URL: https://github.com/apache/flink/pull/10852#discussion_r366282296
 
 

 ##
 File path: 
flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
 ##
 @@ -115,6 +113,7 @@ public void testFailIfTaskSlotsHigherThanMaxVcores() 
throws ClusterDeploymentExc
 
fail("The deploy call should have failed.");
} catch (ClusterDeploymentException e) {
+   e.printStackTrace();
 
 Review comment:
   Why do we need `e.printStackTrace()`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wangyang0918 commented on a change in pull request #10852: [FLINK-15564][yarn][test] Fix YarnClusterDescriptorTest that failed to validate the original intended behavior

2020-01-14 Thread GitBox 
wangyang0918 commented on a change in pull request #10852: 
[FLINK-15564][yarn][test] Fix YarnClusterDescriptorTest that failed to validate 
the original intended behavior
URL: https://github.com/apache/flink/pull/10852#discussion_r366282419
 
 

 ##
 File path: 
flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
 ##
 @@ -104,9 +104,7 @@ public void testFailIfTaskSlotsHigherThanMaxVcores() 
throws ClusterDeploymentExc
clusterDescriptor.setLocalJarPath(new Path(flinkJar.getPath()));
 
ClusterSpecification clusterSpecification = new 
ClusterSpecification.ClusterSpecificationBuilder()
-   .setMasterMemoryMB(1)
-   .setTaskManagerMemoryMB(1)
-   .setNumberTaskManagers(1)
+   .setTaskManagerMemoryMB(1024)
 
 Review comment:
   Do we really need to set the `TaskManagerMemoryMB` to 1024? Or the default 
value(768) is enough. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wangyang0918 commented on a change in pull request #10852: [FLINK-15564][yarn][test] Fix YarnClusterDescriptorTest that failed to validate the original intended behavior

2020-01-14 Thread GitBox 
wangyang0918 commented on a change in pull request #10852: 
[FLINK-15564][yarn][test] Fix YarnClusterDescriptorTest that failed to validate 
the original intended behavior
URL: https://github.com/apache/flink/pull/10852#discussion_r366282542
 
 

 ##
 File path: 
flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
 ##
 @@ -137,10 +136,7 @@ public void testConfigOverwrite() throws 
ClusterDeploymentException {
 
// configure slots
ClusterSpecification clusterSpecification = new 
ClusterSpecification.ClusterSpecificationBuilder()
-   .setMasterMemoryMB(1)
-   .setTaskManagerMemoryMB(1)
-   .setNumberTaskManagers(1)
-   .setSlotsPerTaskManager(1)
+   .setTaskManagerMemoryMB(1024)
 
 Review comment:
   Same as above.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services