xuefuz commented on a change in pull request #9457: [FLINK-13741][table]
FunctionCatalog.getUserDefinedFunctions() should include Flink built-in
functions' names
URL: https://github.com/apache/flink/pull/9457#discussion_r314539092
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionCatalog.java
##########
@@ -226,7 +235,8 @@ private void registerFunction(String name,
FunctionDefinition functionDefinition
userFunctions.put(normalizeName(name), functionDefinition);
}
- private String normalizeName(String name) {
+ @VisibleForTesting
+ protected static String normalizeName(String name) {
Review comment:
It seems that the scope can be "package" level. "protected" doesn't seem
applicable since this is a static method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
