[GitHub] [flink] zentol commented on a change in pull request #12447: [FLINK-18069][CI] Test if Java/Scaladocs builds are passing in the compile stage
zentol commented on a change in pull request #12447: URL: https://github.com/apache/flink/pull/12447#discussion_r435196901 ## File path: tools/ci/compile.sh ## @@ -54,10 +54,22 @@ if [ $EXIT_CODE != 0 ]; then exit $EXIT_CODE fi -echo " Checking Scaladocs " +echo " Checking Javadocs and Scaladocs " + +# use the same invocation as on buildbot (https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/flink.conf) +run_mvn javadoc:aggregate -Paggregate-scaladoc -DadditionalJOption='-Xdoclint:none' \ Review comment: shouldn't matter whether it goes into stdout/stderr; you could just pipe everything into a file and dump the whole thing if an error happened. Basically a simplified version of what you already did for scala, which should at most be a 1 minute fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #12447: [FLINK-18069][CI] Test if Java/Scaladocs builds are passing in the compile stage
zentol commented on a change in pull request #12447: URL: https://github.com/apache/flink/pull/12447#discussion_r435040079 ## File path: tools/ci/compile.sh ## @@ -54,10 +54,22 @@ if [ $EXIT_CODE != 0 ]; then exit $EXIT_CODE fi -echo " Checking Scaladocs " +echo " Checking Javadocs and Scaladocs " + +# use the same invocation as on buildbot (https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/flink.conf) +run_mvn javadoc:aggregate -Paggregate-scaladoc -DadditionalJOption='-Xdoclint:none' \ Review comment: same deal as scala, move the output into a file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #12447: [FLINK-18069][CI] Test if Java/Scaladocs builds are passing in the compile stage
zentol commented on a change in pull request #12447: URL: https://github.com/apache/flink/pull/12447#discussion_r434491456 ## File path: tools/ci/compile.sh ## @@ -43,39 +43,39 @@ echo "== EXIT_CODE=0 run_mvn clean install $MAVEN_OPTS -Dflink.convergence.phase=install -Pcheck-convergence -Dflink.forkCount=2 \ --Dflink.forkCountTestPackage=2 -Dmaven.javadoc.skip=true -U -DskipTests Review comment: it may make sense to instead build the javadocs exactly like we do on buildbot: `mvn javadoc:aggregate -Paggregate-scaladoc -DadditionalJOption="-Xdoclint:none" -Dmaven.javadoc.failOnError=false -Dcheckstyle.skip=true -Denforcer.skip=true -Dheader="http://flink.apache.org/\; target=\"_top\">Back to Flink Website"` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
