[GitHub] Xpray commented on issue #7014: [FLINK-10770] [Table & SQL] Some generated functions are not opened properly.

2018-11-07 Thread GitBox
Xpray commented on issue #7014: [FLINK-10770] [Table & SQL] Some generated functions are not opened properly. URL: https://github.com/apache/flink/pull/7014#issuecomment-436575363 Covering full lifecycle of generated functions looks good to me, but I think we should avoid adding new

[GitHub] Xpray commented on issue #7014: [FLINK-10770] [Table & SQL] Some generated functions are not opened properly.

2018-11-07 Thread GitBox
Xpray commented on issue #7014: [FLINK-10770] [Table & SQL] Some generated functions are not opened properly. URL: https://github.com/apache/flink/pull/7014#issuecomment-436563611 Hi @jrthe42 , Thanks for the contribution. It seems you did not add test case to every generate function you