[GitHub] Xpray commented on issue #7014: [FLINK-10770] [Table & SQL] Some generated functions are not opened properly.
Xpray commented on issue #7014: [FLINK-10770] [Table & SQL] Some generated functions are not opened properly. URL: https://github.com/apache/flink/pull/7014#issuecomment-436575363 Covering full lifecycle of generated functions looks good to me, but I think we should avoid adding new ItTest file. @hequn8128 what do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Xpray commented on issue #7014: [FLINK-10770] [Table & SQL] Some generated functions are not opened properly.
Xpray commented on issue #7014: [FLINK-10770] [Table & SQL] Some generated functions are not opened properly. URL: https://github.com/apache/flink/pull/7014#issuecomment-436563611 Hi @jrthe42 , Thanks for the contribution. It seems you did not add test case to every generate function you modified, are all these generate functions be short of initialization? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
