[GitHub] flink issue #2304: [FLINK-4268] [core] Add parsers for BigDecimal/BigInteger
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2304 Thanks again for the review @fhueske. I will fix your comments and merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2304: [FLINK-4268] [core] Add parsers for BigDecimal/BigInteger
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2304 @fhueske I improved the big decimal parsing. Now less objects are created. I hope I didn't introduce new bugs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2304: [FLINK-4268] [core] Add parsers for BigDecimal/BigInteger
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2304 Thanks @twalthr, PR looks good. Only added a hint how String creations can be avoided. Good to merge otherwise. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
