[GitHub] flink issue #2367: [FLINK-3703][cep] Add sequence matching semantics to disc...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2367 @kl0u Sure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2367: [FLINK-3703][cep] Add sequence matching semantics to disc...
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2367 Hi @mushketyk . I am trying to clean up a bit the open PRs for the CEP library and the related JIRAs. The issue that this PR covers was already implemented as part of multiple other features that I also mention in the related JIRA. Could you close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2367: [FLINK-3703][cep] Add sequence matching semantics to disc...
Github user LordFB commented on the issue: https://github.com/apache/flink/pull/2367 Hi @mushketyk, too bad, with this missing it is kind of a gamebreaker for Flink in my Use Case. Jeah, that'd be great, if Till would show some action on this and the related PRs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2367: [FLINK-3703][cep] Add sequence matching semantics to disc...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2367 Hi @LordFB I don't think there is currently a way to do it in cep-flink. I am still waiting for Till's review for this PR, but he seems to be really busy with other work. Maybe together we will be able to convince him to spend some time on reviewing this and similar CEP PRs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2367: [FLINK-3703][cep] Add sequence matching semantics to disc...
Github user LordFB commented on the issue: https://github.com/apache/flink/pull/2367 Hi @mushketyk and @tillrohrmann, are there any updates on this Pull Request? Or is there already a way to change the matching behaviour in FlinkCEP? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2367: [FLINK-3703][cep] Add sequence matching semantics to disc...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2367 Hi @tillrohrmann I've updated the PR according to your review. I had to add reverse reverse edges to buffer entries and changed the interface of the SharedBuffer a bit to move code from it to the NFA class. I hope I didn't break the encapsulation too much, so I would to see your opinion about this. I also added more tests and user documentation in this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2367: [FLINK-3703][cep] Add sequence matching semantics to disc...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2367 @tillrohrmann Thank you for the very detailed review. I do appreciate it. I agree with your suggestions and I'll try to improve the code and write documentation in the next couple of days. At the very least I know that tests are correct, so I can start changing the implementation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2367: [FLINK-3703][cep] Add sequence matching semantics to disc...
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2367 Thanks for your contribution and apologies for the late review @mushketyk. I think your implementation goes into the right direction and I really like the testing. I think what we still can and should improve is to pull out the `MatchingBehaviour` out of the `SharedBuffer` and the `State`. The `NFA` should be the only component which is responsible for the matching behaviour. I think we can achieve this if we pimp the `SharedBuffer` a little bit. So what should roughly happen is that the `NFA` removes computation states which are not longer valid. Furthermore, we have to clean up the `SharedBuffer` and remove `SharedBufferEntries` which depend on other `SharedBufferEntries` which are no longer valid (e.g. due to `MatchingBehaviour.afterLast`). So when you have a `SharedBufferEntry` representing a certain state which is part of the currently matched sequence and `MatchingBehaviour.afterLast`, then you have to find out all `SharedBufferEntries` which depend on this state (children) and remove them. That you have to do until you reach the youngest descendant. Currently we can only find the predecessors for a given `SharedBufferEntry` but not the children. I think that would have to be added in order to implement the different `MatchingBehaviours`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
