[GitHub] flink issue #2465: [FLINK-4447] [docs] Include NettyConfig options on Config...
Github user uce commented on the issue: https://github.com/apache/flink/pull/2465 Hey @greghogan Do you think you have time to add the note you mentioned and then merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2465: [FLINK-4447] [docs] Include NettyConfig options on Config...
Github user uce commented on the issue: https://github.com/apache/flink/pull/2465 Very good! +1 to add this with a note that the defaults should work fine out of the box. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2465: [FLINK-4447] [docs] Include NettyConfig options on Config...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2465 I think this is good, please add. It may make sense to have a comment at the top that states that these are advanced network options that one typically does not have to touch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2465: [FLINK-4447] [docs] Include NettyConfig options on Config...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2465 Hi @greghogan thanks for the PR. Took a look at it and seems good to go. The test failure doesn't seem related. Since I'm new to the community, I would probably ask someone else to have a look as well. @uce , if you can have a pass over this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
