Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2541
Thanks, picking this pull request up and merging it...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2541
@StephanEwen review it again please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2541
> In general, I think it is good to not have too many method options, but
only those that add significant functionality. For the method that starts the
WebUI, that is the case, for the method with
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2541
Sorry for asking for another iteration, but here are some comments:
- The other Java code uses the primitive `int` everywhere, rather than
the boxed integer. Let's follow that style.
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2541
@StephanEwen have any improvement needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2541
Okay, this has binary compatibility now.
Few things I would still suggest to do:
- There is still a bug that the `parallelism` and `port` parameter are
mixed up.
- It still does
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2541
@StephanEwen Iâve a new function name `createCustomLocalEnv`. Sorry for
late ack.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2541
Code looks good, but the build detected a break in binary compatibility.
Have a look at the Travis logs.
Changing the `createLocalEnvironment` to use an additional parameter with
