[GitHub] flink issue #2562: [FLINK-4691] [table] Add group-windows for streaming tabl...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2562 @fhueske I updated the PR. The only thing that is missing now are tests for the `DataStreamAggregate` class. I will add unit tests tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2562: [FLINK-4691] [table] Add group-windows for streaming tabl...
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2562 Thanks for the update @twalthr. I'll review #2595 first and continue with this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2562: [FLINK-4691] [table] Add group-windows for streaming tabl...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2562 @fhueske I have implemented the window properties as an additional parameter instead of aggregation functions. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2562: [FLINK-4691] [table] Add group-windows for streaming tabl...
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2562 Thanks for reviewing this PR @fhueske. I hope I could fix all the feedback you gave me. I also added documentation for the website in my last commit. Regarding the two big changes you mentioned: 1. IMHO window properties also summarize the data. So they can be considered as an aggregation of the data in a window. I also chose this approach to keep the code clean and readable (window properties and aggregations have more in common than window properties and grouping keys). Otherwise we have to somehow hack the window property into the record after the aggregation happened. I will try to improve this but I'm not sure if the outcome will be a nicer solution. 2. Once #2595 is merged I will rebase this PR and convert ITCases to unit tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
