[GitHub] flink issue #2570: [FLINK-3674] Add an interface for Time aware User Functio...
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/2570 Rebased version looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2570: [FLINK-3674] Add an interface for Time aware User Functio...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2570 I updated this on top of the latest master with @StefanRRichter's state changes. Please take another look, @StefanRRichter. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2570: [FLINK-3674] Add an interface for Time aware User Functio...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2570 Thanks for your comments @StefanRRichter and @kl0u. I incorporated most of them by now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2570: [FLINK-3674] Add an interface for Time aware User Functio...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2570 Thanks a lot for the review, @StefanRRichter! I addressed most comments by writing code, for some I only gave an answer that describes the rational. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2570: [FLINK-3674] Add an interface for Time aware User Functio...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2570 R: @StefanRRichter @kl0u could you please review again, I pushed some changes and rebased on top of master. Each commit can stand on its own and the purpose of each commit is documented in the commit message so you should probably review this commit by commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2570: [FLINK-3674] Add an interface for Time aware User Functio...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2570 This PR disables `RescalingITCase` because the timers are checkpointed using the legacy/deprecated `StreamCheckpointedOperator` interface. (`AbstractStreamOperator` implements the interface because it keeps the timers.) The tests can be reactivated once @kl0u gets in his work on making the timers key-group aware. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
