Github user uce commented on the issue:
https://github.com/apache/flink/pull/2608
Local Travis passed except for an independent Cassandra test failure
(https://travis-ci.org/uce/flink/builds/167107635). Going to merge this.
---
If your project is set up for it, you can reply to this
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2608
+1 to the general approach and the code
Some suggestions for name polishing:
- How about renaming `DISCARD_ON_CANCELLATION` to
`DELETE_ON_CANCELLATION`? That would sound more explic
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2608
Addressed all comments except Exception narrowing which I would like to
leave open as follow ups as they were not introduced with this PR. Thanks
again! I will wait for Travis and then merge this if ther
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2608
Thank you very much for the thorough review. I will address the comments
now and update the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2608
Tested the changes locally. I took a savepoint with and without explicit
savepoint directory and resumed from there. Both seemed to work without a
problem :-)
---
If your project is set up for
