[GitHub] flink issue #2612: FLINK-4771: Compression for AvroOutputFormat

2016-10-14 Thread fhueske
Github user fhueske commented on the issue:

https://github.com/apache/flink/pull/2612
  
Merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #2612: FLINK-4771: Compression for AvroOutputFormat

2016-10-14 Thread qingdao81
Github user qingdao81 commented on the issue:

https://github.com/apache/flink/pull/2612
  
Thats good news :-) Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #2612: FLINK-4771: Compression for AvroOutputFormat

2016-10-14 Thread fhueske
Github user fhueske commented on the issue:

https://github.com/apache/flink/pull/2612
  
Thanks for the update @qingdao81!
PR is good to merge :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink issue #2612: FLINK-4771: Compression for AvroOutputFormat

2016-10-11 Thread qingdao81
Github user qingdao81 commented on the issue:

https://github.com/apache/flink/pull/2612
  
Thanks for the review @fhueske I implemented the changes you requested. Not 
sure if the Codec enum in AvroOutputFormat is the best solution because its an 
additional wrapper around the avro CodecFactory. If you have doubts in this let 
me know :-)

Lars


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---