[GitHub] flink issue #2642: [FLINK-3999]: Rename the `running` flag in the drivers to...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2642 @nssalian Thanks for understanding. We as a community together have actually gone into that mode (more conservative and stability focused) not too long ago. So it is still a bit of a learning process for everyone here (committers and contributors). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2642: [FLINK-3999]: Rename the `running` flag in the drivers to...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2642 Thanks @uce, agreed, it would be a community effort indeed. I will try to help as much as possible. @ggevay, it's alright. I'll close the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2642: [FLINK-3999]: Rename the `running` flag in the drivers to...
Github user uce commented on the issue: https://github.com/apache/flink/pull/2642 @nssalian Your suggestion regarding JIRAs makes very much sense. Let's try to ensure that this does not happen again. But no single person can do this alone... we have to do it as a community. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2642: [FLINK-3999]: Rename the `running` flag in the drivers to...
Github user ggevay commented on the issue: https://github.com/apache/flink/pull/2642 OK, I see your point now @StephanEwen. @nssalian, I'm sorry for opening the jira; I didn't think it through from this perspective at the time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2642: [FLINK-3999]: Rename the `running` flag in the drivers to...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2642 @StephanEwen ,thanks for that, that makes sense. But it is hard for someone new to understand the problem you mention. If someone familiar with the product, could review new JIRAs for clear benefit / validity, that would encourage folks jumping on the tasks to know it better. I realize it may not be feasible but it saves time too to let them know in advance. I can certainly close the PR and make it Not a Problem. But if there is a better way to have this clearer , I would appreciate it before the effort is put in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2642: [FLINK-3999]: Rename the `running` flag in the drivers to...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2642 I am a bit skeptical about these types of changes. Maintaining stability of Flink is crucially important now. With changes like these we risk introducing subtle bugs without fixing a bug or improving a functionality or anything. It just changes a naming preference. The kind of bugs one can introduce with changes like that are very subtle (we have seen that in cases where the cancelling logic was fragile depending on how the flag was exactly set) and hard to catch all in reviews. Not everything is fully covered by bullet proof tested in practice. I would actually suggest to rather contribute on issues where there is a clearer benefit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2642: [FLINK-3999]: Rename the `running` flag in the drivers to...
Github user nssalian commented on the issue: https://github.com/apache/flink/pull/2642 @ggevay they are not related.. I think it caught from me old branch on to this one. The 3 in the middle2ef4401,46d91b0,1433a5d are relevant here. Apologies for the mix up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2642: [FLINK-3999]: Rename the `running` flag in the drivers to...
Github user ggevay commented on the issue: https://github.com/apache/flink/pull/2642 Could you please explain why are the first and last commit (65b3ff78f100ed1b13ec2fcc727f4869823b5918 and ba4f429043f3985db5ab37a3902a6fee15a7440e) necessary? Are they related to FLINK-3999? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
