[GitHub] flink issue #2790: [FLINK-4491] Handle index.number_of_shards in the ES conn...
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2790 Thank you @ddolzan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2790: [FLINK-4491] Handle index.number_of_shards in the ES conn...
Github user ddolzan commented on the issue: https://github.com/apache/flink/pull/2790 Index template and index mapping creation/configuration will be kept outside of flink. An example on how to do it can be found on https://github.com/okkam-it/flink-examples. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2790: [FLINK-4491] Handle index.number_of_shards in the ES conn...
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/2790 Fine for us about the ES helper. Since it took some time to implement that functionality and the was a JIRA ticket for that we thought that it was a good idea to share that code with other users. I think we can still share it on out flink-example githib repository (https://github.com/okkam-it/flink-examples) for anyone that has similar needs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2790: [FLINK-4491] Handle index.number_of_shards in the ES conn...
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2790 I agree with Fabian here. The ESHelper does not use any Flink code at all, so the relation to Flink is not clear. A user of Hadoop would equally benefit from such a utility. I would expect that ES provides such tools to Java developers. Maybe there is a repository somewhere offering ES tools / abstractions? Apache Kafka for example also provides a set of tools to query the status of consumers, etc. independent of the framework consuming the data. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2790: [FLINK-4491] Handle index.number_of_shards in the ES conn...
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/2790 From my point of view ElasticSearchHelper is very useful if you plan to use the Flink Elasticsearch Sink in a real production use case, because it reduce a lot the complexity of interfacing with ES. We didn't use ES java client before and it took about 2 days to write that helper...I think it's not that obvious to rewrite that logic from the scratch. Ina production environment you really needs to easy customize indexing templates and mappings IMHO --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2790: [FLINK-4491] Handle index.number_of_shards in the ES conn...
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2790 Thanks for the pull request @ddolzan and sorry for the delayed review. To be honest, I am not sure if we should include the `ElasticSearchHelper` in Flink. I see that might be helpful for some users, but it does not contain any Flink related code and is in principle a light-weight Elasticsearch client. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2790: [FLINK-4491] Handle index.number_of_shards in the ES conn...
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/2790 Any other feedback on this?could it be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
