[GitHub] flink issue #2905: [FLINK-5190] [runtime] fix ZooKeeperLeaderRetrievalServic...

2017-03-10 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2905 I fear that we cannot merge the PR as it is, because it would leave the `CuratorFramework` client open for some of the components used in the master. For example, the `WebMonitor` uses the same

[GitHub] flink issue #2905: [FLINK-5190] [runtime] fix ZooKeeperLeaderRetrievalServic...

2016-12-02 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2905 Ah, this refers only to `flip-6` - then it makes sense :-) Will merge this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink issue #2905: [FLINK-5190] [runtime] fix ZooKeeperLeaderRetrievalServic...

2016-12-01 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/2905 @StephanEwen yes, the client are both started and stopped in ZookeeperHaServices. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink issue #2905: [FLINK-5190] [runtime] fix ZooKeeperLeaderRetrievalServic...

2016-12-01 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2905 Thanks for the patch! Is there another place where the client now gets shut down properly? --- If your project is set up for it, you can reply to this email and have your reply appear on