[GitHub] flink issue #2995: [FLINK-5320] Fix result TypeInformation in WindowedStream...
Github user ymarzougui commented on the issue: https://github.com/apache/flink/pull/2995 Thanks @aljoscha for merging and adding the appropriate tests. Closing the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2995: [FLINK-5320] Fix result TypeInformation in WindowedStream...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2995 @ymarzougui I finally merged it and added some new unit tests on top instead of the heavy IT case, I hope that's alright. Thanks for finding this in the first place and fixing it! ð Could you please close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2995: [FLINK-5320] Fix result TypeInformation in WindowedStream...
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2995 I have some work in the window translation tests that should make testing this more easy: https://issues.apache.org/jira/browse/FLINK-5237 @StephanEwen what do you think about merging this in the meantime with this ITCase? I'm somewhat hesitant because these heavy IT cases increase build time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2995: [FLINK-5320] Fix result TypeInformation in WindowedStream...
Github user ymarzougui commented on the issue: https://github.com/apache/flink/pull/2995 @StephanEwen @aljoscha, I added a test for `WindowedStream.fold()` similar to the one in [EventTimeAllWindowCheckpointingITCase](https://github.com/apache/flink/blob/master/flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeAllWindowCheckpointingITCase.java#L285). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2995: [FLINK-5320] Fix result TypeInformation in WindowedStream...
Github user ymarzougui commented on the issue: https://github.com/apache/flink/pull/2995 Yes, I will see how to add a unit test and try to add a commit to this PR by the end of the day or tomorrow. Fortunately the fold in `AllWindowStream` is correct, the problem in `WindowStream` is due to a mistake by me when I contributed FLINK-3869. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #2995: [FLINK-5320] Fix result TypeInformation in WindowedStream...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2995 Thanks a lot, this looks like the correct fix. Usually, we add a small unit test to such fixes to guard the bugfix. Also, the same problem probably exists in the `AllWindowStream`. Would be nice to fix that as well as part of this issue. Would you be up for following up? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
