Github user mxm commented on the issue:
https://github.com/apache/flink/pull/3086
No, looks good. Thanks. As Greg mentioned, please open a JIRA issue next
time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kaelumania commented on the issue:
https://github.com/apache/flink/pull/3086
@mxm thanks :) needs there anything to be done, until this PR can be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user kaelumania commented on the issue:
https://github.com/apache/flink/pull/3086
@mxn neither `docker build` nor `docker compose build` support setting
environment variables from outside during the build. Further as the
`docker-compose` documentation states
> Note: If
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/3086
@kaelumania `ARG` is only available from Docker 1.10 on and upwards. I
believe docker-compose also offers to configure environment variables either
through the compose file or via a command-line
Github user kaelumania commented on the issue:
https://github.com/apache/flink/pull/3086
@mxn One drawback using `ENV` might be with docker-compose, see
https://docs.docker.com/compose/compose-file/#/args which states
> You can omit the value when specifying a build argument,
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3086
For creating tickets, it's actually a requirement from Apache Legal as PR
comments are then automatically added to the associated Jira which documents
the contribution of the code to the project.
Github user kaelumania commented on the issue:
https://github.com/apache/flink/pull/3086
I am not sure, why the build fails as I am not deeply familiar with the
Java/Scala world.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user kaelumania commented on the issue:
https://github.com/apache/flink/pull/3086
@greghogan No, I didn't create a Ticket (sorry, I was not sure if this
change justifies a Ticket). But I would love to see a Ticket about an automated
build at DockerHub for Flink.
---
If your
