[GitHub] flink issue #3119: [FLINK-5468] Improved error message for migrating semi as...
Github user uce commented on the issue: https://github.com/apache/flink/pull/3119 Thanks for the PR. Looks good to me. I'm going to merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3119: [FLINK-5468] Improved error message for migrating semi as...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3119 Looks good to me, +1 to merge it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3119: [FLINK-5468] Improved error message for migrating semi as...
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3119 I changed the PR like @StephanEwen suggested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3119: [FLINK-5468] Improved error message for migrating semi as...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3119 Good fix! I was wondering if we can make the "separation of concerns" a bit nicer if we keep this special case check out of the Savepoint Serializer, but instead add the "SemiAsyncSnapshot" class to the migration package and throw this exception in a static initializer of that class. Do you think that would work? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3119: [FLINK-5468] Improved error message for migrating semi as...
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3119 cc @rmetzger --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
