[GitHub] flink issue #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's algorithm)

[skonto]

Github user skonto commented on the issue:

https://github.com/apache/flink/pull/3192
  
@sachingoel0101 np as soon as you are ready let me know. Also @tillrohrmann 
made some comments to take into consideration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's algorithm)

[sachingoel0101]

Github user sachingoel0101 commented on the issue:

https://github.com/apache/flink/pull/3192
  
@skonto I'm traveling right now and won't be able to push an update until
Monday/Tuesday.

On Feb 9, 2017 09:31, "Stavros Kontopoulos" 
wrote:

> @sachingoel0101  could you update the
> PR so I can do a final review and request a merge?
> @tillrohrmann  could assist with the
> forwardedfields question?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's algorithm)

[skonto]

Github user skonto commented on the issue:

https://github.com/apache/flink/pull/3192
  
@sachingoel0101 could you update the PR so I can do a final review and 
request a merge?
@tillrohrmann could assist with the forwardedfields question?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's algorithm)

[skonto]

Github user skonto commented on the issue:

https://github.com/apache/flink/pull/3192
  
I have run the tests and verified the code, seems to work fine. I need to 
check the centers generated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's algorithm)

[skonto]

Github user skonto commented on the issue:

https://github.com/apache/flink/pull/3192
  
Correct, just saying we will need to create a set of examples for the ml 
library. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's algorithm)

[sachingoel0101]

Github user sachingoel0101 commented on the issue:

https://github.com/apache/flink/pull/3192
  
Just fyi, that is not an example of the usage of machine learning library. 
It is just a standalone implementation of the linear regression model. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's algorithm)

[skonto]

Github user skonto commented on the issue:

https://github.com/apache/flink/pull/3192
  
Ok ... there is one 
[example](https://github.com/apache/flink/blob/master/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/ml/LinearRegression.scala).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's algorithm)

[tillrohrmann]

Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/3192
  
We could think about adding examples to flink-ml itself. But this is not 
strictly necessary if the API and its usage is documented.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's algorithm)

[sachingoel0101]

Github user sachingoel0101 commented on the issue:

https://github.com/apache/flink/pull/3192
  
I'm not sure about adding examples under flink-examples project. None of 
the other ml algorithms are there either. Also, requires adding flink-ml as a 
dependency in the pom. I can however add a kmeans section under ML docs 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's algorithm)

[tillrohrmann]

Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/3192
  
@skonto you're right that we should also add a corresponding kmeans 
documentation under `docs/dev/libs/ml/kmeans.md` and link it from the 
`docs/dev/libs/ml/index.md` file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's algorithm)

[skonto]

Github user skonto commented on the issue:

https://github.com/apache/flink/pull/3192
  
@sachingoel0101 please add an example at least under flink examples.
Is the code documentation enough? @thvasilo ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's algorithm)

[skonto]

Github user skonto commented on the issue:

https://github.com/apache/flink/pull/3192
  
@sachingoel0101 I am having a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3192: [FLINK-1731][ml] Add KMeans clustering(Lloyd's algorithm)

[sachingoel0101]

Github user sachingoel0101 commented on the issue:

https://github.com/apache/flink/pull/3192
  
/cc @skonto @thvasilo


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---