[GitHub] flink issue #3206: [FLINK-5612] Fix GlobPathFilter not-serializable exceptio...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/3206 @zentol Sure. Thank you for merging this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3206: [FLINK-5612] Fix GlobPathFilter not-serializable exceptio...
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3206 @mushketyk The changes have been merged, could you close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3206: [FLINK-5612] Fix GlobPathFilter not-serializable exceptio...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/3206 Thank you @StephanEwen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3206: [FLINK-5612] Fix GlobPathFilter not-serializable exceptio...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3206 Looks good, will merge this and fix the public annotation on the fly.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3206: [FLINK-5612] Fix GlobPathFilter not-serializable exceptio...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3206 @EronWright Agreed, this should be `@Public(Evolving)`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3206: [FLINK-5612] Fix GlobPathFilter not-serializable exceptio...
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/3206 Just hit this issue, was about to file an issue. Awesome to see this fixed. It is odd to me that `GlobFilePathFilter` is marked `@Internal`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3206: [FLINK-5612] Fix GlobPathFilter not-serializable exceptio...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/3206 Hi @StephanEwen, @zentol Thank you for helping with this PR. I've updated it according to your review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3206: [FLINK-5612] Fix GlobPathFilter not-serializable exceptio...
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3206 +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink issue #3206: [FLINK-5612] Fix GlobPathFilter not-serializable exceptio...
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/3206 Hi @StephanEwen, @zentol Thank you for your comments. I've update the PR accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---